From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Gabor Juhos" <j4g8y7@gmail.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marek Behún" <kabel@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: cznic,turris-mox-rwtm: convert to DT schema
Date: Sat, 21 Feb 2026 19:31:13 +0100 [thread overview]
Message-ID: <77c45be6-a0c1-4799-9491-f7e492d60aab@kernel.org> (raw)
In-Reply-To: <20260221-mox-rwtm-yaml-v1-1-25dec4a0228b@gmail.com>
On 21/02/2026 19:21, Gabor Juhos wrote:
> +
> +description: |
> + This device tree node should be used on Turris Mox, or potentially
> + another A3700 compatible device running the Mox's rWTM firmware in
> + the secure processor (for example it is possible to flash this
> + firmware into EspressoBin).
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: marvell,armada-3700-rwtm-firmware
> +
> + - items:
> + - const: marvell,armada-3700-rwtm-firmware
This makes little sense. How this can be alone and followed by fallback?
Plus adding new compatible has to be explicit in commit msg, including
the reason (existing users).
> + - const: cznic,turris-mox-rwtm
Anyway, not tested. Please test your patches BEFORE you send them. I
finished review here because of that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-21 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 18:21 Gabor Juhos
2026-02-21 18:31 ` Krzysztof Kozlowski [this message]
2026-02-23 10:57 ` Gabor Juhos
2026-02-23 12:32 ` Gabor Juhos
2026-02-21 19:20 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77c45be6-a0c1-4799-9491-f7e492d60aab@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=j4g8y7@gmail.com \
--cc=kabel@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®