From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D36D5B5AB for ; Thu, 4 Dec 2025 14:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764858954; cv=none; b=oOEpB1rPV6GluvIjXn2Ib/s8F5xvlg+i+4TNhJx4LR13HilRvhJAJBLI/VYpbUoyXvWZo83Jdrt7pod1neSZfDX8UQS8jRmngVvi4um+i88hibDY0z+nJej1esQEnvouk6XenWhE0GsrEUFSLWVynRVKg2sqki+LHfwNYCdxHY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764858954; c=relaxed/simple; bh=Hzz+mPxqldPjZ0UGeBzerpsI2NE9QERo1z4GmIcyRAs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=as143RV2RwnqBjyUn4q39GVGpqi/GXKIhuzNmzTWKDD4kqsXUscEpKc+NJW10c+Alb9OEID5/kKRq01kdJrgTFcI1WEjIN3P6B8Uo0r+zSySnpE29kwz/P6N01cXlin2uAmigyxBsO9nX/1NrCxHMkK54XxR9GS6CM2hDI3VczU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S6/rHqn9; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S6/rHqn9" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-477a1c28778so14312045e9.3 for ; Thu, 04 Dec 2025 06:35:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764858951; x=1765463751; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1Ns2EjNq5op1uWpU/IDU/iN5rRJVwaStIACnAldV00Y=; b=S6/rHqn9E6dMhZrOqG2IzpTGVHBQ19zK7R718LJs9Iz26CEyqyf7DL9awAwNoszkEA tYQmXqr2ybPV6TBnMYYrL934rQNohrDGcEp9ZfZEAJfOzx+eP+IGrXTofOF5YSJAJ+wp iUMxsLvZD75PVUeFe8YrAVeLKi0raOZAz1BiALhZ3F169EjPMZNP2w/W9UTB7wLP3LBt 3Cvg8sCEnPVkyOXfJa7vasrmBBKA4w+V46HbqsDO4UM4za8O2DO1njhhgvTAisiVluFR OT31nZvEt4qmURA2hKYOyvGWeWGbYt8rzMBUE/Jm1VqLXK3pns3anS8VRZMrWjGzIQPb BJXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764858951; x=1765463751; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1Ns2EjNq5op1uWpU/IDU/iN5rRJVwaStIACnAldV00Y=; b=vZkKZq6Zvk5TPUSm/rtxvtIXjOZ3k39vhDoFyDpH6ju9xq0Q+d22S+9pJXKB8dGko/ PSu3SlvtvqPUsm1dmbgwYl6qM+168bCUq5MmVD1WdBKrMnvnIFyU9ysgdqJFUvcVKzgb qcJxJlsuAlMiWfKXCJjblPdGFQz4/z92BwZYBkAe6eMIzh23R8Rc3EpakWbDyaff22xy JbFF2krA9e++nYmGnYLC6HHfcacaq72E6lQIe67HbbQaqiuhkun4TbTb/v36caWRhR5/ 6lvIiRjTrsqlQFLRMhwQW0HQOnZrLyA8f2zlCHwhPfkaxY/UWMjrxzr7EnJ+GIbjP4v4 bpcw== X-Forwarded-Encrypted: i=1; AJvYcCWpvgrHznj7UMv3JNPDpo3KDfW1Soz2TDB7nNR3ybYflXGK7mPeBR1RzAdq32jmMV0VEmQ9XmzUmTrSVMk=@vger.kernel.org X-Gm-Message-State: AOJu0YztYDNZH2O1iogEbhlsn8+CB45x/Ii1mFAt4sqrdCpxik3Ea/9Q e2ri65AFVunigIjdOdy90aAG1k6MBssuRCZBvJ1BQKe2t2wQW8A4flnO X-Gm-Gg: ASbGncuyLP2NH1slt+PvZCPT6fd14LGuUVeW5IvENKMlY6/GVcmdXBrQYS5LwZxWQK4 q9Y77qp0mjfnGwtawqX+jHFjUaKAsAXlFt6UzpQPyaCQohbCnCOudn7mY9dO3adtu4ytD2zwwsn OQbFgDcqjpoEnMuDKHqLaWuD/XOAkuxaolaD+EZqhrUjyXznFR/TzRw8WpiqfrRNA8WfWFwdFSi AllZlqlrrIBrE1+SrSB4a77hwq7fEcbl8msxpO4tcf1wYMU6j5vL3ril4dRvcVYyLcJktXqw33v DqMn7G06Bab/Vh73iddRF0k6STnr6umspS6dCfegnKkcjCcdVZeJmT8e6Zq5wONxSGcpMOYUeQ9 P9PCXv303JGuH3tZyV13UXp9s6EPowMzasEaGGoOedHrKGFgsXULMSiikRFde0NAnjLZ18aQsbb SXLa/MCWAj3N5D5mzubWk= X-Google-Smtp-Source: AGHT+IG2seHuOWerjwXCdph63ZC8vZL+eIqVpQkFO/I0w+Uy389U61OmS2BgkM1euyc2+4rlvr7rWg== X-Received: by 2002:a05:600c:4e8a:b0:477:9986:5e6b with SMTP id 5b1f17b1804b1-4792f395439mr23688625e9.28.1764858950670; Thu, 04 Dec 2025 06:35:50 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d22249esm3624680f8f.25.2025.12.04.06.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Dec 2025 06:35:50 -0800 (PST) Message-ID: <77ca77847511e67066a150096a7af2fb84f1f25f.camel@gmail.com> Subject: Re: [PATCH RFC 0/6] iio: core: Introduce cleanup.h support for mode locks From: Nuno =?ISO-8859-1?Q?S=E1?= To: Kurt Borja , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Benson Leung , Antoniu Miclaus , Gwendal Grignou , Shrikant Raskar , Per-Daniel Olsson Cc: David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Guenter Roeck , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Date: Thu, 04 Dec 2025 14:36:30 +0000 In-Reply-To: <20251203-lock-impr-v1-0-b4a1fd639423@gmail.com> References: <20251203-lock-impr-v1-0-b4a1fd639423@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-12-03 at 14:18 -0500, Kurt Borja wrote: > Hi, >=20 > In a recent driver review discussion [1], Andy Shevchenko suggested we > add cleanup.h support for the lock API: >=20 > iio_device_claim_{direct,buffer_mode}(). We already went this patch and then reverted it. I guess before we did not = had ACQUIRE() and ACQUIRE_ERR() but I'm not sure that makes it much better. Loo= king at the last two patches on how we are handling the buffer mode stuff, I'm really n= ot convinced... Also, I have doubts sparse can keep up with the __cleanup stuff so I'm not = sure the annotations much make sense if we go down this path. Unless we want to use = both=C2=A0 approaches which is also questionable. - Nuno S=C3=A1