From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4DFDC001DF for ; Fri, 4 Aug 2023 19:14:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbjHDTOu (ORCPT ); Fri, 4 Aug 2023 15:14:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjHDTOr (ORCPT ); Fri, 4 Aug 2023 15:14:47 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABD93B9 for ; Fri, 4 Aug 2023 12:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=aREuGkA6w6ZICk1lacHviCDE3QhBS3vYAP3oRmfIz2g=; b=UN53eR/oleMlzX8th93EgvH1hM h6VWPT4wWPTy7mBKrB9su6MXRV2bAgQBHnQMUihJ7UVVSfPDTKZ0C4UQ9fens3ReZLB6hzTsm6uDP Jwd7saRxo3qI6xqyc/vrFkg+lrY3cZvqXwMx0Et4EmwrCurvVM3As9CMIHt2b4YZZMueGLcJOfpS0 ZXjkQEf2cL81PovwJVdvKHSpJ55FhflIq80v3Fbv1u5ATYFo3di+ETGZS95UwuQ8HntRq/z5/yphT sj8qdXeBvgSqaT5gT45X/+us0kOW0ufyQINfBmPXOO0OmamY0gTajROqUyI52CVZmPRPwjuCXZKWC GlYC7e8g==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qS0G5-00D5rN-31; Fri, 04 Aug 2023 19:14:45 +0000 Message-ID: <77cdbbed-e64d-0c55-bf0a-6dfcfbdb8b20@infradead.org> Date: Fri, 4 Aug 2023 12:14:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION Content-Language: en-US To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Arthur Grillo , Daniel Vetter , David Airlie , Helge Deller , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20230804125156.1387542-1-javierm@redhat.com> From: Randy Dunlap In-Reply-To: <20230804125156.1387542-1-javierm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/23 05:51, Javier Martinez Canillas wrote: > The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev > emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' > to an effective 'select FB_CORE', so any config that previously had DRM=y > and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y. > > This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > as reported by Arthur Grillo, e.g: > > WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE > Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] > Selected by [y]: > - DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n] > > Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the > DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could > be to enable DRM fbdev emulation but without a framebuffer console. > > Fixes: c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") > Reported-by: Arthur Grillo > Closes: https://lore.kernel.org/dri-devel/20230726220325.278976-1-arthurgrillo@riseup.net > Suggested-by: Arnd Bergmann > Signed-off-by: Javier Martinez Canillas Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Thanks. > --- > > drivers/gpu/drm/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index b51c6a141dfa..2a44b9419d4d 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM > - select FRAMEBUFFER_CONSOLE if !EXPERT > select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE > default y > help -- ~Randy