From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.8 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793275272; b=HwXg2fNd2PxyLgVzxGWgQ8ZeW8v7hdf2u34X289bQ/8bAW0/HMZVMy9xDeT3PgyxOVqC JNKYOKdXnvmzbggSVGbaCTLctuhh9TA7ryKMxMJIoIYFHI6Fj/JwMQzbi7CS7sLYQJ7N5 vICUtMZubkci19kpGLW+ZcoTp4UO2H5qYh4f+YR/fdaEbYw5orxRzLO1fXsB9E69mc7pD b0vz49HmdI6JvGHIR5AL6srDQgceqvklr1j4IGdIj10Lvvw8XH5Zykgo0culBpBFWe7zF sgn7A6nEkkX49rvOMGyUtm14Wxj5o3GAR2RCYaQo/AIw3uD0V6xBIvDoVKa5b6swYnA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793275272; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:From:To:Cc:Subject: In-Reply-To:Organization:References:Date:Message-ID:MIME-Version: Content-Type; bh=6ox96XF7TR2O7kzILwg61Yy6ZNx/dN3lPRd2O0EFb20=; b=UqKPxFXsCKDrRPPND9PkLORFHbl3JADcnhsRsdEzYRVUgrO65BBR/1cDIeq1hY/36VXH rneUtsSn88ufQpJwGhZ9TUp0Wj//sW9OSBhcgMnuOx7zjUL44gz+0+7y3TMBTngOy+q5N FtxPHT0JvAkPwWkG9PGDhEV+SBljPKXdNn8IHwMOfHJpcnfbKLTqhrcSOXKdt0vbRXa+Y +rXOy/X+B9283djJIirKfSeMsD07qFh8qE02FU2A1p/C+t5BdPK0LqLy2CPKPS/NIgzCJ PpIxl7ISuL+qPHJiMsgi/7Y8E80HvsRlNK8gTiKjfUXveqWMgYEpzS18I/fYJxXSh3w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=RcQFyetm; arc=none smtp.remote-ip=192.198.163.8 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46929606A31C for ; Thu, 29 Oct 2026 12:01:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 46929606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=RcQFyetm DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793275271; x=1824811271; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Sg99qBSYPrQ/dvhBMnxG7AV2h/mgImJ/LtHy20Vj8R4=; b=RcQFyetmjjAuZ89X/lZqjlnO/9AfaO3FSpcw2YzFyWJ3v+fZLwfAjuId ysqEcSa2pAmhB8R0eS7fPPUPRyVUHggR1dmLbE6ZrnVtbIUNt1NDd1EQK aDGvkYoclQuYFNzIadIvLhf3TyogorTItrpBgY584srh1yzdxM0UP1qXC ARVHOTh9WHs1IrVtKQ0TBK8ERr7LBuCXz2aNjliyqJQqCAy+P7163p7xD jyr1CljPoOpba31KQBbNXnyjhiTPHSdr6QBB5OmtjPa9D4/qJOTQ+1RGg RTJP4dCgxVXuYKfmoYTPjr9T3gx9aXx+UU7SpJUjpd/gFJCALvnCornWY w==; X-CSE-ConnectionGUID: 261yX6nFQQS9jDxaHo4mqw== X-CSE-MsgGUID: 6tlgMfO8R0ON8nnultAiow== X-IronPort-AV: E=McAfee;i="6800,10657,11949"; a="1908938" X-IronPort-AV: E=Sophos;i="6.27,184,1787036400"; d="scan'208";a="1908938" Received: from fmviesa012.fm.intel.com ([10.60.135.152]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2026 05:01:10 -0700 X-CSE-ConnectionGUID: 5EX7hURQSrqLzZCP6wxP0w== X-CSE-MsgGUID: c117/tVSTQiEeJx+aVTUhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,184,1787036400"; d="scan'208";a="6889781" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.145]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2026 05:01:04 -0700 From: Jani Nikula To: Dmytro Malovanyi , dri-devel@lists.freedesktop.org Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Patrik Jakobsson , Lyude Paul , Danilo Krummrich , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmytro Malovanyi Subject: Re: [PATCH v2 3/5] drm/bridge: it6505: Use drm_dp_enhanced_frame_cap() In-Reply-To: <20261029101826.72773-4-dmitrymalovanyy@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20261029101826.72773-1-dmitrymalovanyy@gmail.com> <20261029101826.72773-4-dmitrymalovanyy@gmail.com> Date: Thu, 29 Oct 2026 14:01:00 +0200 Message-ID: <77d3b5f1643531134754303befe9ee2c3c13d5f6@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain On Thu, 29 Oct 2026, Dmytro Malovanyi wrote: > Use the helper instead of checking DP_ENHANCED_FRAME_CAP directly, so > enhanced framing is used for all DPCD r1.2+ sinks as the spec requires. > > Compile tested only. > > Signed-off-by: Dmytro Malovanyi Reviewed-by: Jani Nikula Here too the driver should probably use drm_dp_read_dpcd_caps(), but again beyond the patch. > --- > drivers/gpu/drm/bridge/ite-it6505.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c > index e136ac71e..d798a3db7 100644 > --- a/drivers/gpu/drm/bridge/ite-it6505.c > +++ b/drivers/gpu/drm/bridge/ite-it6505.c > @@ -1651,7 +1651,7 @@ static void it6505_parse_link_capabilities(struct it6505 *it6505) > link->rate = drm_dp_bw_code_to_link_rate(it6505->dpcd[1]); > link->num_lanes = it6505->dpcd[2] & DP_MAX_LANE_COUNT_MASK; > > - if (it6505->dpcd[2] & DP_ENHANCED_FRAME_CAP) > + if (drm_dp_enhanced_frame_cap(it6505->dpcd)) > link->capabilities = DP_ENHANCED_FRAME_CAP; > > DRM_DEV_DEBUG_DRIVER(dev, "DPCD Rev.: %d.%d", -- Jani Nikula, Intel