From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752501AbdEFNzH (ORCPT <rfc822;w@1wt.eu>);
        Sat, 6 May 2017 09:55:07 -0400
Received: from mout.web.de ([212.227.17.11]:49300 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750947AbdEFNzD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 6 May 2017 09:55:03 -0400
Subject: Re: GPU-DRM-STI: Fine-tuning for some function implementations
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        David Airlie <airlied@linux.ie>,
        Fabien Dessenne <fabien.dessenne@st.com>,
        Vincent Abriou <vincent.abriou@st.com>,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <f4a1bd89-50c4-ea2d-ea70-de5209b8a55a@users.sourceforge.net>
 <20170505140916.zoe4sxe3xjtvdlag@art_vandelay>
 <b859d1fb-bdf2-1738-8f28-28a31419b0d1@users.sourceforge.net>
 <20170506123304.2scgonpvt7kjf4cz@art_vandelay>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <77d74ffc-c833-f7ad-b1e2-5e07ac9d23a7@users.sourceforge.net>
Date: Sat, 6 May 2017 15:54:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.0.1
MIME-Version: 1.0
In-Reply-To: <20170506123304.2scgonpvt7kjf4cz@art_vandelay>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:j2tS6R9SXrmMIUEiq56V7aoTPcYBPqScfOZwaLXbNyDE2d0WSNs
 Y+tjFwl8wlFxdWmge5sXtpDoENNzBijjQnRrH9M2UBhn691DWhwooMTWuW22179hsCBtrnG
 8ENRYpLGJyuKg3RAWWy54J/jhN16jurtUccOLTZ8DBfcWPbjiVrEarYwCI5mZLapNUT+isy
 /QGISPjBB4cM3cT71FhXw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ONTYhUm3b9Y=:/T4rR9wGQx8hLg+N9c2GA/
 44PfozEN9a/XKTRndZSGHpaW1+t0NlKbtKBH7F7if266RiNv0vMninzKTPDg0p3J7iaUYDBvV
 J2eDb1/RyvYt7tFEIYjMHcgKJNouANbhUGGkPdTx92ipscVt+ovvYq+DG/XkITBj2t/6a1EiP
 y+qCUwFEIiE6ACEOopSCPjXblxBMsNbs1J/24C1bSeWqcBJ08TkcqBFVdIRuLVomjZz803rhO
 3vhjS6h+/hRoo61CNxBqLMHYB26PIRy+V1i/Tp00OXrZ9E7izs72/0V9ydIRW/KUvU87gqHu6
 kb7w4pmaP7MDwOQ6owY8YLRq+N/FFZVd1so07U/riSDTVNpIyNYTEp2ZAoaHRn+ds0eBETVkX
 MpJRhJ+77Lf1rb/O2z8BdzSFfHsdq1lBJGUw9RqYWnk4eAmrseX5ng2o7Vom0+aimwHmloUpk
 Jh9DjNfjm+P5HUIsCRjZ+r2/O2Car3PpZnGMku8tcQuIrGk8yxtPv+1PjsWAyXQXiCfJTv9x9
 0V826ZK3kwshg9Ds8jBu83YA/fuKCvra88a/g44PCa/OV15di9bKnBOxxbIc44v8gkTXm5AL4
 I57YM3Bk8r3EfRLCKyliIUraVrTePXhYCf2JY2242m9PnQRjlLqPFFINMfMyF1SeaZZxoQbCV
 U4/DOdTueo8ynbdnWwzobxYpSDPdV9eJcTfR1sbmGEY+o4EdtkLyVC9dTPVv681aIqwwGOQ36
 pjqbHUJj2NUeSmkablOXsIB08B9OPTRwyflVkqybH+UPxRBM/yg8KACel+IIKKo5lcW2/87Hj
 lRnidaR
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Generally speaking, I don't care about checkpatch/cocci changes that aren't tested.

I find this view interesting only to some degree.

1. I suggest to combine a few functions into fewer ones.
   * Do you spot any programming mistakes in these concrete cases?
   * Can such code reduction result into desired effects?

2. I propose to use the function “seq_putc” at more source code places.
   * Do you really find any previous system test approaches insufficient around
     such a Linux feature?
   * Does the programming interface “seq_puts” provide any properties
     that you prefer over the other one for the sequence output of single characters?
     http://elixir.free-electrons.com/linux/v4.11/source/fs/seq_file.c#L664


> With your changes, we don't have this upside.

How do you think about to pick spelling corrections up for two comment lines?

Regards,
Markus