From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1ECD1A01BE for ; Mon, 13 Apr 2026 13:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776087110; cv=none; b=mj5UXwOQD5LcG1pNjsWfC/CE4PsUROaGj5MwG52PJhysVWf1Uj7doCZjlRK9nUCyGSPt5VHogwKG/tWAKu5/9OzA1agAYbzGfktHDPtz+w8lu/YkvCtlnchJ2bpGF7w7VhDRDim5UpvJBs1hQ2TocCkiJRWaoxxbY+f3E+3cGIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776087110; c=relaxed/simple; bh=xxT/fy6/UObnhRxc4ECkdOpyQ+/HUtxYSWW3PtJ0LQM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Mg2fAvQFzfRec3sr/cEtu3fREdsAkSaoHM2UK+1hiuPsu4fAZbi8dxr0vknkY8kjj1UqEN1oIGW6282c4JcvCRCU0mV3y1dagkPcAEUjxNUGuFkTI6VYMQ1AvmYOKBOMUFzyLekFkm0em+DUL8pcNyyvLDpuTYxjxuDoixPeoiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QpxoCDog; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ryENCRi6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QpxoCDog"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ryENCRi6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776087107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FC7co2loVELcleMxkvuZPl6ziMWocTcQ0HRSUD7DVoQ=; b=QpxoCDogs1GKUcYsKkU1/DPkPSsnD4IN56JO+N00kCmX+U/dVWc/Jm4DljD/2k+q31MIhX Zo85k6WDrehdC3cZpN36/W69ZH7Edu3SNPEqOdSsz6cah+QD7ZGXGeto06YG0B9fSEhOhs 2v3P3qcm9is3y7km9cuzl7WZssVj9pw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-9vcU9QznPRyjXcX_KvmVyw-1; Mon, 13 Apr 2026 09:31:46 -0400 X-MC-Unique: 9vcU9QznPRyjXcX_KvmVyw-1 X-Mimecast-MFC-AGG-ID: 9vcU9QznPRyjXcX_KvmVyw_1776087105 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d1fec59c9so2418399f8f.0 for ; Mon, 13 Apr 2026 06:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776087105; x=1776691905; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FC7co2loVELcleMxkvuZPl6ziMWocTcQ0HRSUD7DVoQ=; b=ryENCRi60wDPWhvM8mJI7zchwu3FrnSW7ZtN9xY0AwJx6o69YX7KPw5mij4+vtVYnb zeZahkGbcoq4D5O2OoM87dxK2PPFDeaVcDjJ52+61x5AsKurti4gV1FZ26brd1ZS8MpO ZeUEuLbzE5WCaRhDEtj4CFwih15f+4jeirOXT6FwTSV+fLtxOuJ7+kCw3Oleg62BkUxM 0w6bK68hkqcfpgZ9dCn9UIZG3/f+XMJt5bcxThpcg7Go/DjVI4yonU+nMTkVi+N6y+uz enNq1jPDfD6h+YTGuseF6rLABaFD5GhP0gcEv7mHBRUaa5EGpZYI1SjDDGIRLmSsbzcr lFtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776087105; x=1776691905; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FC7co2loVELcleMxkvuZPl6ziMWocTcQ0HRSUD7DVoQ=; b=B1bqzYkvEBJ2j1uQtQ6CtfKiGwKPVjq/cB2g+7FqS1p3gH4Ug/gcEV0IDYh6OLuka4 6gEjHD1Z9913OqWuTJQw6xbF3CeAnb1BatrjFtbjXo6AzwHkFI4z2IZXizaCQDYqOGMD WnVsOZs1Om7sD+8S3dRzWKarpQAqGJfK6QXiab6aIc7ryV/mxDdVGI/EIFgonaj6R7mD 8i/eE1BI/za7iEBvZPlZZXQ7Cx0SLUZ5i+BoO6T28/g9pNlA/zppRljD4vDy5yxJ26aB WzWH9BlzZ/Y2HxsA+E8LMOHFk3s+wR+cakCC9G5v4vxepGvtjdveyeExzLKTc/9xL+1J 79AQ== X-Forwarded-Encrypted: i=1; AFNElJ/woIqPJADtu2b/nMapfimYA2XwdvI+X+hra9SNq5Le2IAl3ZqgsK0Lz+t3nbzKfNMah18dTaF6bHz9x2I=@vger.kernel.org X-Gm-Message-State: AOJu0Yx16RwOR7gHp2Kx4FpAPznPFNbi88TATrN08c5itZ6MnMZqyV6B N4GNhtyyAIKhc67eTmLeWCm5nNDQDz2CdAP2DuFTps91TTPAMu1PbCh5uxy5+LT6QSvi9TNKwv/ smY1v6HljeTcqgsWI6IMcj6mUAese/iqHZyO82n6AxLOpBdWlnasPPE1OfuT4LlI4lg== X-Gm-Gg: AeBDieuOq0aYwlnZJGf/zsMqMMHq4/rr9BeYoMTocTnEEQSZt04XWa04C3Gy1EoYmZh uDck4/DkTf7O7N3TLrKIhQaNS14N1DDwc15EvGbTQK7qIgY/G/m+zOZnph0lBsqqpdjVY3P7o4a JNLmthYSgUVrWmXbj0AdcLbY0mR41Fz4aEK8ujKcTwlRc9JwuvtCIvVIDBsJeT76yANrNnjTOWp EmdWG1eAqp1tLdgHb01dPZbpbg0U4ofdRWXr9V/jjHVJyfYmefBhk+wKHjQFjsFEIs9JFhNlUw3 9K4CMMAdgXCRg2R0hdWSUDFwEJDS5YWuZov4Cw8JFvxV2ATr5fb3Eo4A8T/6f2LA0ATDO3/8fAN AW/FIy/Kxu8D1cmUWPyIF+cWmpk//Bc1YfwFTz8kh8pDa8qyTMAxryMob X-Received: by 2002:a5d:5f44:0:b0:43b:8e96:d3d2 with SMTP id ffacd0b85a97d-43d5958edb7mr23667138f8f.13.1776087104390; Mon, 13 Apr 2026 06:31:44 -0700 (PDT) X-Received: by 2002:a5d:5f44:0:b0:43b:8e96:d3d2 with SMTP id ffacd0b85a97d-43d5958edb7mr23667080f8f.13.1776087103849; Mon, 13 Apr 2026 06:31:43 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e46713sm34024811f8f.21.2026.04.13.06.31.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 06:31:43 -0700 (PDT) Message-ID: <77d813af-bfc8-495c-ad50-7401b86065a5@redhat.com> Date: Mon, 13 Apr 2026 15:31:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/2] net: mhi: Enable Ethernet interface support To: Vivek Pernamitta , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260409-vdev_b1_eth_b1_next-20260408-v10-0-6d44ca48f189@oss.qualcomm.com> <20260409-vdev_b1_eth_b1_next-20260408-v10-1-6d44ca48f189@oss.qualcomm.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260409-vdev_b1_eth_b1_next-20260408-v10-1-6d44ca48f189@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/9/26 8:08 AM, Vivek Pernamitta wrote: > @@ -208,17 +235,20 @@ static void mhi_net_dl_callback(struct mhi_device *mhi_dev, > skb = mhi_net_skb_agg(mhi_netdev, skb); > mhi_netdev->skbagg_head = NULL; > } > - > - switch (skb->data[0] & 0xf0) { > - case 0x40: > - skb->protocol = htons(ETH_P_IP); > - break; > - case 0x60: > - skb->protocol = htons(ETH_P_IPV6); > - break; > - default: > - skb->protocol = htons(ETH_P_MAP); > - break; > + if (mhi_netdev->ndev->type == ARPHRD_ETHER) { > + skb->protocol = eth_type_trans(skb, mhi_netdev->ndev); Sashiko says: Is there a risk of an out-of-bounds read or kernel panic here if a malformed or fragmented packet is received? eth_type_trans() assumes the SKB has at least a 14-byte MAC header and calls skb_pull_inline(). If the linear portion of the SKB is smaller than 14 bytes, __skb_pull() will trigger a BUG_ON(skb->len < skb->data_len). Should we call pskb_may_pull(skb, ETH_HLEN) before parsing the Ethernet header? > + } else { > + switch (skb->data[0] & 0xf0) { > + case 0x40: > + skb->protocol = htons(ETH_P_IP); > + break; > + case 0x60: > + skb->protocol = htons(ETH_P_IPV6); > + break; > + default: > + skb->protocol = htons(ETH_P_MAP); > + break; > + } > } > > u64_stats_update_begin(&mhi_netdev->stats.rx_syncp); > @@ -306,6 +336,9 @@ static int mhi_net_newlink(struct mhi_device *mhi_dev, struct net_device *ndev) > struct mhi_net_dev *mhi_netdev; > int err; > > + if (ndev->header_ops) > + eth_hw_addr_random(ndev); > + > mhi_netdev = netdev_priv(ndev); > > dev_set_drvdata(&mhi_dev->dev, mhi_netdev); > @@ -356,7 +389,8 @@ static int mhi_net_probe(struct mhi_device *mhi_dev, > int err; > > ndev = alloc_netdev(sizeof(struct mhi_net_dev), info->netname, > - NET_NAME_PREDICTABLE, mhi_net_setup); > + NET_NAME_ENUM, info->ethernet_if ? > + mhi_ethernet_setup : mhi_net_setup); Sashiko says: Does changing the name assignment type from NET_NAME_PREDICTABLE to NET_NAME_ENUM break backwards compatibility for existing legacy interfaces? NET_NAME_PREDICTABLE instructs userspace to leave the kernel-provided name alone, while NET_NAME_ENUM signals that the interface is a generic enumeration and should be renamed. Applying this to existing interfaces like mhi_hwip0 and mhi_swip0 might cause them to be unexpectedly renamed on boot, potentially breaking existing userspace network configurations. please have a look at the full report: https://sashiko.dev/#/patchset/20260409-vdev_b1_eth_b1_next-20260408-v10-0-6d44ca48f189%40oss.qualcomm.com /P