From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbdJYPw7 (ORCPT ); Wed, 25 Oct 2017 11:52:59 -0400 Received: from mail-cys01nam02on0067.outbound.protection.outlook.com ([104.47.37.67]:59700 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750923AbdJYPwz (ORCPT ); Wed, 25 Oct 2017 11:52:55 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Subject: Re: [PATCH] I2C-Octeon: Use common error handling code in octeon_i2c_probe() To: SF Markus Elfring , linux-i2c@vger.kernel.org, David Daney , Jan Glauber , Wolfram Sang Cc: LKML , kernel-janitors@vger.kernel.org References: <73affb84-9cdd-9f5c-b96a-5a392739e789@users.sourceforge.net> From: David Daney Message-ID: <77df0e64-bf30-b6d0-b28b-ddb3c0574dfe@caviumnetworks.com> Date: Wed, 25 Oct 2017 08:52:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <73affb84-9cdd-9f5c-b96a-5a392739e789@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: SN4PR0701CA0013.namprd07.prod.outlook.com (10.161.192.151) To MWHPR07MB3503.namprd07.prod.outlook.com (10.164.192.30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9779075d-90f4-4ba5-81dd-08d51bc07388 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:MWHPR07MB3503; X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3503;3:EqrPt6PB+bZOYIEzMdjIeaXSPzXHaWuVa0yVQGAnJ3vgiC4+7kB35/vWW7h5jT6bYguHUrqcOD7Cs2ZE9cAr0xgNlyet27E3CAwBEQ6jRML1y1Am30yTyG6mcAtWXw1i4klYU740uqNWS2MlU4sL5q9wqU1ChmgHvbMrVdtBmWTEp42fDUjE/BSi9fVowhhtM6rGHZC2X+IOC2JXvCKJzgIytMeSNhCRtglUhcYpSYd271RHFdTDAAWbgM3tEwdJ;25:fo9t9vK0nwXvsCa/9+o9ef8N3tcDVoW9+1z6ml9MCeursUd69/m9iunkhs0bKGM9kTK7N8uwfRFQ5J0YQd9fUkQUMJ46HEJjbP1y9G+3hCHSxL4BB50xuYQTsDX+ZNY88kMm1u5Sus3cJTmCwzJAo8iAxRrsprLxi3yRgokLdQ65cnK6gPlTuNuUad0H4/CO7RwIBwLAqeZ3PumRxQXvMkoPvcWYIT60utlJ0e0eLO0aGizxxD4gxwUIG6F0rUW3WiPjzwKHdRYElp+nBtu5Avs9FaAKXi6UhkIZKjMH7ha7pquS94dzssYMoya5Fn5bVvjUi1PdO/9Zj9KeC+IYqA==;31:I7zF+AouTaWR0AQpJcsfCsEn2ReIKWBuAjy2C95pGdHiblhR8S0dF92Li9YouKwRWCILvelt2Kj1yZei1Qb5pNZkviMVhp6M6Lpa7AOj8zsHeweigR5O2VAUtGEel2Zb5uIv3KofxZTMT+BCuej8J6kMy9T46hHTtCr6d9RuPO8fvFyIIdkx5dzZWEfycuGApRLpqomplxwyn+nsYjIdzjUYNRg+6tD+592GE6Z0g8o= X-MS-TrafficTypeDiagnostic: MWHPR07MB3503: X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3503;20:MIx+9CmTnYm+rHFsiI3hNgNLrEEmXHwDUFiMdmjALHD7pbHwU/rE9agX/R+vet4WAqL4z4NGA6AsRMJNdn2JjyO5Yw41MM6M4AQJIS92MQs8ivAUD6zuofchcDl5Mldjo4iSqU/8BHvg623cyAgKUrnwFi8npQs71Yyrn0vbjqvYu6zOkkdngGxj0jsZ3dGpQRdgVdsGjpXnxuLOuV4H+6x/SlCiQ6iuruzpsE0xBEWgSBk3pR4YZffSeDMiO9rAycBl7x+pigh3KMV+yXpxAS9XrssfWwWsynnrE8+WgrK24BLJqHW2tD3hCiC34M3GbZLam2UBDkXWKNdsvVPBoSWEHbDlF9BOL6RqtKfaW7ykDSQj9M8M4WsdAsVNAmw+yNwxA+kyJEXHvtJ4/3LL6HK5LJWCQmW5F4txh6gTTW1JSFXz49HOBBs2v3K0R+zpAGVmhmCUE4AtQDEk0/GeD/5bSwvhejN9ivWKiPgi/4tzbHfNwp8A5JZquCudpK/ZF+HCH9zdS1x6ltEbu+39QAZKFDWRcJbKg43+miURiWazTyKP80TiFP+QYFChfpVdzxZKnpEbPDFTpXqZHWrWNjNjrfN7KyZjZ8X+8iqrIV0= X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(42262312472803); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3503;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3503; X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3503;4:6WVKw9Eo2y58lWzgOwwweLylkTCsHmnedJwEDzwnwKiFuCYItYoXdmRAaRdvso2mTeN31wzF8PNTibx7CruWX9tDWiWs3BWRzWuBvPJ27x1liGoZxoO/8bRxAs8Wk+sX0CMDXaw6J5fZJFgYoTyJwaB2lj3AGYFB7/qE9uWEg82Ey9dFXzN7po5zn2C8rHPUOoQ1BeqaqCCnLuM34CiRu/t1ZrQQYXzr0yt75zTTkFcKzWlzylTi9HyOeo8Uwn5VrDSj6d0OzIBPX6S2GYauJAJSbGX5nRW2HZZBZOQ6Ea5514MP/fZUNNjKQ2CWRjf3sXpItiDFd62heWvSCHaEsg== X-Forefront-PRVS: 0471B73328 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(199003)(24454002)(189002)(23676002)(229853002)(6116002)(3846002)(31686004)(8676002)(76176999)(6486002)(68736007)(97736004)(305945005)(50466002)(6512007)(4326008)(101416001)(64126003)(36756003)(72206003)(53936002)(16526018)(5660300001)(15760500003)(53416004)(316002)(83506002)(7736002)(105586002)(50986999)(2950100002)(6246003)(5890100001)(478600001)(2906002)(54356999)(81166006)(81156014)(69596002)(31696002)(6506006)(6666003)(8936002)(106356001)(53546010)(58126008)(65806001)(110136005)(25786009)(230700001)(42882006)(66066001)(189998001)(65956001)(47776003)(65826007)(33646002)(70780200001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3503;H:ddl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjA3TUIzNTAzOzIzOmVvaWdpekgrb1BvUHpQc2twM0kzL2RncG8r?= =?utf-8?B?L1V1S0pqMjdPbzZCVXc1VHJKYWdoNUVGNVRXNGhlcVVIN3NCc3puZXlXMDR1?= =?utf-8?B?dFRrRnA4QzFJSVdWeVM2ZlM4Q1czcEwyZlRJVmFORHlqT3FlMlpkYVU1MVR1?= =?utf-8?B?cDRYcE9ydkVnQUYrME1qc3dNUXh1Tk5CdW5wbkluOWlySEVPUWswUDZiZGc3?= =?utf-8?B?U0w3a1F2WjBwSk1kd2orWXZVSzZsNzJoejJDbVFrZnRKekx4c3JyQjUzOU94?= =?utf-8?B?MlZDRjlEcjNjQlVFZGd1RXNWWUNpdnEyM2FYbkllbDh0d3h2blRMWi9jV25F?= =?utf-8?B?M2pNMmlmYVFJdHFqYlhYZEpST3RBTWRqcUhtUDREV21YY2RUNFpINGl2OC9w?= =?utf-8?B?U2h1TWM5N1pRM1ROTVFpRXJYWi9nNUI3ZTgwNGY0b1VvajBCQkdObGdYL0FZ?= =?utf-8?B?VHNnOXc3TWRyVEhQQ3kyVGJ2WUxiekx2cnNiSjRtRHpEem10Sk9KNkYvandl?= =?utf-8?B?QkdDd0xGdEZOdHhSVGpFTFpvNVhJQ2VtMFRsME51Qnc1Q3k1ZC85L2VIOXg5?= =?utf-8?B?dnMybUtsUkdHMVZiNTNvNXZsOWdrSUczc2E3WDFNaXJmVWMwWmNjRVdTckFu?= =?utf-8?B?NjFXalpjWXpZM0RZckQ1dHNZanRFMU52USttRElvMFhkZFZicXRWL1JrWEMy?= =?utf-8?B?a3VIOTl4NHNhcElNclJ1Y3Jmem45bStBVElOSDJlbzVGRUZvcTVjdS9nSXpO?= =?utf-8?B?TEtiMTdjWmZOcXRxK05RczNpRlZtckN0eDNVbEdxQ1pxWXhURHF4NDA0V2VN?= =?utf-8?B?UWpBSjhVLzF2ZVlKZ056NHBiUVl2WCsvY080VHBHT0t3ZHpBUDZ1ZEs3a0lS?= =?utf-8?B?b21wWHpvVm5mQzZHcS9OWUFYVEZySW9yRDArUWlsOWIwSzhTK1loOEtuR2ox?= =?utf-8?B?b2VDZTFUY3FJaGFMSncrMmtWQWl1b0E0dFl6bklKOGtUTExTQXl2K3RiMGRD?= =?utf-8?B?SHFxemJvVVdMME1qcWtOSzQ1REUxVXM1cVYzVTloRjJJUDBxZlZkUyt2WHJY?= =?utf-8?B?ZWN5b2o1SzRhdkVjbU1hazd1eHhKNTgyRXljd1ZodXE2anRnaUhTWUxiWWVR?= =?utf-8?B?Q2ZoWGJWQi9icGY0Ump6UjQrNzFiMGUwMm9IblpFckNVRS91YTNJOW9oUFlI?= =?utf-8?B?SzM2TnBTZmwxODRwczFmdWRBWkZFcUdJNk55ZWdnSlhNOGdESU9OakRld0th?= =?utf-8?B?YXZhbk9QdHNSNTZjV1lQbzVVZ2t1SCttWCtTK2RjRC9yaHFmS0ZrMDJrTSt2?= =?utf-8?B?QmpwcXpGMVBTNUZsazVQdHk3Q3N6UVNyUDZoYW1MT0E3V2xmMVpwMkhCc0Yz?= =?utf-8?B?L1A5dXpoT0IwWVZrNVJJN292THpOV0V0RisyZFg5ZUJSa1NoVHJIbTFWM2dL?= =?utf-8?B?ZFRlaWxoeXlOZ0E4Rkg4U3VxS1ZwTHRqeDdqSjhTRnBTbk1JQ0VrMW1QUzIz?= =?utf-8?B?bjlpUGVPejRnbVE2djN0eVB6RUZpRkNvMnBjaHRSWDBoc2lkbzI5eGVDSUxN?= =?utf-8?B?aTVxVGNMUVYvMGJya1ZnZ3NYdHpJTXNkZmtrZVBneDBEbmhmN0xtOW1zWjNa?= =?utf-8?B?TCtJN3ZaOXpDT2R2elhnMEcvY2R1aWtiWEpybWtUOThEOVBuZUVRa1VPVTlK?= =?utf-8?B?K0VpWlVYZTdnaUQ0cHkxYkdiVlRNQWhTdVBSMGJZejhKUytoQzczNEdDZENS?= =?utf-8?B?Z2JKTG8yOFd5L0pHdWN3LzNCNW1idG9oREpqMHhNSXNzMG0yOGJUdWJzTmcr?= =?utf-8?B?RG9EYTNUQW5VUzREUmRERzJoQkplZG4yZ01OZ2t6MUQ2RmwxbzNHcnk1QWpH?= =?utf-8?B?Qld6UDQxUFRxYk9aZmtqVlg1KzczQkZiS3U0cWszMm55TXhER1U4TmhvTlZ0?= =?utf-8?Q?pmHvb2w82PumyKW9PXZez43j4ZDvBc=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3503;6:5CAkKsZaHr/pFUCIR/wg/vk6gtOExGZ2Y3fHW5mj+zbzTebgzNQkIPY0DFDuw9u8l6I8lrt69TvHw0vMvZbHNH7NTrd8t2Flc60sLI+Wfy98qtStiKwdzoX+FMbA+vbo9dZNPmezazJMxn3LNEmND67KUm/PsqYgHdEceS6vQFzKmLllbZ7ll1wdoCE/D1TOK2w9n9agpI612FrTNdDMpX/1wwY3Q3of+2GPmwPeWp8yfF5jpSH2EFyfqwT2+W2adCjNDBUD54PTBJBMiX9CATO+yMbxMD60FSILmI3A8CL73z9b0qdfXIxnB9DQEBwaF5AdZkXQRWpxvYNZmTDAwQ==;5:CEja+K9WexHfRF2CeTd+XV7T0g4ZPu8ujUSpJFCJpGr8ztd08WFuhM2SDxCYbcCPOz4P7eC05pM8FGTJhzIbIQHLI1MkCiIoK1j7mWJnT/N7EaCt6wCimftrqpLbIP0WID2Vps9rcT/9/njancq8jw==;24:SbAdebxDOuYh/BLIAbz/JvChwAiaZv4gT19VO0kUPuw9D98GddQJJnTr8KctysJi0UlFWQLkeZSGnuI6D3Tw9forRyICh+WgKs0YmRqZDgo=;7:Jf+oaKh6vTCMvZ3knsPWjlMFRrw863Or1iM79EgeN/DBmn8oQoPRAfZwWFtun+vIhywMfPZIlMK7Y6MaqrbsZywTdQ7LILfBhtM22S8x2sX6fwUGHBLE7lX6eGPww6k7BtbH2zjJbIurEuE0+OBCo02IFjz2JFYWKDwiE3P/Sr3ML3GMbVCpq3kGmybF00hgwqCbcmuTv67ZzXYWBOdocEn24RSyfee4KnGNVCKu62M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2017 15:52:51.7227 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9779075d-90f4-4ba5-81dd-08d51bc07388 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3503 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/2017 02:52 AM, SF Markus Elfring wrote: > From: Markus Elfring NAK. We don't need any more Markus Elfring spam. > Date: Wed, 25 Oct 2017 11:45:48 +0200 > > Add a jump target so that a specific error message is stored only once > at the end of this function implementation. Please read C standard about duplicate literal strings to see why this is a completely misleading and false statement. > Replace two calls of the function "dev_err" by goto statements. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/i2c/busses/i2c-octeon-platdrv.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-octeon-platdrv.c b/drivers/i2c/busses/i2c-octeon-platdrv.c > index 64bda83e65ac..ac8a1099c523 100644 > --- a/drivers/i2c/busses/i2c-octeon-platdrv.c > +++ b/drivers/i2c/busses/i2c-octeon-platdrv.c > @@ -207,10 +207,8 @@ static int octeon_i2c_probe(struct platform_device *pdev) > result = devm_request_irq(&pdev->dev, i2c->hlc_irq, > octeon_i2c_hlc_isr78, 0, > DRV_NAME, i2c); > - if (result < 0) { > - dev_err(i2c->dev, "failed to attach interrupt\n"); > - goto out; > - } > + if (result < 0) > + goto report_failure; > } else { > i2c->int_enable = octeon_i2c_int_enable; > i2c->int_disable = octeon_i2c_int_disable; > @@ -220,10 +218,8 @@ static int octeon_i2c_probe(struct platform_device *pdev) > > result = devm_request_irq(&pdev->dev, i2c->irq, > octeon_i2c_isr, 0, DRV_NAME, i2c); > - if (result < 0) { > - dev_err(i2c->dev, "failed to attach interrupt\n"); > - goto out; > - } > + if (result < 0) > + goto report_failure; > > if (OCTEON_IS_MODEL(OCTEON_CN38XX)) > i2c->broken_irq_check = true; > @@ -251,6 +247,8 @@ static int octeon_i2c_probe(struct platform_device *pdev) > dev_info(i2c->dev, "probed\n"); > return 0; > > +report_failure: > + dev_err(i2c->dev, "failed to attach interrupt\n"); > out: > return result; > }; >