From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 126B1C433E6 for ; Mon, 31 Aug 2020 02:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E46F22076D for ; Mon, 31 Aug 2020 02:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbgHaCtB (ORCPT ); Sun, 30 Aug 2020 22:49:01 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10736 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726692AbgHaCtA (ORCPT ); Sun, 30 Aug 2020 22:49:00 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 3C392904D3B68F91D429; Mon, 31 Aug 2020 10:48:59 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 31 Aug 2020 10:48:53 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: change compr_blocks of superblock info to 64bit To: Daeho Jeong , , , CC: Daeho Jeong References: <20200831020949.3218854-1-daeho43@gmail.com> From: Chao Yu Message-ID: <77e4d1c5-daad-5337-f71d-6975df89d796@huawei.com> Date: Mon, 31 Aug 2020 10:48:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200831020949.3218854-1-daeho43@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/8/31 10:09, Daeho Jeong wrote: > From: Daeho Jeong > > Current compr_blocks of superblock info is not 64bit value. We are > accumulating each i_compr_blocks count of inodes to this value and > those are 64bit values. So, need to change this to 64bit value. It's not a big deal, as f2fs use 32bits to index block device's address space, so there is at most 1 << 32 blocks in f2fs, we can not save more blocks than the number... If it overflows 32bits variable's space, it must be a bug. > > Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks,