From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E653828FA91 for ; Wed, 4 Jun 2025 13:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749043472; cv=none; b=eybDRY0wyJqRPQCD0Dqws0All9d+B6ZlmQF5piYqv2Q3pWvjGYi8mEWVONuZ2tSEtUrW8Wjt1f2ODU2UxHGkOujIwWPxyn6Fzbie+LmY1GdUrhMHho+tQAtnF6EWm9yWyq8JoLQZAZjPLnA+ywAzD/uOuAdpuOJjFKLW+EPznmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749043472; c=relaxed/simple; bh=iKG8NBG/TNLTXbVo9TYujPcytItCDWMbZmRywdSOHNs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fVLY92hUj5c03ucVJapLYQ3y40LvFpQVgKvvoCaycrXP4YEc0wRZc0nNv1lI5y6DHMCzorCAgWPAhVcEAbimL8wD/8Vu4tmT3SGZkY9OWfWLNy1pD46LKOJlAOIcXZ5m42n41bpzMt/gcbu3u7cHXJdj4nnlz4ajPHLHTO7c9TA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E46Kh+a0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E46Kh+a0" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5548envk007519 for ; Wed, 4 Jun 2025 13:24:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5tDhYT9ynoVsxUKkv2VPgtETqP2fOpfi938Os934qGQ=; b=E46Kh+a0iBI+mq5x F9GIx+ku+J5hK5LZhXVE/j0vWkDSaFM8G0VUdsbo57L3+o8ZLmWK3mQY71qm3IZM GjAgC+XizzFsQdqrlCcvvM+VoAlGE3cIPdLk0yi2wlX5mMORGQ9CjOpozZ62LOPU I6mIRpIemXqyH9JSpYn7xsg6MESeitvAlP5guTwq/NkEYDOnyObT9H0cY7cUX84V 4ko1gkks84Eu+SFnINepU4kEC1pdxzc3VINaXVixIMcE8ZJdPAC6tQmavMy7iG0R yu0/8Q/95mcoYDMN10GiNmz020Vx5SZeFdH99NhC2M+XFdwNEWfNPVGfAM6A6TUG vPgc3w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 471g8sx4jk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 04 Jun 2025 13:24:30 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c76062c513so165491485a.3 for ; Wed, 04 Jun 2025 06:24:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749043469; x=1749648269; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5tDhYT9ynoVsxUKkv2VPgtETqP2fOpfi938Os934qGQ=; b=vo8ztrxgsn9zRoINjywK1PGKgvxA/j7EvvlYcVvRF+vQj7VMhN8NTyFRfrkLLEnx5g enwg/mTe0F3LjI3zTyiwQq1JBP/SiGv9yeJveIv3pukbOrf7mDS8HmO3/rhQLvjVg3e2 x/9RwjPfWhj21ZV6j9M1XKocBxzhTMhBgEDz5VcD1/3xBHj8dWDDVprWUtodix2abM4P s4/Ck7lS+Evj8rE05mdWzjb5V0vMv7UYBg/aDqJGeHsyjLEL8ngNuQSGxXQ7Hk6GxQqZ 5bpeCc1UZYa0Egs8XxIhtULoJ88V52m7KBDdbZo3PJXEzXq4p3IgSJMZ8ghqFwJabv79 g0lA== X-Forwarded-Encrypted: i=1; AJvYcCU8+iYcffntU2Zb+sSAAj96Yesi6eN0yXeONI56eMFsVjai8rzzFXMIU9P/QCrjVcgxwDfJSt6S6bO/XxI=@vger.kernel.org X-Gm-Message-State: AOJu0YwrukwGxXLGJtFwFYKilP1YkoXISOjXcj4QLLln9iPa80zVxhQI ewqeV5q1pipAxfr+m0bIJpeu7xkwKJaSl8O+JushrBxPgdWcCBP8Mrm0ZM4ikCKMoywFmDLw5PO eIHzFmKdfibitw+TTGXNVyuJPELmWXvmCxrW13VNnnYDMHaGlqAnaEKQMYEO4GAQ7/LdkB9tOTm 8= X-Gm-Gg: ASbGncu5qjuS9oACqWmGjXKBp7hsXbiRmZpjDmE4V74TudRAuO/ZmeEfgaDqg5jLEll TZu1u/6Kzfu22+k2KfqX3K/mFbNHW+zIyQcvurto7ckzjgvshi3TeKAlrob8TwFwPsCZ556F2GH bgGaGyhGsne2a79zistpW5/vtywCrksqDxwdlWqSft5pyOTqs85uoMOqLrnpB7YxBbF3goPEaHd FG2b1Hm8UQaANxelN6yUwDUDWvd8EU2XeIx0GxknLnAmWtfRPqZIa/iKBz2C3sOLI+yxpUTUMf7 oMdtUevEAqGQh7Z1I6+/rZyaThA9vSzUqGmf6TWMjxwaQZmnEQiWhol7WFCHZ5UFgw== X-Received: by 2002:a05:620a:284f:b0:7c0:c024:d5 with SMTP id af79cd13be357-7d2198a4bcamr182103285a.8.1749043468658; Wed, 04 Jun 2025 06:24:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHp4FAWQb08lT7tzFsZcGvaXN1AR/3mpBEQNehhZ0tFk6Uq8YusaA5kooOfzLi9N2bN1wu3MA== X-Received: by 2002:a05:620a:284f:b0:7c0:c024:d5 with SMTP id af79cd13be357-7d2198a4bcamr182101485a.8.1749043468299; Wed, 04 Jun 2025 06:24:28 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adb390f09c8sm845637866b.45.2025.06.04.06.24.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 06:24:27 -0700 (PDT) Message-ID: <77ea49c3-f042-4ba9-a0da-1d0e4e4088d3@oss.qualcomm.com> Date: Wed, 4 Jun 2025 15:24:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/3] arm64: dts: qcom: qcs615: add venus node to devicetree To: Renjiang Han , Dmitry Baryshkov Cc: Konrad Dybcio , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250527-add-venus-for-qcs615-v7-0-cca26e2768e3@quicinc.com> <20250527-add-venus-for-qcs615-v7-2-cca26e2768e3@quicinc.com> <429b4c99-b312-4015-8678-0371eac86de4@oss.qualcomm.com> <6a9e7daf-c0df-42db-b02d-96d9893afcde@quicinc.com> <43e1f8db-5ab1-44ce-97c8-50910704788f@quicinc.com> <9faff664-9717-4259-8b23-bc44e64f6947@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <9faff664-9717-4259-8b23-bc44e64f6947@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=RMizH5i+ c=1 sm=1 tr=0 ts=6840490e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=COk6AnOGAAAA:8 a=ONiuQb8ssYXyuzXnhScA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA0MDEwMiBTYWx0ZWRfXxeTAXRY72OrS QRk5mQ3xiIG58HsNUPYi3Ej7DvQ1/n98yoOcvbQMC2E2B667OT2dLfMM6zYGW/zW+3tyUTJXri5 DaSbij6xWxIiGPI+W9UGZxvW65BPTvt4HC6H5wKpKWHICDEYxzyHHvx7Bm4Wj8MGE4QRYg/xLXr C9x/+L6iXrSLbezX0ksLaGLTiqyTH5YZlfKWF4W+G4WIGzyPDkp59nVIjBMKPOu1Fbnp2IgjUvt kNVm9DzEsMg4Ut2MkzfNITOtRYahvpSXb/U2gCUo/Rub9ymxHSaZIzOQ4s4XiYeNP/+unjMORA+ 7dGQm5jhNCUuHUwqgJd5aNE9P2lds2h/ANdrs0dS1lIhJEYTRWCh+EdYotQc5Oq6Z85evS0ZKyE bvJsZVykgjmMVSka+DrdHcw5ZuAjPdEnZ8yYvebotZHgEcS9v5yhGjOM93+kWEN5UGuXFHfN X-Proofpoint-GUID: x-b_dxFKrYCuDwG9UO1X4YFW035L4GJS X-Proofpoint-ORIG-GUID: x-b_dxFKrYCuDwG9UO1X4YFW035L4GJS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-04_03,2025-06-03_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 clxscore=1015 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506040102 On 6/4/25 2:05 PM, Renjiang Han wrote: > > On 6/3/2025 9:21 PM, Dmitry Baryshkov wrote: >> On Thu, May 29, 2025 at 10:29:46AM +0800, Renjiang Han wrote: >>> On 5/28/2025 7:04 PM, Dmitry Baryshkov wrote: >>>> On Wed, May 28, 2025 at 05:13:06PM +0800, Renjiang Han wrote: >>>>> On 5/27/2025 9:57 PM, Konrad Dybcio wrote: >>>>>> On 5/27/25 5:32 AM, Renjiang Han wrote: >>>>>>> Add the venus node to the devicetree for the qcs615 platform to enable >>>>>>> video functionality. The qcs615 platform currently lacks video >>>>>>> functionality due to the absence of the venus node. Fallback to sc7180 due >>>>>>> to the same video core. >>>>>>> >>>>>>> Signed-off-by: Renjiang Han >>>>>>> --- >>>>>> [...] >>>>>> >>>>>>> +            interconnect-names = "video-mem", >>>>>>> +                         "cpu-cfg"; >>>>>>> + >>>>>>> +            iommus = <&apps_smmu 0xe40 0x20>; >>>>>> fwiw docs mention 0xe60 0x20 (which result in the exact same resulting sid) >>>>> OK. Will update it with next version. >>>> How would you update this? >>> Thanks for your comments. I'll update it like this. >>> iommus = <&apps_smmu 0xe60 0x20>; >>> >>> This 0xe40 SID was based on a previous project. However, after rechecking >>> the documentation yesterday and confirming with colleagues, the correct >>> SID value should be 0xe60. I’ve also validated it on local device, it >>> works as expected. The reason 0xe40 seemed to work earlier is due to the >>> mask value being 0x20, which causes the effective SID derived from 0xe40 >>> to be the same as 0xe60. >> Using 0xe60 would be counterintuitive, as we have a non-zero masked bits >> in the base value. It should be either <0xe60 0x0> or <0xe40 0x20>. > > Hi Dmitry > > Thank you for your comment. > > I’ve followed up on this sid with a colleague from the kernel team, > and based on our discussion, it seems that the sid in this case should > be the result sid. The actual sid is 0xe60, and with a mask of 0x20, > the resulting sid would be 0xe40. Therefore, it should be <0xe40 0x20>. > > @Konrad, I’d appreciate any thoughts or suggestions you might have on it. What our docs describe as 'result sid' is literally 'base ~& mask', so if we used that, setting the mask would be useless.. Now, some old NHLOS builds are known to cause issues if the values aren't exactly what they expect (some whitelisting must be going on there). I don't think this should be an issue on this platform, but let's just use 0xe60 0x20 here to reflect the real values Konrad