From: Rik van Riel <riel@surriel.com>
To: Giuseppe Scrivano <gscrivan@redhat.com>
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
kernel-team@meta.com, linux-fsdevel@vger.kernel.org,
Chris Mason <clm@meta.com>
Subject: Re: [PATCH 2/2] ipc,namespace: batch free ipc_namespace structures
Date: Fri, 27 Jan 2023 13:16:46 -0500 [thread overview]
Message-ID: <77ee6f62f1a10ea4a5e054059ab98a252246a891.camel@surriel.com> (raw)
In-Reply-To: <878rhome8h.fsf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Fri, 2023-01-27 at 12:03 +0100, Giuseppe Scrivano wrote:
> Rik van Riel <riel@surriel.com> writes:
>
> >
> > +++ b/ipc/namespace.c
> > @@ -145,10 +145,11 @@ void free_ipcs(struct ipc_namespace *ns,
> > struct ipc_ids *ids,
> >
> > static void free_ipc_ns(struct ipc_namespace *ns)
> > {
> > - /* mq_put_mnt() waits for a grace period as kern_unmount()
> > - * uses synchronize_rcu().
> > + /*
> > + * Caller needs to wait for an RCU grace period to have
> > passed
> > + * after making the mount point inaccessible to new
> > accesses.
> > */
> > - mq_put_mnt(ns);
>
> mq_put_mnt() is not needed anymore, should it be removed?
Yes, indeed. Thank you!
I'll send a v3 of the series :)
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-27 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 1:15 [PATCH v2 0/2] ipc,namespace: fix free vs allocation race Rik van Riel
2023-01-27 1:15 ` [PATCH 1/2] ipc,namespace: make ipc namespace allocation wait for pending free Rik van Riel
2023-01-27 1:15 ` [PATCH 2/2] ipc,namespace: batch free ipc_namespace structures Rik van Riel
2023-01-27 1:31 ` [PATCH v2 " Rik van Riel
2023-01-27 11:03 ` [PATCH " Giuseppe Scrivano
2023-01-27 18:16 ` Rik van Riel [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-27 18:46 [PATCH v3 0/2] ipc,namespace: fix free vs allocation race Rik van Riel
2023-01-27 18:46 ` [PATCH 2/2] ipc,namespace: batch free ipc_namespace structures Rik van Riel
2023-01-26 20:57 [PATCH 0/2] ipc,namespace: fix free vs allocation race Rik van Riel
2023-01-26 20:57 ` [PATCH 2/2] ipc,namespace: batch free ipc_namespace structures Rik van Riel
2023-01-26 21:14 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77ee6f62f1a10ea4a5e054059ab98a252246a891.camel@surriel.com \
--to=riel@surriel.com \
--cc=clm@meta.com \
--cc=gscrivan@redhat.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®