From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42FAD1DE3B8 for ; Thu, 16 Jan 2025 11:41:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737027708; cv=none; b=h+gru+PX98ncbPRX2nkl47Hw/j3FQMoNO4LcUlVY8fgMx6SBBmZ3RTKacSME4Qo4z1+V22nzeWNFMmu3cvy0jhQibAdWmJnp/2FcVXv56xvYyOYAYGNlN8I3ioMxlS9u8ublVLrssR8NsdeYJKHQugY2tf7axnpbHeUOC/RYWmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737027708; c=relaxed/simple; bh=grVoZNVjcvy9MCcSf9CkrEgnrvso4XYxU656pIV7e5E=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=i0Dse5o9gfeNcrGPlfhZvYp6+WgEkWB9caoZwZn7kAizuITsLwSLdeJA+9J3DawcJ2R2UzskddCkbsJsS51nxdto+IWGYZIRDXhq+lU9FbZhblkvpBxUCGi0AcU1PnHTqGa09f6dGRAhkRrvvrrnfECLvzhZNB8OPFyf2poX9QM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Az1JkgPU; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Az1JkgPU" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3863494591bso437320f8f.1 for ; Thu, 16 Jan 2025 03:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737027704; x=1737632504; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=bKtUMEoqDHLTfhHmG3inCWsYClLTJL5ZLVp5zayXN6U=; b=Az1JkgPURBxpMk2FaVwXIK6P2JWoRJf6sXZ39rB3DozZBZxgpBIjvEkVVwB2Kqz0IU I0a1ed9CWyXwdezV9U+7Z/HObjfGYQt8jyWLJ9xyhtRQSAK8vNnXEGzs6ybl0hwE8yM1 +F+W51Lw9/Lwko9m6YcADY11v04rUMQ0+GCHiHqsKrQ+myzIWJOhoIPRQw1qeZLA81I2 ftcE2CwXtArX9KaEYb1SXkEmrrXg23/fAWHdGs1zuswXAj7fcKRc8CMgswL5S5q28CAK DBgLs7kBMfxwWsft8Okbuhf9anLvYhzlWqF4ENMjhcVUCrF1p6faEcxVhUJgnggymq1U 1iDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737027704; x=1737632504; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bKtUMEoqDHLTfhHmG3inCWsYClLTJL5ZLVp5zayXN6U=; b=ieKDFK9DRbi7gMpqTLyROOf+uGQy8/58EggyNHoe50mJz+OeUyLJraVZf29I3F5LNj +NwIihnUWXJib6EKui8Xztf255SMTGkJGZPPq15OaZH2kVUIIWjQx0vi0h3LcU0xGhTI xGMPwQGLsLwwSGgIowOf1qnwaG++w+4/uiRNsxP+XWEl+aZ+R8MZcvQpNPFzYUCoHxU/ cUe1Fe0wWmnltCyFYsHDMlaUDsOZbIaOFsTy+BGPdDFVShuhLMyHthPr5LHNLe1q3Lfi LidJXVX5FgUGWBfj9/LaQWlEoF8LoplJEngrLVCAx6DReaAddJeuFR9qclp7Lau6MeUn oeIA== X-Gm-Message-State: AOJu0Yzm7LbqWb1/aViJ35N/dISuSqhUsHvoPH+UT61lWcEEZ+5kNHr/ NOzh9eHPsVSa7cH+q0x2CTPd9AzvoTjZ3xwHsrFnkRuJsr93gCxcBeF8waumwX8= X-Gm-Gg: ASbGncufmCNWZS3J+8EvnPDCU/oxiY6XMHaJGjxvSWuAm71L/saUm+6Z/D+Ji8HC8X5 qkmZpBpwjE4BEurkhJfh96eoTVACjXuRFdEHOFyecUo7WzcNPO0BR6tKTYfb8cAa0/zoKo5Ofzf 37VSNJAL42QGdOCdUhhlYXI28gmt4+8r0TgSNTSRD+q+XsNUHHqf6jFDd7VNH2QoBFJXXNWsl1A wrLVBS/WrmuJsAzEITS5rWkTSCRcJCeNHzEBXvvm2kFrGvRcMOEUGp/nhZhfAiQXQ== X-Google-Smtp-Source: AGHT+IFueE/gZTYtweq/GR16SLOOq+RSDS7PYuc5QwoykXqiYGNy+orWNKBAzKyMcjXwFzsBcfLt3A== X-Received: by 2002:a05:6000:401f:b0:386:3328:6106 with SMTP id ffacd0b85a97d-38a872f6193mr33619540f8f.35.1737027704561; Thu, 16 Jan 2025 03:41:44 -0800 (PST) Received: from [192.168.0.14] ([188.26.60.120]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74aca93sm57515965e9.13.2025.01.16.03.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2025 03:41:44 -0800 (PST) Message-ID: <77eeed18-4a48-4407-ae83-7a922045b29a@linaro.org> Date: Thu, 16 Jan 2025 11:41:42 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] firmware: add Exynos ACPM protocol driver From: Tudor Ambarus To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Jassi Brar Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, peter.griffin@linaro.org, daniel.lezcano@linaro.org, vincent.guittot@linaro.org, ulf.hansson@linaro.org, arnd@arndb.de References: <20241220-gs101-acpm-v5-0-4f26b7fb3f5f@linaro.org> <20241220-gs101-acpm-v5-2-4f26b7fb3f5f@linaro.org> <8e6bade0-5184-4bf7-b1f0-103a77d0f98b@kernel.org> <060c7a96-c1ed-4c97-8a3f-f510102466f9@linaro.org> Content-Language: en-US In-Reply-To: <060c7a96-c1ed-4c97-8a3f-f510102466f9@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/31/24 2:32 PM, Tudor Ambarus wrote: >>> +config EXYNOS_ACPM_PROTOCOL >>> + tristate "Exynos Alive Clock and Power Manager (ACPM) Message Protocol" >>> + depends on ARCH_EXYNOS || COMPILE_TEST >>> + depends on EXYNOS_MBOX >> Is it build time dependency? No || COMPILE_TEST? > There's no build time dependency, I'll drop this line. There's no build time dependency on EXYNOS_MBOX, but there is on MAILBOX: ERROR: modpost: "mbox_request_channel" [drivers/firmware/samsung/acpm-protocol.ko] undefined! ERROR: modpost: "mbox_free_channel" [drivers/firmware/samsung/acpm-protocol.ko] undefined! ERROR: modpost: "mbox_send_message" [drivers/firmware/samsung/acpm-protocol.ko] undefined! ERROR: modpost: "mbox_client_txdone" [drivers/firmware/samsung/acpm-protocol.ko] undefined! Will replace the line with "depends on MAILBOX". Thanks! ta