From: Jon Hunter <jonathanh@nvidia.com>
To: <robert.foss@collabora.com>, <freddy@asix.com.tw>,
<Dean_Jenkins@mentor.com>, <Mark_Craske@mentor.com>,
<davem@davemloft.net>, <ivecera@redhat.com>,
<john.stultz@linaro.org>, <vpalatin@chromium.org>,
<stephen@networkplumber.org>, <grundler@chromium.org>,
<changchias@gmail.com>, <allan@asix.com.tw>, <andrew@lunn.ch>,
<tremyfr@gmail.com>, <colin.king@canonical.com>,
<linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <vpalatin@google.com>
Subject: Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures
Date: Thu, 10 Nov 2016 12:01:03 +0000 [thread overview]
Message-ID: <77fa76d6-ef63-47db-a316-93b3a0c0705b@nvidia.com> (raw)
In-Reply-To: <c708db3f1e006df543284cf5215b965ce4fc44ec.1472155176.git-series.robert.foss@collabora.com>
Hi Robert,
On 29/08/16 14:32, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> From: Allan Chou <allan@asix.com.tw>
>
> The change fixes AX88772x resume failure by
> - Restore incorrect AX88772A PHY registers when resetting
> - Need to stop MAC operation when suspending
> - Need to restart MII when restoring PHY
>
> Signed-off-by: Allan Chou <allan@asix.com.tw>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> Tested-by: Robert Foss <robert.foss@collabora.com>
After this commit, I have started seeing the following messages
during system suspend on various tegra boards using asix ethernet
dongles ...
[ 288.667010] PM: Syncing filesystems ... done.
[ 288.672223] Freezing user space processes ... (elapsed 0.001 seconds) done.
[ 288.680505] Double checking all user space processes after OOM killer disable... (elapsed 0.000 seconds)
[ 288.690193] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
[ 288.698987] Suspending console(s) (use no_console_suspend to debug)
[ 288.706605] asix 1-1:1.0 eth0: Failed to read reg index 0x0000: -19
[ 288.706613] asix 1-1:1.0 eth0: Error reading Medium Status register: ffffffed
[ 288.706621] asix 1-1:1.0 eth0: Failed to write reg index 0x0000: -19
[ 288.706629] asix 1-1:1.0 eth0: Failed to write Medium Mode mode to 0xfeed: ffffffed
[ 288.759167] PM: suspend of devices complete after 52.772 msecs
Interestingly, it only seems to happen if the ethernet is in a
disconnected state when entering suspend. I have not had chance
to look at this any further, but wanted to see if you had any
thoughts.
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2016-11-10 12:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 20:06 [PATCH v3 0/5] net/usb: asix driver improvements robert.foss
2016-08-25 20:06 ` [PATCH v3 1/5] net: asix: Add in_pm parameter robert.foss
2016-08-25 20:06 ` [PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected robert.foss
2016-08-25 20:06 ` [PATCH v3 3/5] net: asix: Fix AX88772x resume failures robert.foss
2016-11-10 12:01 ` Jon Hunter [this message]
2016-11-14 8:50 ` ASIX_Allan [Home]
2016-11-14 9:34 ` Jon Hunter
2016-11-14 9:45 ` ASIX_Allan [Office]
2016-11-18 15:09 ` Jon Hunter
2016-11-22 15:34 ` Jon Hunter
2016-11-29 8:54 ` ASIX_Allan [Office]
2016-11-29 10:51 ` Jon Hunter
2016-08-25 20:06 ` [PATCH v3 4/5] net: asix: see 802.3 spec for phy reset robert.foss
2016-08-25 20:06 ` [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg robert.foss
2016-09-01 16:43 ` Eric Dumazet
2016-09-01 16:47 ` Robert Foss
2016-09-01 17:02 ` Eric Dumazet
2016-09-06 16:41 ` Grant Grundler
2016-09-06 21:48 ` Robert Foss
2016-08-25 20:06 ` [PATCH v3 1/5] net: asix: Add in_pm parameter robert.foss
2016-08-25 20:06 ` [PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected robert.foss
2016-08-25 20:06 ` [PATCH v3 3/5] net: asix: Fix AX88772x resume failures robert.foss
2016-08-25 20:06 ` [PATCH v3 4/5] net: asix: see 802.3 spec for phy reset robert.foss
2016-08-25 20:06 ` [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg robert.foss
2016-08-27 4:24 ` [PATCH v3 0/5] net/usb: asix driver improvements David Miller
2016-08-29 13:32 ` [PATCH v3 1/5] net: asix: Add in_pm parameter robert.foss
2016-08-29 13:32 ` [PATCH v3 2/5] net: asix: Avoid looping when the device is disconnected robert.foss
2016-08-29 13:32 ` [PATCH v3 3/5] net: asix: Fix AX88772x resume failures robert.foss
2016-08-29 13:32 ` [PATCH v3 4/5] net: asix: see 802.3 spec for phy reset robert.foss
2016-08-29 13:32 ` [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg robert.foss
2016-08-31 17:28 ` [PATCH v3 0/5] net/usb: asix driver improvements Robert Foss
2016-09-01 4:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77fa76d6-ef63-47db-a316-93b3a0c0705b@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=Dean_Jenkins@mentor.com \
--cc=Mark_Craske@mentor.com \
--cc=allan@asix.com.tw \
--cc=andrew@lunn.ch \
--cc=changchias@gmail.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=freddy@asix.com.tw \
--cc=grundler@chromium.org \
--cc=ivecera@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.foss@collabora.com \
--cc=stephen@networkplumber.org \
--cc=tremyfr@gmail.com \
--cc=vpalatin@chromium.org \
--cc=vpalatin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®