From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966431AbdEOTSr (ORCPT ); Mon, 15 May 2017 15:18:47 -0400 Received: from mout.web.de ([212.227.15.14]:49440 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934559AbdEOTSp (ORCPT ); Mon, 15 May 2017 15:18:45 -0400 Subject: [PATCH 4/6] PNP: Delete an error message for a failed memory allocation in pnp_clone_dependent_set() From: SF Markus Elfring To: "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org Cc: LKML , Wolfram Sang References: <94f6ec12-0092-e1e6-3fb1-81f9630eae1f@users.sourceforge.net> Message-ID: <77feb0e9-ef3b-15bb-bc0b-666c9632c9e0@users.sourceforge.net> Date: Mon, 15 May 2017 21:18:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <94f6ec12-0092-e1e6-3fb1-81f9630eae1f@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:qywdHT07ML7K/OJPZOoHMDhYobkcyEC5z5687vGbIIFVvSkZjDp C6iq4STWPx7IHvDWyZdu2Ezs+QPZGwjqXNtDKW5dwnlYNWy5jStiQvsKXY8IdzsZeuaO+Bc kCQVDcBimA4/UQC9EfribYAfqYZ8qHvnkhgiWwgaWcwO1zW7UYiCtNNa0yRHH/3EK08N5Zn uUMSjktQ+fhwyvP9p2G9g== X-UI-Out-Filterresults: notjunk:1;V01:K0:SX0ZuCvoXkM=:djD1O66nohb4v1o13APiMl AmM4XyM6xqRw3KH8Tuc79XWc18bfeCfXiseQTMT28wWu80rlDg3dZxP5oqbIDzUexc3cMHsDK XRS14mIEE0yP4BnQubObirqq2jdPf7M7BrI+2FDZ18/f7aNZHY1hcz1bs57GuvRjtnkYDUNpk jbiodJn+QIFrjhkvE1JbazWAskcgUNydmJiqwimumYEjy9YcXoygmJWEQO3+by5nmjrM0I3MS YRsBPM2QvJCTvdO47W6UrBjv6jzXFM7OpFe5ecYklaRRQT+srv5GEQ9WQb9F5CjID0qxaLQiO 4ogThAeNGGBF3doajzJ93ucRRRVYOLCZOvgF4zYmnQoBO685Zl20NtAu2YzbwZD2NTrSenevx Omgj+Bx7PwT6qZxBIjujspeeRcG0U40MyHTFq0pc8VmzeGvQnIBZrGPoScoLvFtkmmIiC7IqZ rHdMtjOFeYsECHutxrdP7fbgdzAfrcJdphdCMkRXBOPGCJ+ipD8P+zDeZs66LNIJjguRoj33F A/4T7gODsgTdxl7ov7uAzx3jh0OlTKhXCDHveUfcjH11tuoCnQNuXqBDIbVyFMydafr5n9XfX w+7C1tAqYp8GC1vb1gas/hliZM9lBymTRKYoe4lSTMo14WC8/EuPr/j+UvqPDhMR8rxOFKoga 7jgbL/+3kkkhFrl9DJkK5r2gf36gQOdObHCgrtxVdo865UEYlUFIiO7S2TSUGiJIU6fKD+s6z HrduV+Pdq0Z5e7NbxjQX8dTKkTqIRtpxqqdZSsYgJ45XWeZmm77dB2VlHsgeUoSp6FnBGdIME JSQxJUq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 15 May 2017 20:00:38 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/pnp/quirks.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c index 215a50723243..34e2d4563bbd 100644 --- a/drivers/pnp/quirks.c +++ b/drivers/pnp/quirks.c @@ -159,8 +159,5 @@ static struct pnp_option *pnp_clone_dependent_set(struct pnp_dev *dev, - if (!new_option) { - dev_err(&dev->dev, "couldn't clone dependent " - "set %d\n", set); + if (!new_option) return NULL; - } *new_option = *option; new_option->flags = flags; -- 2.13.0