mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Icenowy Zheng <uwu@icenowy.me>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	 Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
	Fu Wei <wefu@redhat.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	Dmitry Baryshkov <lumag@kernel.org>,
	 Michal Wilczynski <m.wilczynski@samsung.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Han Gao <rabenda.cn@gmail.com>,  Yao Zi <ziyao@disroot.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	Han Gao <gaohan@iscas.ac.cn>
Subject: Re: [PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon display controllers
Date: Thu, 22 Jan 2026 17:28:48 +0800	[thread overview]
Message-ID: <7802bbc5edf2cfd6bf0d3f189aa7e6f6fc62e6ae.camel@icenowy.me> (raw)
In-Reply-To: <56e1974c-0fe6-4bdb-918d-fcf6a8b866c1@suse.de>

在 2026-01-21星期三的 13:56 +0100，Thomas Zimmermann写道：

============== 8< =======================
> > +static int vs_gem_dumb_create(struct drm_file *file_priv,
> > +                             struct drm_device *drm,
> > +                             struct drm_mode_create_dumb *args)
> > +{
> > +       /* The hardware wants 128B-aligned pitches for linear
> > buffers. */
> > +       args->pitch = ALIGN(DIV_ROUND_UP(args->width * args->bpp,
> > 8), 128);
> 
> Please use the new drm_mode_align_dumb() instead.

It seems to be still a static function, at least in 6.19-rc1 .

It looks like I should put a call to drm_mode_size_dumb() here, is this
correct?

Thanks,
Icenowy

> 
> > +
> > +       return drm_gem_dma_dumb_create_internal(file_priv, drm,
> > args);
> > +}
> > +

  parent reply	other threads:[~2026-01-22  9:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16  4:37 [PATCH v5 0/9] Verisilicon DC8200 driver (and adaption to TH1520) Icenowy Zheng
2026-01-16  4:37 ` [PATCH v5 1/9] dt-bindings: vendor-prefixes: add verisilicon Icenowy Zheng
2026-01-16  4:37 ` [PATCH v5 2/9] dt-bindings: display: add verisilicon,dc Icenowy Zheng
2026-01-21  2:21   ` Rob Herring (Arm)
2026-01-16  4:37 ` [PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon display controllers Icenowy Zheng
2026-01-21 12:56   ` Thomas Zimmermann
2026-01-22  7:06     ` Icenowy Zheng
2026-01-22  7:31       ` Thomas Zimmermann
2026-01-22  7:32         ` Thomas Zimmermann
2026-01-22  7:37         ` Icenowy Zheng
2026-01-22  7:43           ` Thomas Zimmermann
2026-01-22  9:23     ` Icenowy Zheng
2026-01-22 10:39       ` Thomas Zimmermann
2026-01-22 11:30         ` Icenowy Zheng
2026-01-22  9:28     ` Icenowy Zheng [this message]
2026-01-28  7:42       ` Thomas Zimmermann
2026-01-22  9:47     ` Icenowy Zheng
2026-01-22  9:52       ` Icenowy Zheng
2026-01-28  7:50       ` Thomas Zimmermann
2026-01-16  4:37 ` [PATCH v5 4/9] dt-bindings: display/bridge: add binding for TH1520 HDMI controller Icenowy Zheng
2026-01-16  4:37 ` [PATCH v5 5/9] drm/bridge: add a driver for T-Head " Icenowy Zheng
2026-01-16  4:37 ` [PATCH v5 6/9] riscv: dts: thead: add DPU and HDMI device tree nodes Icenowy Zheng
2026-01-16  4:37 ` [PATCH v5 7/9] riscv: dts: thead: lichee-pi-4a: enable HDMI Icenowy Zheng
2026-01-16  4:37 ` [PATCH v5 8/9] MAINTAINERS: assign myself as maintainer for verisilicon DC driver Icenowy Zheng
2026-01-16  4:37 ` [PATCH v5 9/9] mailmap: map all Icenowy Zheng's mail addresses Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7802bbc5edf2cfd6bf0d3f189aa7e6f6fc62e6ae.camel@icenowy.me \
    --to=uwu@icenowy.me \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fustini@kernel.org \
    --cc=gaohan@iscas.ac.cn \
    --cc=guoren@kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=lumag@kernel.org \
    --cc=m.wilczynski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rabenda.cn@gmail.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=wefu@redhat.com \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®