From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE3F01CAA63 for ; Mon, 13 Jan 2025 12:13:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736770394; cv=none; b=Wp9T+y6FJQ+z+KBxooIosQ9yz/OMnkPHXig2clIzjmPP5PHu3mihhk9K4gyExB2hQ/1q1f6Ft/U1PzUdDucDYWzC6RR3Vc33ctUecnAO46FZeAUz4MKSLd1jM9J9zZaJLQw7xTYuFlvqwhs98KkYnc43qBpkr8I1p3mkDf1gLRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736770394; c=relaxed/simple; bh=7mSkffdXqq8EFA8EUzl/xt+T6ken0cn5qrMnTzg2iwk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IGOtJCAckJ9CeESBLl9FLKUIMkKS9LJYaiZIgZapifX6Ne68Fsj38KMmch2+O71tUSexfOKwYxMTa+yHB2Ldc+J9uKAzI+c4EM1W3Le/1kBcZCzbRhnqph6AnJeEjWZk2MihTprj5mOHBQ9CevYqxmsDEw3sh9kJtBfVCw6evRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=nuLdq5Nm; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="nuLdq5Nm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736770391; bh=7mSkffdXqq8EFA8EUzl/xt+T6ken0cn5qrMnTzg2iwk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nuLdq5NmG2wvmFUUfKToOYvQH4Yy3j8ErnHZB3oyIFXBrLeqRF4NAxDpq69HADsXk dItFVsaKZ//uPjw0gK+A+jGSf3zLRXZMP5PDYSQKv+mTiPAo0owESJ6xQfw2wRVjbR Wfh4ubDTo5tG1dtHWYvz7MPnblCoiXN7tX8OMKcw1RZbmhCXtCKLIib56DYOYAybUO TRrCvd5Ip+2rGaQGn/TMtkEJyHP2xtk/+BNBJd4U9OK1bYBPdv420sDaQPowFbdAEX FrnB18ncmVvDEbXqU1SGelu2ZPtuBONL4yP+IXnhYZfO5mud+/3hlzAfgtvyZPiK+Z 5zGKwERULdvLg== Received: from [192.168.1.90] (unknown [82.76.59.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id A37C617E0D9D; Mon, 13 Jan 2025 13:13:10 +0100 (CET) Message-ID: <78046727-0d2a-4ada-b75c-ec2e80e1f560@collabora.com> Date: Mon, 13 Jan 2025 14:13:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/display: hdmi: Do not read EDID on disconnected connectors To: Dmitry Baryshkov Cc: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250111-hdmi-conn-edid-read-fix-v1-1-d68361624380@collabora.com> <20250113-piquant-lizard-of-strength-ee5760@houat> From: Cristian Ciocaltea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/13/25 2:06 PM, Dmitry Baryshkov wrote: > On Mon, 13 Jan 2025 at 14:00, Cristian Ciocaltea > wrote: >> >> Hi Maxime, >> >> On 1/13/25 11:35 AM, Maxime Ripard wrote: >>> On Sat, Jan 11, 2025 at 12:04:09AM +0200, Cristian Ciocaltea wrote: >>>> The recently introduced hotplug event handler in the HDMI Connector >>>> framework attempts to unconditionally read the EDID data, leading to a >>>> bunch of non-harmful, yet quite annoying DDC/I2C related errors being >>>> reported. >>>> >>>> Ensure the operation is performed only for connectors having the status >>>> connected or unknown. >>>> >>>> Fixes: ab716b74dc9d ("drm/display/hdmi: implement hotplug functions") >>>> Signed-off-by: Cristian Ciocaltea >>>> --- >>>> drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c >>>> index 2691e8b3e480131ac6e4e4b74b24947be55694bd..8e4b30e09b53b84cfd36199d56db3221a00085b0 100644 >>>> --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c >>>> +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c >>>> @@ -786,8 +786,10 @@ drm_atomic_helper_connector_hdmi_update(struct drm_connector *connector, >>>> const struct drm_edid *drm_edid; >>>> >>>> if (status == connector_status_disconnected) { >>>> + drm_edid_connector_update(connector, NULL); >>> >>> Why is this needed? It's not mentionned in your commit log. >> >> The original implementation has it after reading the EDID, but I'm not >> sure if we need the explicit reset in this case. >> >> I was going to submit a new revision switching the order, as Dmitry >> suggested, or should we simply drop it? > > If the EDID is not available, it needs to be reset. Thanks for the confirmation - I will mention this in the commit description. Regards, Cristian