From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E6C13C3C0C for ; Sat, 8 Aug 2026 11:06:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786187187; cv=none; b=CSJjBNxWD/XdkmKpPr1VFhPU2aLo937BD2ofTNPIWz8NJusl+4EaJsI/O6nhMrHJuu+B/WWG0rLSwxmxEzctjkVhcR17e3CdwAzWsWK/GUcxr6ljII7kNx34Tbj043dKBK+VSDHjKVosPEP/CiK9UYZhVyuOVN1bqeAlPBJ/cUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786187187; c=relaxed/simple; bh=tDsFj4Lh9ROCK1QL6OxCscLJBiWTpO7vMwF1199NUaA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SHTM2zxDqy5/zdbRrP9eOQeZypntvmuAMeMu+RyGzfQmvlHjdxT4Z7F86c8nJ1BnDVchYgnCEyozij86FDbd0Ha7dMSNkxN+qvqjhkIi5fnlryFadfw7ey8iC0dvHWIvPIq4gHCxPi7w8Q2bFp+lNhp1aXRu589HNpUpW3cjdlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aqtvqisa; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aqtvqisa" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-384930ca5e2so395999a91.3 for ; Sat, 08 Aug 2026 04:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786187185; x=1786791985; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hTWsfLJS/81iyczYbFu23mRRJqJRdNk8TSWy7ODIao4=; b=aqtvqisaSfmRgbgmXiZItxO6cdp6CJCvU2xi8KQyHTOEgXvX+p5mbLocVg2WkigFff Rj6zJwIMmnP3rezFT2a7ZCgLa+1j9cP8G0qbQOjJG31q7EBhNrM+tcHCwKPC4pWKs9KU h216ZnIHQtQCtBKvVfCDXhZ9QTsW06f9104xFGdlSeZbW+O7XRVXmqx0xCv66DKuMv9c fyvO9KeecpQtqLA6URSRQwOsq5toOIDyPyh199sWFtxR9WPpuFodkHYT2DSqqpgG37eA EcEBoFX+ttTj0p5SSacPQxQXLzM3hcp9wfW9KvCLe1ju04OUfZ88/OrhsnDW9vDSoinY Tgbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786187185; x=1786791985; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hTWsfLJS/81iyczYbFu23mRRJqJRdNk8TSWy7ODIao4=; b=NfJtqfjBL8AGshDyDj97X8OOc2KBu8FeS4Jwjmvy0et0cymHCmZFIPghhUxt5Fk6+M GHBUg+eaeLBYOpEbPafzCO6ejQTLzAVD3GIBbwOXC5WRMhYw18TjdUHEKfL0JS5PRafG 5eGL4hxTtyS02xntZ8FbTknl9KNZiiIw+1BENzISOcppcR3CoXLdK1bUAobowHGmpECc f0GDAH5D+6isk4ypKoNhh7Y2TqyObT2vDD0dtvHS5I7RQXrcwrhhD7XQ1lksgvN9Y1Z6 0rsS7ZeZU3O3fNOrGDC1PyY99OEnF3//6SgaBYMDZ823qkTMIo4aSJHMrWWblb9xELoQ 201g== X-Forwarded-Encrypted: i=1; AHgh+RrmT51S6AIr8t1OmOSDXi0HFuRFSt5FrSTemSq14IVuHqOYWrILsKD/NxNTKyUfwepN4kR75p3uH3YUGcw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywj6AsC0HR/sgDWht9A1upTpJi5PwMS6awo+b7AoXJVrevr0D/t u+prYX09gM/Qdghnev31GJCuNiC/GzyM6WdnLu7KdChVgiLJJ3ic1iTu X-Gm-Gg: AR+sD12YBx+BsiX0yDSbrVb7XVMgXQGKM0FK16MYc0/VGp4Z5++4jZaK8zATwjhYPo2 R7cRnLQgKJs6lJWc99QJESEpN1RFvIiohWxlHsnf08LYgSiMYNQAZ0dAeEGDwGhRgiLXUeafRbf pHEAnwhU4rADTRmkdd9ofqooy67/wrziDLs+vQv8M7p00ua64eQauWvBsTxRKPwI71ZdlcPGKP0 y2rCYtJz2jIdCcl+iLHPuCSA9eOBiyWGyGdG5HS1iO6feuSLu/YwIzLhTwBHr61RLQ8sCyl69VF DSg149S3A3qoyXumqkQ2JFv2wIkefaRQeI1kjThH4spgiNFYbgT/Tm5D+FPtoQyI2ZrYTzZ9F9C qjcXheb+OrQ8qJJLXmb4ZoONptOWo0kUtfLGHLvJUVQ2a3U2KrE3Y2CgT+yCDyL5l4wmGKOpogV 79lAiNp+6VaL0Y9CIQpCJw8oaD1XhSErQJAW3g7hpv6HZCrrIA2m4PS7ffAWTa6aaxVtpX2u6LC at9dQ== X-Received: by 2002:a17:90b:2dc1:b0:38f:de97:b06 with SMTP id 98e67ed59e1d1-3903c535d79mr33954628a91.5.1786187185202; Sat, 08 Aug 2026 04:06:25 -0700 (PDT) Received: from SGN-LDSENG.tasernet.com ([2405:4800:5cc3:11a:1ac0:4dff:fe8b:4a69]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141019b4eabsm15243343c88.6.2026.08.08.04.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 04:06:24 -0700 (PDT) From: Cong Nguyen To: Maxime Ripard , Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Cong Nguyen , stable@vger.kernel.org Subject: [PATCH v1 1/3] media: sun4i-csi: fix video device and subdev leak in notify_complete() Date: Sat, 8 Aug 2026 18:06:15 +0700 Message-Id: <7804a3c87beefde14e0358fa2a11e63005525890.1786184456.git.congnt264@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sun4i_csi_notify_complete() registers the bridge subdev with v4l2_device_register_subdev() and the video device with sun4i_csi_v4l2_register() (which calls video_register_device()) before it creates the media pad links and registers the subdev nodes. If any of the later steps fail, the error path only unregistered the media device: err_clean_media: media_device_unregister(&csi->mdev); return ret; The already registered video device and bridge subdev were left behind. Because this failure propagates back through v4l2_async_nf_register() and aborts probe, the driver's devm-managed struct sun4i_csi (which embeds the video_device) is freed while /dev/videoX is still registered, so a subsequent open() from userspace dereferences freed memory. Unwind the registrations in reverse order on error, mirroring the teardown in sun4i_csi_remove(): unregister the video device with vb2_video_unregister_device() and the bridge subdev with v4l2_device_unregister_subdev(). Also unwind the intermediate v4l2/media registration steps so every early return leaves no half-registered state. Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen --- drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c index e53a07b770b7..a8711336a754 100644 --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c @@ -85,11 +85,11 @@ static int sun4i_csi_notify_complete(struct v4l2_async_notifier *notifier) ret = sun4i_csi_v4l2_register(csi); if (ret < 0) - return ret; + goto err_unregister_subdev; ret = media_device_register(&csi->mdev); if (ret) - return ret; + goto err_unregister_video; /* Create link from subdev to main device */ ret = media_create_pad_link(&subdev->entity, CSI_SUBDEV_SOURCE, @@ -114,6 +114,10 @@ static int sun4i_csi_notify_complete(struct v4l2_async_notifier *notifier) err_clean_media: media_device_unregister(&csi->mdev); +err_unregister_video: + vb2_video_unregister_device(&csi->vdev); +err_unregister_subdev: + v4l2_device_unregister_subdev(subdev); return ret; } -- 2.25.1