From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17ABB1531C1 for ; Wed, 28 Jan 2026 23:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769643099; cv=none; b=B7FQvR4vBhxoc/6iB9o/74GOYl6lRtbbE6ism/bNZiHi5JXxFsvND8KXQVcb7NoEcH5WJsc6ExxPI1lXFS2XY03wlNzfMdyzKc+4a1QA2HAYbHujayYfvatscVgUcMTLKB5mxrUoAtf1WGmzFEWqj5BJF6fTew/IAf3VU+aCSRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769643099; c=relaxed/simple; bh=zC3JIr79bDajTmXSyD81XupwjN4nHWr4MVxwS+CRW3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=GQBZfj9nsgkUL05NHp3HhmluUnRPusPJ3cLCXqSXaK5cmFIH/dpD6TXqZaE+Cjxq7JZeIjezLLVa7zT0Y9VdmH4XQvgrGJ+m82I9KLltRlxj4w/Bgw0+Lh9k+nygNcOQplslGuA4azepNuSUHig2ewbosXkbqljYNb1byUWRuis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=Li8FflG3; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="Li8FflG3" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260128233133euoutp01eb4118743d9fd3e5b3df23b9e680280a~PCQSMB4FI0210102101euoutp01B for ; Wed, 28 Jan 2026 23:31:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260128233133euoutp01eb4118743d9fd3e5b3df23b9e680280a~PCQSMB4FI0210102101euoutp01B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1769643093; bh=cVNVdrc3ypCMw932N3L2i4gO/mh6FGcnGz0CdF36/xc=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=Li8FflG3uz0fSMb6YkEdWieBNXVAjxjus6/oD9fTw5PN89eHHLNG3C4b9lrBuvrIS VpROMrLMKJ0Qrh/wylHkRs3gd/uN6TdJ+kyw25mW86HoBNZLh5ARaqMVpglRMU6mYg RvmK4XlRKa2kKYbTjIfljwI89NmYXzE3e6t8TPro= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20260128233132eucas1p1f57368f41dcd3a718cada8b95c1a3fab~PCQRTTpUD2444824448eucas1p13; Wed, 28 Jan 2026 23:31:32 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260128233132eusmtip2187009b9292de67a5ea37de687f298d6~PCQQrNe6A1539815398eusmtip2G; Wed, 28 Jan 2026 23:31:32 +0000 (GMT) Message-ID: <7809b35a-fee2-43e2-999b-9244e5efaa17@samsung.com> Date: Thu, 29 Jan 2026 00:31:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem() To: Mark Brown , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Rob Herring (Arm)" , Oreoluwa Babatunde Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20260128-cma-fix-stubs-v1-1-e07a077d5b33@kernel.org> Content-Transfer-Encoding: 8bit X-CMS-MailID: 20260128233132eucas1p1f57368f41dcd3a718cada8b95c1a3fab X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260128163207eucas1p15d5e6380ad65350de185ded053d0ed2d X-EPHeader: CA X-CMS-RootMailID: 20260128163207eucas1p15d5e6380ad65350de185ded053d0ed2d References: <20260128-cma-fix-stubs-v1-1-e07a077d5b33@kernel.org> On 28.01.2026 17:28, Mark Brown wrote: > The stub for cma_skip_dt_default_reserved_mem() is not inlined so > triggers build warnings: > > In file included from /tmp/next/build/fs/proc/meminfo.c:18: > /tmp/next/build/include/linux/cma.h:68:13: warning: 'cma_skip_dt_default_reserved_mem' defined but not used [-Wunused-function] > 68 | static bool cma_skip_dt_default_reserved_mem(void) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > which are fatal with -Werror. > > Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework detect "cma=" kernel param") > Signed-off-by: Mark Brown I'm really sorry for this build break and thanks for applying this fix for today's release. This issue has been introduced by my amendment to the original patch, so if You don't mind, I will amend it again and squash with this fix to avoid messing the last minute fix with potentially not bisectable branch. > --- > include/linux/cma.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/cma.h b/include/linux/cma.h > index 0bf408360641..d0793eaaadaa 100644 > --- a/include/linux/cma.h > +++ b/include/linux/cma.h > @@ -65,7 +65,7 @@ extern void cma_reserve_pages_on_error(struct cma *cma); > #ifdef CONFIG_DMA_CMA > extern bool cma_skip_dt_default_reserved_mem(void); > #else > -static bool cma_skip_dt_default_reserved_mem(void) > +static inline bool cma_skip_dt_default_reserved_mem(void) > { > return false; > } > > --- > base-commit: d0d97f0b2b2b4633022dfaef4ac08af0b7917efe > change-id: 20260128-cma-fix-stubs-26b13ce1471d > > Best regards, > -- > Mark Brown > > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland