From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95ED0367F26 for ; Thu, 21 May 2026 14:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779372788; cv=none; b=DIrjwnOQOrQsCEzT5Am82PhCaZf3NS51OPRoGErsrPQW6BDAhu8jflwDGRkd83JKgV6oJRkMPGCp+EuvX579sDZDC1NYClXcPuEI8rXHQWCCYW/veCPtGGLDST3F7PRdOJxhfG+mDmzYI5r+XSj4TmHgN+Gs64CF9yGxmiIbmCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779372788; c=relaxed/simple; bh=/Ll4LsJw2NuGzLS/mu1onbW6xXMghR0UiL10bny4GZ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kuB0UnkBR3z+QdE5oQ8ZWsb8Fc8D4db2EjUxUW3l5IS9QAK4WGXgn+n9MVPOyCJtvGoB+a4c892zRr6BeHOR6rLEFHNxZwj4VXJT48LGwY5Z7asUN4jHptHhE75Vtkw8DTN3BXMfNkqHzN8CDI3Vd6r7i0vscZFtar62XAjP8aA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VCvQk+hP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qeHHPaP6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VCvQk+hP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qeHHPaP6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779372786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SaWkb3YbEdaxwTpBI74c931mIOI0075U6MVUEur6iVg=; b=VCvQk+hPrRucCN5HheHVXYlooxsXxSvrppZRi1vM3r18spTpC1wvhVaOtxEJ7Ty6pjyyP+ kq+37mAFfamDnBi+D8RUBnA/gM6ZCsrk2nTjwtxchp1NVfN0S8ngfDIlFTd3AwWw+l3Q2A b7ffXISAxW2lnz/lR3p8Br+OyJ2cVJw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-mD0TcyuKPYiy8tNw3b2lvQ-1; Thu, 21 May 2026 10:13:04 -0400 X-MC-Unique: mD0TcyuKPYiy8tNw3b2lvQ-1 X-Mimecast-MFC-AGG-ID: mD0TcyuKPYiy8tNw3b2lvQ_1779372784 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-44dad1b938fso3841509f8f.1 for ; Thu, 21 May 2026 07:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779372783; x=1779977583; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SaWkb3YbEdaxwTpBI74c931mIOI0075U6MVUEur6iVg=; b=qeHHPaP6vaTnE+skqhQhM2j++2c2D/SlFomnM7LlCqcE5vOP5Uq1CTAGiwdSMUgehJ dw3hz/rpdM0NIk3OAxX6Z1xRgLpNUp4sliKt4aLoay7Byidj3BPvML/3/yuXWH9Cv1JO orl6KYc+BWS7jq5zUBMZjdVDLwWEZiyZY9JQhDoTFSiRe558jEDzPA5donMM3pE6Mmi8 /OFO1YNYb5mjn4RQvyd68Y0lq6sEwt4Q9xxku54vced5Kt2zf6em0HD93dg5RIED7POa 97dkUxQxGJ8GENoIN5ReWSTvFdkG6t8JVQ7hHLfUOwVa2mIMxkrAJbLu8CJEk/QL37VJ VeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779372783; x=1779977583; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SaWkb3YbEdaxwTpBI74c931mIOI0075U6MVUEur6iVg=; b=PEr8aexvd7E/nNnhO7kKMqdIASOEWCVR316ahXYbIO0nDOOtP+c+7ieEPc3eNakFx/ 1NNhIlA+5lJN7gGFePWeUxh0LCATXWaSsphRhklI8FIxGA68gomh4l+F2ki9PBn77LfH dYk/oGrcTA4q6YADSG+azqVoxBf7IPO7NaA9GnAPfRG8JQQvo7lyj4+aUitkYOSJ3ssm XrMdUyveQIOB2S5NqsyLCtJGfbCKhXyrtk9mmOax8AOFsZnIv8oRc12KPD5ci5LMOs6x Hm+ICHEIL8yl42P30mPWFbK45s+G6myiTloobQGqaiMz08hMZ9zm7sTVy++21KqmLjfl Wzqw== X-Forwarded-Encrypted: i=1; AFNElJ/vlvKVi92nh9k6jeHrfqjTc0VKyZxZcHC7y+487gziAjKkBffzjFMQV/mQYp69la3EIYwhAzrTJHP6vrU=@vger.kernel.org X-Gm-Message-State: AOJu0YzeCMIhaApVskVBU7FI5dW2+wBKN9usGSosNKhHShzHHkz8FtB1 +25gc5EMHN8iCPFmNqNXvNgmjA678JrdTMa7ILGZODacGU7zuaG47aCURYDoW9IENx9gZe+S7ZP ySLx3EIHcQ7egXNN7nFMOlLsI2G0ldx+zd72JIoS6dIehII511h5ESPhia2I1aJ9VeA== X-Gm-Gg: Acq92OHNl95gpIPCgtMyFivE15eidiDhMpBiS31fXHjISsHC9JtWILTJl0qTkSY+5KC 3/O1g5+cxdFvE2GKX0HdGPxiZkkOR1z4Zprztg3rBnQNeSDpjjtne+ZkIAhvwg8A0VExKwEnl4G 5hZRZAk+F8dEbGcwsMYahsNL+xm10B4zEVfd7U89NubWR4H1QC5aNqRx8HOgGkDaibbwhW7bxJ5 MG6gJW+tZPWTTfrDhn9+fGDjQAMXQb8L3dQfLmMN/WLncspJdq/Mx9R2OKTS/2GltyG7d+RnSJt H4PQ8LfUlazU3+Z9Crkxr0xt/dLlKWhTD9GeL1FRRc6pfCVk0q/nkT33oDGLs8LABlRYKv4KZcd LAwJTqQ+yHATj2aJT8NsWWKf2pUx2UMiRWD3FuL055MwWVO7y9AiAma1ukA== X-Received: by 2002:a05:6000:468e:b0:44b:cd2f:a3c8 with SMTP id ffacd0b85a97d-45ea3ae602cmr3713717f8f.4.1779372783455; Thu, 21 May 2026 07:13:03 -0700 (PDT) X-Received: by 2002:a05:6000:468e:b0:44b:cd2f:a3c8 with SMTP id ffacd0b85a97d-45ea3ae602cmr3713651f8f.4.1779372782943; Thu, 21 May 2026 07:13:02 -0700 (PDT) Received: from [192.168.88.32] ([169.155.232.242]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eaa9358c5sm3054266f8f.30.2026.05.21.07.13.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 07:13:02 -0700 (PDT) Message-ID: <780d21ed-4ab3-478c-a932-6feb7aa6d7b4@redhat.com> Date: Thu, 21 May 2026 16:13:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3] net: napi: Skip last poll when arming gro timer in busy poll To: Martin Karsten , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman Cc: Joe Damato , Tariq Toukan , Gal Pressman , =?UTF-8?B?Qmrvv71ybiBU77+9cGVs?= , Frederik Deweerdt , Dragos Tatulea , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260518181337.886459-1-mkarsten@uwaterloo.ca> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260518181337.886459-1-mkarsten@uwaterloo.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/18/26 8:13 PM, Martin Karsten wrote: > + } else { > + /* All we really want here is to re-enable device interrupts. */ > + rc = napi->poll(napi, budget); > + /* We can't gro_normal_list() here, because napi->poll() might > + * have rearmed the napi (napi_complete_done()) in which case > + * it could already be running on another CPU. > + */ > + trace_napi_poll(napi, rc, budget); > + netpoll_poll_unlock(have_poll_lock); > + if (rc == budget) { > + gro_normal_list(&napi->gro); Not blocking, but I find the above slightly confusing after this refactor. Perhaps it should be re-worded? /P