From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751211AbdEaIfy (ORCPT ); Wed, 31 May 2017 04:35:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53806 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbdEaIfw (ORCPT ); Wed, 31 May 2017 04:35:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6A6BF60796 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. To: Boris Brezillon References: <20170511183128.25085-1-eric@anholt.net> <20170511183128.25085-5-eric@anholt.net> <20170531082627.5953f75b@bbrezillon> <20170531100755.1764b998@bbrezillon> Cc: Philippe CORNU , Eric Anholt , "dri-devel@lists.freedesktop.org" , Andrzej Hajda , Laurent Pinchart , CK Hu , Philipp Zabel , Yannick FERTRE , "linux-kernel@vger.kernel.org" From: Archit Taneja Message-ID: <780d9b38-4645-64fc-43ab-d956d78e8933@codeaurora.org> Date: Wed, 31 May 2017 14:05:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170531100755.1764b998@bbrezillon> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/31/2017 01:37 PM, Boris Brezillon wrote: > Hi Archit, > > Le Wed, 31 May 2017 13:31:16 +0530, > Archit Taneja a écrit : > >> Hi Boris, >> >> On 05/31/2017 11:56 AM, Boris Brezillon wrote: >>> Hi Philippe, >>> >>> Le Tue, 30 May 2017 16:55:42 +0000, >>> Philippe CORNU a écrit : >>> >>>> Hi Eric, >>>> >>>> I took your patch for the panel-bridge and it works perfectly in both >>>> DPI mode (panel RGB //) and DSI mode (bridge dw mipi dsi), bravo :-) >>> >>> I still don't understand how it can work without a call to >>> drm_bridge_attach() (which is used to link the RGB encoder to the DPI >>> connector). I'm probably missing something obvious. Maybe someone can >>> point it out :-). >> >> I think the expectation is that there will be a follow-up patch that >> would add bridge support. Philippe had posted a patch for adding bridges >> to ltdc before: >> >> https://patchwork.kernel.org/patch/9724835/ >> >> He can now redo his patch over Eric's panel-bridge patch-set. > > But by doing that you're breaking bisectability, or is it working when > applying only Eric's patchset? > > If applying this patch breaks the driver, why not applying it after > bridge support has been added to this driver? Yeah, it would break the driver. Philippe can create a patch that adds bridge support using the panel-bridge glue layer using Eric's patch as a reference. In the end, there should only be a single patch. Thanks, Archit > > Regards, > > Boris > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project