From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE81AC433E4 for ; Thu, 16 Jul 2020 19:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C22A6207BC for ; Thu, 16 Jul 2020 19:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729534AbgGPTSU (ORCPT ); Thu, 16 Jul 2020 15:18:20 -0400 Received: from foss.arm.com ([217.140.110.172]:39474 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729387AbgGPTSU (ORCPT ); Thu, 16 Jul 2020 15:18:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23D4231B; Thu, 16 Jul 2020 12:18:19 -0700 (PDT) Received: from [10.57.35.46] (unknown [10.57.35.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED5483F718; Thu, 16 Jul 2020 12:18:17 -0700 (PDT) Subject: Re: [RFC PATCH v1 1/2] dt-bindings: arm: rockchip: add A95X Z2 description To: Johan Jonker , Rob Herring Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <20200620134659.4592-1-jbx6244@gmail.com> <20200620134659.4592-2-jbx6244@gmail.com> <20200715192935.GA684031@bogus> <14b39efe-f38b-b471-560d-1ecaeafc5dd5@gmail.com> <56b1447d-6c62-9e73-a7ce-08fb70096a97@arm.com> <544f9182-034b-6309-a945-72b5a34ee2e8@gmail.com> From: Robin Murphy Message-ID: <7811d168-6f41-adda-bd64-e7475b239863@arm.com> Date: Thu, 16 Jul 2020 20:18:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <544f9182-034b-6309-a945-72b5a34ee2e8@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-16 17:11, Johan Jonker wrote: > On 7/16/20 3:34 PM, Robin Murphy wrote: >> On 2020-07-16 13:05, Johan Jonker wrote: >>> Hi Rob, >>> >>> The A95X Z2 boxes are sold by various vendors/manufacturers/web shops. >>> The box it self only shows a label with a model name. >>> Determining the true vendor is a kind of tricky for a outsider of the >>> business. >>> Could you advise what would be a save choice to the rather rigid vendor >>> requirements. >>> Is for example this a option: >>> >>>    "^a95x,.*": >>>      description: A95X >>> >>> Is there someone who can give more info on this subject? >> >> FWIW we already have some "A95X" branded things attributed to Nexbox in >> upstream DTs, however, the evidence from scraping around the internet >> suggests that the closest thing to an original vendor for the "A95X Z2" >> model is probably these folks: >> >> https://zkmagic.en.alibaba.com/ > > That's where I got my update/backup img from. > A mail was sent, but what if they all claim to be a 'official' or > 'direct' store? Well, at some point we have to make a judgement call if the facts aren't easy to come by, but it's already clear that "A95X" is not a vendor but some kind of generic model name apparently used by multiple vendors. We already have "nexbox,a95x" as a binding for another model, and a plausible idea of who's responsible for this one, so I think "zkmagic,a95x-z2" would be the appropriate binding here. It's hardly the end of the world if it's not 100% accurate, but that's no excuse not to at least try. Robin. > > option 1: > > - description: A95X Z2 > items: > - const: a95x,z2 > > "^a95x,.*": > description: A95X > > or option 2: > > - description: Zkmagic A95X Z2 > items: > - const: zkmagic,a95x-z2 > > "^zkmagic,.*": > description: Shenzhen Zkmagic Technology Co., Ltd. > > I'ld rather prefer a short neutral name like option 1 just to be save. ;) > For the completeness there seems to be: > a95x a2 > a95x a3 > a95x f1 > a95x f2 > a95x f3 > a95x max > a95x max plus > a95x r1 > a95x r2 > a95x r3 > a95x r5 > a95x z2 > a95x z2 + > > Any advice welcome.. > > Johan > >> >> Robin. >> >>> >>> Kind regards, >>> >>> Johan Jonker >>> >>> On 7/15/20 9:29 PM, Rob Herring wrote: >>>> On Sat, Jun 20, 2020 at 03:46:58PM +0200, Johan Jonker wrote: >>>>> Add A95X Z2 description for a board with rk3318 processor. >>>>> >>>>> Signed-off-by: Johan Jonker >>>>> --- >>>>>   Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ >>>>>   1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml >>>>> b/Documentation/devicetree/bindings/arm/rockchip.yaml >>>>> index d4a404509..3d44b3cf0 100644 >>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >>>>> @@ -25,6 +25,11 @@ properties: >>>>>             - const: vamrs,rock960 >>>>>             - const: rockchip,rk3399 >>>>>   +      - description: A95X Z2 >>>>> +        items: >>>>> +          - const: a95x,z2 >>>> >>>> Need to document vendor prefix. >>>> >>>>> +          - const: rockchip,rk3318 >>>>> + >>>>>         - description: Amarula Vyasa RK3288 >>>>>           items: >>>>>             - const: amarula,vyasa-rk3288 >>>>> -- >>>>> 2.11.0 >>>>> >>> >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>> >