From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67B3A1A4F1D for ; Thu, 20 Jun 2024 17:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718904203; cv=none; b=uJTwhJFYTkoOH3pebCQTTltmSQ3BoXjkbDbxTEtF0cEh3WN7UT+KYWcH1FOCdreeG/U+C4kyQPDJgriTpy9EsIeR8FUuvduWSyLUV/7IeMeKF5xrIIO9d69e191C1yOU05vsoqIwjvmoa432ZjtiPPsyC0ht3be2sF/seg32bXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718904203; c=relaxed/simple; bh=iR1hJtv87pNQjsUqNnTsI+mBP3fSI2lFXI8PtdSiVJQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fxT//TTZCFlfu7yKZjYjtG4KZ1/ell1llCoL92MGpohOArxkQnH8EWGVzLKZ0UrIYaHBX3jGo3D8a/Bm0MUJ0v6t/6WBn6G1bDQnZPbMmz/XTiSz8CYg4DPkxsxBWfBBQqHQJnGJu3dvbXzFgrqrifBpPJFpVNFcuOWuDyeN77o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fAJXyoxr; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fAJXyoxr" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7eb41831704so4550639f.1 for ; Thu, 20 Jun 2024 10:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1718904201; x=1719509001; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FlU6+y4BHLjXwtlM+MZtrekLVfSINHVJwdH6Sy90VoQ=; b=fAJXyoxry3pFgtbr1sDUqIqeXGHrhh6sj37+c+kbMe6Wk0MpHI9hFovFUaOCOS7sLc GcXvS0Bk8xykeTVjpW2qPk/o75fofYuOBhacNKHtqQnhcbJOveAkBcoiC1Dtn0Io+oPk 9C2lkWdvy0psLSIIpMcuFpfNCB9I9b41om45s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718904201; x=1719509001; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FlU6+y4BHLjXwtlM+MZtrekLVfSINHVJwdH6Sy90VoQ=; b=BFbyv+NN4Ca0f0AcCy7NB8sm5g3nryMsamDwjNHX3IZ+UsbsxDy3NgJb8GbEUCOwiQ HkHwm93YniSKVApyevjiE7RdTyoahry7JDPAP977usq/s7K0hbtbSf/Ink2iM88UZLyk icsVWC9XM73vzVWqrHsjbfWffnNeIHZvB0YgtgK7wUBHhcZy3n43U6Dm+tP+Epk2ygWL aVbPHHPgaxQZN5pcGM5Ofp4LB0B+weUMEDI5XzMJS62GbRawgJS4HFYJy/nvdt/vPiPN n8Z5d9L6/xE79RCOPie5tEAqyEGrp/YDwzyWIIGGSxOysXZQMCZdSGNSKEquSVWu1dG0 HEVg== X-Forwarded-Encrypted: i=1; AJvYcCUu8zWOtLPUdiMs9p9MVoZKyAPIIBlG2lFruQa1cG8MLleCslKUPrLLvY528jGkuESSPiRug1m0a0RF8Q6FroLNbh35E/FL9m4PNA4f X-Gm-Message-State: AOJu0YyXwB/dsj7i3nL1xT+/Q8uNuMa7RYhN4DBLKFfmY53DwoGv39nq qCbPAOGIjYekqogaVOceNoc4R/UoXSFwOYZlJLo0vp5vY3IGHAYZGGQZi1iy5inLEmn3X6Wd7SZ I X-Google-Smtp-Source: AGHT+IGWet0XQ+vzyT13uHf4e001ipaSD/KmPeZaAUUCneyTN6bP+l80PqUd4Z+6PSqDwRdi++onag== X-Received: by 2002:a05:6602:3b84:b0:7eb:73f1:1357 with SMTP id ca18e2360f4ac-7f13eb9a591mr646959339f.0.1718904201518; Thu, 20 Jun 2024 10:23:21 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b9569ef046sm4644835173.105.2024.06.20.10.23.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 10:23:21 -0700 (PDT) Message-ID: <78166e23-d3d8-4e20-a453-33af1689e6c4@linuxfoundation.org> Date: Thu, 20 Jun 2024 11:23:20 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] cpupower: Change the var type of the 'monitor' subcommand display mode To: Roman Storozhenko , Thomas Renninger , Shuah Khan Cc: Javier Carrasco , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240620-change-mode-type-v2-1-8c3a499be64e@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240620-change-mode-type-v2-1-8c3a499be64e@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/20/24 09:57, Roman Storozhenko wrote: > There is a type 'enum operation_mode_e' contains the display modes of > the 'monitor' subcommand. This type isn't used though, instead the > variable 'mode' is of a simple 'int' type. > Change 'mode' variable type from 'int' to 'enum operation_mode_e' in > order to improve compiler type checking. > Built and tested this with different monitor cmdline params. Everything > works as expected, that is nothing changed and no regressions encountered. > > Signed-off-by: Roman Storozhenko > --- > Changes in v2: > - Moved cover letter content to the change log > - Link to v1: https://lore.kernel.org/r/20240619-change-mode-type-v1-1-31e7e45028f0@gmail.com Applied for Linux 6.11-rc1 https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower thanks, -- Shuah