From: 管雪涛 <gxt@pku.edu.cn>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>, a zummo <a.zummo@towertech.it>,
sangjung woo <sangjung.woo@samsung.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: 回复： [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue
Date: Mon, 12 May 2014 15:53:10 +0800 (CST) [thread overview]
Message-ID: <782248460.17099.1399881190362.JavaMail.root@bj-mail03.pku.edu.cn> (raw)
In-Reply-To: <536479AD.9040104@gmail.com>
Acked-by: Xuetao Guan <gxt@mprc.pku.edu.cn>
----- Chen Gang <gang.chen.5i5j@gmail.com> 写道：
> It is only a typo issue, the related commit:
>
> "1fbc4c4 drivers/rtc/rtc-puv3.c: use dev_dbg() instead of pr_debug()"
>
> The related error (unicore32 with allmodconfig):
>
> CC [M] drivers/rtc/rtc-puv3.o
> drivers/rtc/rtc-puv3.c: In function ‘puv3_rtc_setpie’:
> drivers/rtc/rtc-puv3.c:74: error: implicit declaration of function ‘dev_debug’
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/rtc/rtc-puv3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> index 1ecfe3b..c56310e 100644
> --- a/drivers/rtc/rtc-puv3.c
> +++ b/drivers/rtc/rtc-puv3.c
> @@ -71,7 +71,7 @@ static int puv3_rtc_setpie(struct device *dev, int enabled)
> {
> unsigned int tmp;
>
> - dev_debug(dev, "%s: pie=%d\n", __func__, enabled);
> + dev_dbg(dev, "%s: pie=%d\n", __func__, enabled);
>
> spin_lock_irq(&puv3_rtc_pie_lock);
> tmp = readl(RTC_RTSR) & ~RTC_RTSR_HZE;
> --
> 1.9.2.459.g68773ac
next prev parent reply other threads:[~2014-05-12 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 5:06 [PATCH 0/2] drivers/rtc/rtc-puv3.c: fix 2 typo issues Chen Gang
2014-05-03 5:07 ` [PATCH 1/2] drivers/rtc/rtc-puv3.c: use dev_dbg() instead of dev_debug() for typo issue Chen Gang
2014-05-12 7:53 ` 管雪涛 [this message]
2014-05-03 5:09 ` [PATCH 2/2] drivers/rtc/rtc-puv3.c: remove "&dev->" for typo issue MIME-Version: 1.0 Chen Gang
2014-05-12 7:56 ` 回复： " 管雪涛
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=782248460.17099.1399881190362.JavaMail.root@bj-mail03.pku.edu.cn \
--to=gxt@pku.edu.cn \
--cc=a.zummo@towertech.it \
--cc=gang.chen.5i5j@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sangjung.woo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome