From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbcLDKVd (ORCPT ); Sun, 4 Dec 2016 05:21:33 -0500 Received: from mout.web.de ([212.227.15.3]:58751 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbcLDKVa (ORCPT ); Sun, 4 Dec 2016 05:21:30 -0500 Subject: Re: alpha: Checking for a failed kmalloc() in process_reloc_for_got()? To: Jiri Kosina References: Cc: linux-alpha@vger.kernel.org, Josh Poimboeuf , Matt Turner , Peter Zijlstra , Richard Henderson , Rusty Russell , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: SF Markus Elfring Message-ID: <782323c8-7e33-39e5-ae04-a94cf454a346@users.sourceforge.net> Date: Sun, 4 Dec 2016 11:20:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:DbZdg1PKmVEkCSM6PPesh3ON9FD8oiZiZxKz/olBOrcRjuOFDrN dQmpF3nrTffzcCcBZWMNs6+SZOQAJiwT8QXWwx+HHF7VhZRLelrEAMCK24WZzL2OJmRFfOd 47cD9ttexMt2b6Xp54lyROBxuFiszBhpBlIw9Ta7r1TG1XBzk/ASZmYIEeiQ6jyHkEWChIZ Z3np4uhRqzLn64yQkNN3g== X-UI-Out-Filterresults: notjunk:1;V01:K0:WDctgYv3xMw=:K+8hIpf35rxqvYo55jgT7r rJ36XA46ly7KkneP4M9Jo4y7XfNlk1/hgzDsbGc81ZWnuoANDQdXKzuhNwsnWIJyxAm4CNCu1 T+9hk0fP2feKxMFb7LWOy7c/HfsdBVujeeys/L8zlz8Ztfl3/eoZUOWpJDfmUXxN0uP+4BIKr JUYsbzpVudYkSVU1ouOHLS4NdTG2BQdaMYhRwHX/6o+hyj74F44BYQdRhXHvXHhAij5sYreg8 sXt2tGgk8qedq/Pza2aiNyrJEbK0ok1xTgtW8bL42j1VfpOPaN3DSsT/d1j13XMBe2+tczydP LtS4ZzLKXzwMf9KwvFNRByEqnyReQW2Ia613/QR2LQxPe08FHVS3JGC/bZhXVloMzzR2Mx2AA uLu7hjv6RFE8T1S24RKES3XOJIdMfQ24uaqtFmMNxejcekXn2SYC4Qx5hiH7Emf5YN4pW8Mjg LNR4wq14X2YSEd5VeAtrA+2aKmJPr3ERn7e/z7BD4A69g1row9qwSAixkoMqL2c73ypL7Y/88 LmdjLfYw643PpW/Lgf1cr4aYZIvEiG8tQ0A5OlSkHAQQbxl7DbQF19F4VuZEIoEa3xyS8i40M KLSyGeLU6ehNS3Pe/3uhJiPkbNuSW0llsEvlJMK4KfhVDt2YmjsWjJqxO6ajKyo34z32fMiik 0xtICsAFmfI4tCRbfohEQMeXaCzKtFE27uSMAjDecmyP3LT4xzDtIdkWsD6RLdhNXi9rCpHyF rKHsapwLh3jTdwknUpG/TGU49afLosb65v9yZAMe129z60s3d6c4bpDEFfntX2f4IfqWqGC1I oqXmEQ3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/alpha/kernel/module.c?id=e05f574a0bb1f4502a4b2264fdb0ef6419cf3772#n40 >> >> Would it be useful to check the return value from a call of the >> function “kmalloc” also there? > > *drumroll* it'd actually be a proper bugfix. Which kind of exception handling can be added here when the function “process_reloc_for_got” has got the return type “void” so far? Will it be needed to handle such a software failure at more source code places by a special error code? Regards, Markus