From: "Bao D. Nguyen" <quic_nguyenb@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>,
Avri Altman <Avri.Altman@sandisk.com>,
"quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"minwoo.im@samsung.com" <minwoo.im@samsung.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] scsi: ufs: core: Removed ufshcd_wb_presrv_usrspc_keep_vcc_on()
Date: Fri, 28 Mar 2025 12:39:03 -0700 [thread overview]
Message-ID: <7823d23a-a366-57dc-0e52-36ed26c00d3e@quicinc.com> (raw)
In-Reply-To: <5f9c7657-d86b-47a4-ba4c-5445325886bb@acm.org>
On 3/28/2025 12:33 PM, Bart Van Assche wrote:
> On 3/28/25 1:29 AM, Avri Altman wrote:
>> Maybe just change the function name to better describe what it does,
>> e.g. ufshcd_wb_exceed_threshold ?
>
> I'm also in favor of renaming ufshcd_wb_presrv_usrspc_keep_vcc_on()
> instead of inlining it.
>
Thank you both. I will update.
Thanks, Bao
prev parent reply other threads:[~2025-03-28 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 6:38 Bao D. Nguyen
2025-03-28 8:29 ` Avri Altman
2025-03-28 19:33 ` Bart Van Assche
2025-03-28 19:39 ` Bao D. Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7823d23a-a366-57dc-0e52-36ed26c00d3e@quicinc.com \
--to=quic_nguyenb@quicinc.com \
--cc=Avri.Altman@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=minwoo.im@samsung.com \
--cc=peter.wang@mediatek.com \
--cc=quic_cang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®