From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754185AbdBHKxH (ORCPT ); Wed, 8 Feb 2017 05:53:07 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:62267 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754283AbdBHKvy (ORCPT ); Wed, 8 Feb 2017 05:51:54 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Dan Carpenter , Alexander Alemayhu , devel@driverdev.osuosl.org, stefan.wahren@i2se.com, daniels@collabora.com, swarren@wwwdotorg.org, gregkh@linuxfoundation.org, lee@kernel.org, linux-kernel@vger.kernel.org, eric@anholt.net, mzoran@crowfest.net, linux-rpi-kernel@lists.infradead.org, popcornmix@gmail.com, shorne@gmail.com Subject: Re: [PATCH] staging: vc04_services: remove unused functions Date: Wed, 08 Feb 2017 11:42:21 +0100 Message-ID: <78243491.gCbftNnyIb@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.8.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20170207120943.GC11154@mwanda> References: <20170207115308.5208-1-alexander@alemayhu.com> <20170207120943.GC11154@mwanda> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:VQxQN9OIN8eIliE3E6s5a+TWtVH3ZqJe57mP1Tbpb4MeHx+bh1k nLOxuM2vctBl0QU8k6g+O7peZT8wV3z5yItQqITcGbaK7gTv81/+DIKUb+VMbqGX1CyqsZG zN8pinse1Cfk4U9qHkN1dN6jIB6j59H+Z4sI2ltQacQYWimdlmM7hsMtAggJZBN1EsB35N1 2R7lz1xyy8cyKnutLpAcg== X-UI-Out-Filterresults: notjunk:1;V01:K0:U2yIEi4ljwI=:LT1P+FHiBKcWEUv5SwpYWx IHVuTMqDjztITGaiCNwSokpx1ohoJjPtwh7hyXardduqFQYZrlFx9Lt8tMnzDYUMm6yz+SPOJ USxmeLI+J/+JA6ORApDHVotNfCTCNgBsqfXyDuOGEaBaEne4yE2HCMuZAfExWXzmDY+68ulZw iurdBBnXUlQiQNDOafdiDl+9j1wFAiDkbGEd5YrvoOKSVBMGYOJQfvvxOPYZzZzfm+4U+PrxO 5z1PV1DcevLMoaydu6bJn2NXEzNyNnk8TY0DnHXB9wIj5vN2wQ1ayD9MhoT22HScHzL681c6X qawajPjCo7cDgWMzoLCjI2G2jk5iVBAlUJezpWsqRx89HUqkD47vXqYsBDxVsLYIuQhMszw1M jEAhaiCzCnXyTQCR1o2Mj/tJL4rLt/qJz/Bfl29zA38Z6jO8ADbzK596q0mCZOxESFwPWxdmv likT7e1fUySlSH/FsQOhO+c/6zuYJ3nS6JfNVYkT3rUiFJSN5OTlO9citqNmsPECELvuOuYyh JsIqVcFN3PLr8/mwyokNxYAC8Gt88KWuM9U6D1Oj8JMj7na/ua96cWTV8jso0Iv6h3Zbaio1M 7pbGS995x5zh8TzPpz8CfsTVqZsSuWRHYvz+NY0P1g8o7KIxjIMiG1w4JYGp8Mg9ZL7M+6ZEO d52Yi32hMilsCjohfiMOKZnaCeiVAJQVU/6hIlQxIwt3fxj/Qqzq+KRAO0kPZc8O6a7UAj/ui WZZ1OZnXGVI089zx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote: > There is a bunch of vc04_services that we're still looking to merge in > the near future. Please hold off deleting these until we are further > along on that. > More generally speaking, I'd like to see all the -Wmissing-declarations/-Wmissing-prototypes warnings addressed in the kernel and turn on that warning by default. If there are parts of vc04_services that are intentionally left in place but currently unused, adding a declaration in the header file with a comment should be sufficient to prevent it from getting deleted or seeing bogus warnings. Arnd