From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759607AbbKTK3N (ORCPT ); Fri, 20 Nov 2015 05:29:13 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:56522 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759375AbbKTK3K (ORCPT ); Fri, 20 Nov 2015 05:29:10 -0500 From: Arnd Bergmann To: ulf.hansson@linaro.org Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: fix mmc_{un,}register_pm_notifier prototypes Date: Fri, 20 Nov 2015 11:28:42 +0100 Message-ID: <7826361.qqKATxLhCV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:uaElTKvSnYfmU+X2xcGmAdR71ucU1KiiQalD2YcG+e5e6ZJCS5s IbpfAYjCvt9K9DjnKF4Jf281PauOqFBzOZJEAX6bwS2i56MXATCX7VyBZ2UFT/lhNIrgl2M hUKij5RhTHghxjBqTEOr9ovmBjeIdWp7O8o+aXfwrR857MYc2KHqvUpJBeflx3WRCPIwHB+ sDzJknpvIYsBhqI3Q1CcQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:PPHxBR2j9Lo=:Kp6+5ayby6g47P8dZRo6z5 MphCkYXJQAWQjs1KCbWYXUPzNE04O4kGtn4qZOO96rrwpCytDYOvz9a8UYNyM+yoRvqMA2PFu L7zQ77y2K8xJUAoXO0tiKf5meo/Wk1mXnKifz7zTMesBvGatwP9LqcpZQtM2fS+eVYRgNVLoD lDT0pW0PmqpSSnHIChl9D8PfPA8H5yRhILjscXMo8og6+Dd3/QAaqxh2L8o6ugx4iSBL4doL/ bkrF+LZyOrzFmoKhoKc+ZSzK6cfzpDL9AG3I8CLQW9aBJoKqGC1Qs6/GhvzPIQa8Rt4ileUt5 N1II1C9pHm95Fdsovc8o9C8EJTLCzZ/j53kkD+KRlpVgagCJJ2QGAnYiIWLRQ7LBzcUOxRe2B GNOnbppYkfNxCxtnOGKo0ekkb5C4ZDMRTWiIBda984I7oeCDkwBLCf7Olr9X2AXROJ1SPEt0m HSO2mdmZyHPw04hu+eslNrObedf/C+bu9Y6syTr4KrQ7R0bvBDNdAZZkG46iwzOsrMFDSMpHr ydSnWwchdr0ng/0u9tArcuCoEugMgtzxbrn0qInA4I8kMzNW4DCSp88NJKSR3Vr+2yNlCcN9+ 4dKwb2kDqyHWeG3dg9LYVWqxmUI6aDDixv0Ch4dcHRT24xeEQQIxq4zI/O8lApa39Jo8t3Yz8 BQdABvK29ot0jSI7Jj3yTDJGamFWMSQY2kBwTbTf9RSc5eyZ3+HmFVDau3FtpPmuQJuTXoNj5 9crT4XZgktlAeQM4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The mmc pm notifiers were recently reworked, but the new code produces a lot of warnings when CONFIG_PM_SLEEP is disabled: In file included from ../drivers/mmc/core/sdio_bus.c:27:0: drivers/mmc/core/core.h:97:13: warning: 'mmc_register_pm_notifier' defined but not used [-Wunused-function] The obvious solution is to add the 'inline' keyword at the function definition, as it should be for any function defined in a header file. Signed-off-by: Arnd Bergmann Fixes: 0e40be7c20e0 ("mmc: core: Refactor code to register the MMC PM notifier") diff --git a/drivers/mmc/core/core.h b/drivers/mmc/core/core.h index bd00ac2cdc1b..0fa86a2afc26 100644 --- a/drivers/mmc/core/core.h +++ b/drivers/mmc/core/core.h @@ -94,8 +94,8 @@ int mmc_hs400_to_hs200(struct mmc_card *card); void mmc_register_pm_notifier(struct mmc_host *host); void mmc_unregister_pm_notifier(struct mmc_host *host); #else -static void mmc_register_pm_notifier(struct mmc_host *host) { } -static void mmc_unregister_pm_notifier(struct mmc_host *host) { } +static inline void mmc_register_pm_notifier(struct mmc_host *host) { } +static inline void mmc_unregister_pm_notifier(struct mmc_host *host) { } #endif #endif