From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 963732FE045 for ; Wed, 19 Nov 2025 14:50:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763563803; cv=none; b=AZjN9b5bJKx56CIBZ+nRT2pJyS/KpOM/QcgsK2g7mlLf4ndDj8ZarlTnKc7miUXrX3hIZJcha6d7DaBLIFf6xPvu+v+LRBvLdmQY2tQL6CHqjzRF0eHezxYo3f3E0DaaOpKnAyG/4OWHwSzim0nx2R2o/GxpEE3VfG8BD6WDnT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763563803; c=relaxed/simple; bh=HjVeAHG/Rz5N3ImKGAxY2aZRi2InN+k/KqoJBc6ie7k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kvPchb7b5hU7VoYNu5nf6CXFgIj7xsZ4JeUpw1wsnMhkdkhTaBnuJYx/iUuOwFnPFraBWKA+/GuTZKNEEd6QMQQrAemGRM3F81XMQcwnqPGjhi3iZS88CNI9iOqgKDrACIf5nmlhG2V9yqCRQ0BtLMhP2Qk2zjyPc5F5jPVx4yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E1Qkt35w; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E1Qkt35w" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47755a7652eso46262975e9.0 for ; Wed, 19 Nov 2025 06:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763563800; x=1764168600; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=h5IwlyQmN7aEr+k0dKo1C91kTz/zASMriIrf+oh75Bc=; b=E1Qkt35wugFgiZgkg0t10rJso5K12YlKtqfoUHmR6BxWKQDod6UoRWfkM4EAatdWe1 7kjyJC21uz6F/f2ng7sk12bjfw2DkoNVvLF0BIuiiciGguMs4xuYEPZMVIb2p3GqC5bx ceQfm71EQLhd4ipkanucJvej+KiUC6gsYFB/zjaPqEUXynfLsS4Jnix9imzSRgUI0mjj fCFSoriGUTEYJ6po/IaJKEsAmYbbFRRldak7vVNKjJRw6XbjUtlmKBHgqgA62TF+5cdh q/vgammeYjwKLj6ETLogxSkpI7XfPOQ3XIoxJBuKAAQSVaoDBLYpXFhRzXrcf63+uF3G bTVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763563800; x=1764168600; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h5IwlyQmN7aEr+k0dKo1C91kTz/zASMriIrf+oh75Bc=; b=jOQTDuir5XJ62cEJ65eczNYf6w8MletuufK0Cc/OzvU8ALCKykI30VWeO/if4Jk+9h JfjwAQK9wUW2ailfnINKUXl/ihu0POe1ZvIJzvg7aNYiVGAi5/KKUlo0w0KwFWAX5S5z jv4msC6G8AYan3y986ds3DLW7LDiVHBxMeQh5In+WJbA975wOBiqy4tAeEOgTSs64/Ps +k700nRZHuKsTO2cU5n5GyIxxXuM5S9xglINDTJDdrg4AhRQWL3Dqj/qwJ+jDIHE9xVB 7Avp41LrT8JBNyvIzVnxyS239zMnvohPWiFneTIG4hc1trWVNjZ868bqZPCQlPEElRL5 ViyQ== X-Forwarded-Encrypted: i=1; AJvYcCVd1mrXF6ET6iIvyZJ7lpEyUou6N3XXwikyQ7dUxKuihpj4WlZaEub0c9nhdvzBxYS8JfJ78tdc8CzXh8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyONxCeXhk9C9vgzY+YcHhuarVFoXB0YupgqQoOcs0hpygamcen PFm2w/yQqihYzyhOCHQPsdpVcZKjyKDWL76yDpSB/d3Vwf+4ygxBMv8Hi1CgnEQDLQE= X-Gm-Gg: ASbGncuI7sW9wq8u54jT99vRIbQT0JeUgaJvOOHpWqHQuSuAXllvv3E3BL6VzOVBhBA Zrl/zKB4vn2cDwbaIb5jor5wBrs9IbjJKuD2cgQBRpViO2EmitGnu8QPSdXS8RjUk6ZozvBYYB/ 0XiNnKCczRdm/hmFXSNwtVhWMWJ+r6zPfudEvu8CdK0+g9s05aHAYWN5G6SWoMq8aPZpae3nm9W WR9hhLeAAuxQ1qxKNYt+GMGogOU7Pf6FmpP5VChpQEpr1cX+CD0oMMEtzzUE6TXg9ErwAC4LNew xiOoi9G4xwdBYCB3sDDLNq4wdayKFB2aaysUxQM2H7rmfZmXsSIgAREQLIN7x4ZwgqCqL+dLWDW 0si5W8pedgO16y2Y5LF8WTa71jMTj56f1VXGxueGQu5ILsTFRJ7LcDHOLfQG8ODGjpns9OMLDZ7 LMZcsATfAg6aL25p0XpqdVoOq2qEXf8vV28Rl1trCWWFhW9EpJbff/eG1JTojZDYvr66YE2smuS Q== X-Google-Smtp-Source: AGHT+IEd8UzBZRk6+xwZV/5zJBAvrlyTzFTI1kOuA2QzNhTIpZ27xlgt44WdoWaXyXgP9582F+kYUA== X-Received: by 2002:a05:600c:c177:b0:477:7975:30ea with SMTP id 5b1f17b1804b1-4778fea1336mr211048075e9.29.1763563799733; Wed, 19 Nov 2025 06:49:59 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:263d:925b:a11f:ae36? ([2a01:e0a:3d9:2080:263d:925b:a11f:ae36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b5ce849ddsm32017877f8f.14.2025.11.19.06.49.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 06:49:59 -0800 (PST) Message-ID: <782ebaf9-38d9-4695-b5af-3cf77118e282@linaro.org> Date: Wed, 19 Nov 2025 15:49:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support To: Claudiu , yoshihiro.shimoda.uh@renesas.com, vkoul@kernel.org, kishon@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, p.zabel@pengutronix.de Cc: linux-renesas-soc@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20251119120418.686224-1-claudiu.beznea.uj@bp.renesas.com> <20251119120418.686224-3-claudiu.beznea.uj@bp.renesas.com> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20251119120418.686224-3-claudiu.beznea.uj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/19/25 13:04, Claudiu wrote: > From: Claudiu Beznea > > The Renesas RZ/G3S supports a power saving mode where power to most of the > SoC components is turned off. The USB PHY is among these components. > Because of this the settings applied in driver probe need to be executed > also on resume path. On suspend path only reset signal need to be asserted. > Add suspend/resume support. > > Signed-off-by: Claudiu Beznea > --- > > Changes in v2: > - dropped the changes that were integrated in patch 1/2 > > drivers/phy/renesas/phy-rcar-gen3-usb2.c | 57 +++++++++++++++++------- > 1 file changed, 42 insertions(+), 15 deletions(-) > > diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c > index b9d5bb52e02c..3c063e4dea41 100644 > --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c > @@ -132,6 +132,7 @@ struct rcar_gen3_chan { > struct device *dev; /* platform_device's device */ > const struct rcar_gen3_phy_drv_data *phy_data; > struct extcon_dev *extcon; > + struct reset_control *rstc; > struct rcar_gen3_phy rphys[NUM_OF_PHYS]; > struct regulator *vbus; > struct work_struct work; > @@ -778,38 +779,24 @@ static void rcar_gen3_reset_assert(void *data) > static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel) > { > struct device *dev = channel->dev; > - struct reset_control *rstc; > int ret; > u32 val; > > if (!channel->phy_data->init_bus) > return 0; > > - rstc = devm_reset_control_array_get_shared(dev); > - if (IS_ERR(rstc)) > - return PTR_ERR(rstc); > - > ret = pm_runtime_resume_and_get(dev); > if (ret) > return ret; > > - ret = reset_control_deassert(rstc); > - if (ret) > - goto rpm_put; > - > - ret = devm_add_action_or_reset(dev, rcar_gen3_reset_assert, rstc); > - if (ret) > - goto rpm_put; > - > val = readl(channel->base + USB2_AHB_BUS_CTR); > val &= ~USB2_AHB_BUS_CTR_MBL_MASK; > val |= USB2_AHB_BUS_CTR_MBL_INCR4; > writel(val, channel->base + USB2_AHB_BUS_CTR); > > -rpm_put: > pm_runtime_put(dev); > > - return ret; > + return 0; > } > > static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev) > @@ -849,6 +836,18 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev) > } > } > > + channel->rstc = devm_reset_control_array_get_optional_shared(dev); > + if (IS_ERR(channel->rstc)) > + return PTR_ERR(channel->rstc); > + > + ret = reset_control_deassert(channel->rstc); > + if (ret) > + return ret; > + > + ret = devm_add_action_or_reset(dev, rcar_gen3_reset_assert, channel->rstc); > + if (ret) > + return ret; > + > /* > * devm_phy_create() will call pm_runtime_enable(&phy->dev); > * And then, phy-core will manage runtime pm for this device. > @@ -937,10 +936,38 @@ static void rcar_gen3_phy_usb2_remove(struct platform_device *pdev) > pm_runtime_disable(&pdev->dev); > }; > > +static int rcar_gen3_phy_usb2_suspend(struct device *dev) > +{ > + struct rcar_gen3_chan *channel = dev_get_drvdata(dev); > + > + return reset_control_assert(channel->rstc); > +} > + > +static int rcar_gen3_phy_usb2_resume(struct device *dev) > +{ > + struct rcar_gen3_chan *channel = dev_get_drvdata(dev); > + int ret; > + > + ret = reset_control_deassert(channel->rstc); > + if (ret) > + return ret; > + > + ret = rcar_gen3_phy_usb2_init_bus(channel); > + if (ret) > + reset_control_assert(channel->rstc); > + > + return ret; > +} > + > +static DEFINE_SIMPLE_DEV_PM_OPS(rcar_gen3_phy_usb2_pm_ops, > + rcar_gen3_phy_usb2_suspend, > + rcar_gen3_phy_usb2_resume); > + > static struct platform_driver rcar_gen3_phy_usb2_driver = { > .driver = { > .name = "phy_rcar_gen3_usb2", > .of_match_table = rcar_gen3_phy_usb2_match_table, > + .pm = pm_ptr(&rcar_gen3_phy_usb2_pm_ops), > }, > .probe = rcar_gen3_phy_usb2_probe, > .remove = rcar_gen3_phy_usb2_remove, Reviewed-by: Neil Armstrong