From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751324AbdAPMa0 (ORCPT ); Mon, 16 Jan 2017 07:30:26 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:58332 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750998AbdAPMaY (ORCPT ); Mon, 16 Jan 2017 07:30:24 -0500 Subject: Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table To: Chanwoo Choi , linux-kernel@vger.kernel.org References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <1484314449-10060-5-git-send-email-javier@osg.samsung.com> <587C6C36.5070606@samsung.com> Cc: Laxman Dewangan , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Lee Jones From: Javier Martinez Canillas Message-ID: <783013e0-1da8-3af8-a819-646eb25b9030@osg.samsung.com> Date: Mon, 16 Jan 2017 09:30:14 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <587C6C36.5070606@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Chanwoo, Thanks for the review. On 01/16/2017 03:46 AM, Chanwoo Choi wrote: > Hi, > > I think that this patch better to squash with patch3. > After applying the patch3, this driver doesn't use > the max77686_i2c_id table. > I usually prefer to separate each change in a different patch, AFAICT moving to use the .probe_new callback and removing the I2C id table are two different changes. I can squash if that's the correct approach though, I will let Lee decide. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America