From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CFAA2E88BB for ; Thu, 27 Nov 2025 11:06:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764241569; cv=none; b=BZU+KzJOOl3fMInKom7Le4RumNd9hkaWVmXR9Au32IbTnquLtkB0OebsDEXNQZfeq0gdlCR52HSpUP8jq+B/m+4jrxS9PEFxOxVlQVAC+1kR4AxNjYaJP6zOA+gpGZNUlzhPCuhjGrxgQrosImPea8e9akITmjvCJ5PAjgR9fVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764241569; c=relaxed/simple; bh=gErO8r2/jH1JEM6Wb/SziNZeqekYoVk2qJj9NHu1Dbc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PpGNGugPecLWQ7d0vG5kBbzKYnIocoTJ4gc3vwf+yKB5pR+iF3AtZkPHqtOd7moYbhFVLzsTk/ELU5S+TSxeWBEnaDHnEpmP3OB9tzpQ0xxCakTZTNQ6tNeZT1/DJTXL7Q9PATpgdK7uzXpeE3eZUClJhs31GkbBkHvOcp29wi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VVlBR9/l; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hUoL3Uqg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VVlBR9/l"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hUoL3Uqg" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ARA3aSw848530 for ; Thu, 27 Nov 2025 11:06:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dsM5B0ACxhRDHWXvfakmXYc8i5gMH4SHAT6VoxxH/Fc=; b=VVlBR9/l5YNDs+N6 1CGh2ohRqvDYEB537Y58T3oCOGA3g6gMddpeZw0a4Pm1rNld/NSblhMJkFaG/PLs vQ9xjlVdtooR0qI9gV+E4/1lksGm9fNAiDd7DZF9uUoHSZX7urm847rZVzRKqg/t BVc7iUJ2piZs1dw3w8DzsIWs5GR/TctO2X+oXyZPEYvC9dWiQ2MAeG9UUo65jVhU EzePBW/q7/pgFvh9whrRNTpGkbunVeWWHTrO+SYqyRCV7zQU8KMmKWaSneLqmPPg GAk6ZVqmep3HrVglgBFmh77qvee0mC9jO2UV7eS7y7hxw+FdfTjz0DyTVddoFVlE v8rX2Q== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apmjd85st-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Nov 2025 11:06:05 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee23b6b6fdso1608971cf.0 for ; Thu, 27 Nov 2025 03:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764241564; x=1764846364; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dsM5B0ACxhRDHWXvfakmXYc8i5gMH4SHAT6VoxxH/Fc=; b=hUoL3UqgfBckrGzjgMuYHRalahYGD0h9d2plK5h8UTiltdY1QJpcVpD7TwjbMMv5R0 zZaGC5tmmLLpMNDjzJPGsHB0XN6wKu+YFhgxnu4uQPNceUAiC3wK7wTQPGrgxq9halgp mbZVzB0mm4U/hSyp0YFWU/hitqNuw6roV945IL/i7DFheDPGzA1st40NnqsAYzQi/SoR dntKxhe8f4ZuaCCkyx7Xg3ebEWnZAb0YVvUGfoX3B5FJ+Gjxk8CkhlltjUe8LETj0z0I bRLJj1Iog8aDPW7bbt11XwccBy68N7+Zd+QCMHalrISzqybAQQhfOnSznjOjK6wbjV4H 7/Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764241564; x=1764846364; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dsM5B0ACxhRDHWXvfakmXYc8i5gMH4SHAT6VoxxH/Fc=; b=tUqWhKoquENwJIk7GX1/HSRJcDlCphMjcdU3roRjXe+gVq9wxnq/r1YCCFRfsrwPU3 kPmzY3lpxaXFELttuXFoozQLBs/OGYg45JQBCkRzhAM8ducvNjO7cYfEY8cFkwpd5v8c pPZDVkQInpi+Fb588UH1RBD//ZSSTgkSMGN8xmaGdI4eiJtExmplh4v2hSBU9Y1hGgYc mqPQlfhZQixMRMajFabG3zM6+xG3WUH1OsKkWoUKLRsfZNpBOMuvh4kvflJn5gpK97fh o5sJb5X0qtC6AeY1YPPulA4T26btsNDZKDhk4upoUWGYMu/q5ho0Q+3+E0DAL748BAcT ++Ww== X-Forwarded-Encrypted: i=1; AJvYcCXUZLqsy1iMjlWkSNgT1qEQyIGUOii5ziTGqihL8qQSf7CxFu2BaBdt/AkvdjOhsN6C902HnywVuOYFtQQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyjKn863ThMJBi+DfxHwBEVMmGllysl7UKyg7d/wtvM5wX0zj3H RY/hvmY8NLISgAb7ytDsbCSqYkrEHDMmkzgPvJUfscdUzycDd1QNsIkJMCQL+jd1IJQQ/WdiESJ Oh2Ey2Y9k4sN3XGgU5elo4OPMsE89/4AFhWB0xSNi6Y7L+isv2UdKR3EOyKV/u7sjrQo= X-Gm-Gg: ASbGncuIfuYLduj3ZogLBMWySoyZBjDwxZiH3ujmS5h0WhGWaqKX+etrMIqboon6jxf wlMcZc/03Tco7zKhvbnAlVikIN0SyME5QiV1NYGWavNKa/kFza/KJmWxn3o09a+xhMewm6kmCRY rJShYgF+jpfet8YsBZ4Wo6DcnhpZOE3i8xpC5xNUPmEhcOQlMkkDmn8dKHcM2IQsFpRX3266T/I rTp1K1eKuYNvBS0RNJ6nnFby5G49XwfZmy5dnGn1lw3f0D7LL7emwom0G8byczzA3tcuguKSGxH Bv+FRhBd1Vq/RAwTD/dINlCvMRQOdMso9tt/BtUT3svFQheRqWqT14IbjBRLUNMJYPuZ7GjOtCO Od2sTEmwJ272A1iGWhuumRHPOKoShSTB2f8ws5gD6A42yioLSreu/HPeo7LXpk2lJk0M= X-Received: by 2002:ac8:7c48:0:b0:4ee:1e95:af63 with SMTP id d75a77b69052e-4ee5894e4camr234809411cf.10.1764241564335; Thu, 27 Nov 2025 03:06:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQ2C4T/zkTEcfcKbF3Z1M8/NcZ0UR/ptn/bgi8R2SS+xmUzOkuSJbfZlY91sr/2UxXeGziwg== X-Received: by 2002:ac8:7c48:0:b0:4ee:1e95:af63 with SMTP id d75a77b69052e-4ee5894e4camr234809031cf.10.1764241563904; Thu, 27 Nov 2025 03:06:03 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64750a90d14sm1277518a12.10.2025.11.27.03.06.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 03:06:02 -0800 (PST) Message-ID: <78307922-3922-40b7-be89-5c2bacbdffdf@oss.qualcomm.com> Date: Thu, 27 Nov 2025 12:06:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] pinctrl: qcom: sa8775p-lpass-lpi: Add SA8775P LPASS pinctrl To: Mohammad Rafi Shaik , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com, ajay.nandam@oss.qualcomm.com, ravi.hothi@oss.qualcomm.com References: <20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com> <20251116171656.3105461-3-mohammad.rafi.shaik@oss.qualcomm.com> <3c0e994c-7484-432f-b3b1-bc7523d27242@oss.qualcomm.com> <0b7dccfe-ac31-4d75-840e-96d8ddd66fdc@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <0b7dccfe-ac31-4d75-840e-96d8ddd66fdc@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: Hwvg7XuUZ12rRpnZY525LEqQctJRuf01 X-Proofpoint-ORIG-GUID: Hwvg7XuUZ12rRpnZY525LEqQctJRuf01 X-Authority-Analysis: v=2.4 cv=OPcqHCaB c=1 sm=1 tr=0 ts=6928309d cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=PbRpZkKeZxfV5sauP3EA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI3MDA4MSBTYWx0ZWRfX2/ycPjewIMNp XWFoLafz5TxzimKoJcS/zPhIj3USBnBeqvKmEh9YrUimLymlSiuAu5dUsUGlwcvn2BtpD1wT5Pl sDp7c1j+jv2k00EwDayBqUOXKaHlzuDc82DplX1HZw0YPJRDZIvZxZGNW8GnDKOFL+Mg8b9afc7 e4jPHqIlUxEmuOtHOdlvE4KuLrNTTCvNhccyPuTAaPJBWr49qryRMNh32FWDRQA1MQrooWb+jPK lm/EY+SnxWlgfcF6lHm7BPfBoWMyoocjE6By872t7hiCPOAUO6kEctmvl5P8C7iZRFtrqu1bzkE LtgmZxZ6waj8SHfrNxDT0fh8LdefOPgnLPZ4/oo+c+Hs7yHFDQ5Y6V38vuwMIQa1PCmyuGL99bL du0TVAyjVoTMXiMb3KvLbBmCoYbokg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511270081 On 11/26/25 6:31 AM, Mohammad Rafi Shaik wrote: > > > On 11/17/2025 6:47 PM, Konrad Dybcio wrote: >> On 11/16/25 6:16 PM, Mohammad Rafi Shaik wrote: >>> Add pin control support for Low Power Audio SubSystem (LPASS) >>> of Qualcomm SA8775P SoC. >>> >>> Signed-off-by: Mohammad Rafi Shaik >>> --- >> >> [...] >> >> >>> +static const struct lpi_pingroup sa8775p_groups[] = { >>> +    LPI_PINGROUP(0, 0, swr_tx_clk, qua_mi2s_sclk, _, _), >>> +    LPI_PINGROUP(1, 2, swr_tx_data, qua_mi2s_ws, _, _), >>> +    LPI_PINGROUP(2, 4, swr_tx_data, qua_mi2s_data, _, _), >>> +    LPI_PINGROUP(3, 8, swr_rx_clk, qua_mi2s_data, _, _), >>> +    LPI_PINGROUP(4, 10, swr_rx_data, qua_mi2s_data, _, _), >>> +    LPI_PINGROUP(5, 12, swr_rx_data, ext_mclk1_c, qua_mi2s_data, _), >>> +    LPI_PINGROUP(6, LPI_NO_SLEW, dmic1_clk, i2s1_clk, _, _), >>> +    LPI_PINGROUP(7, LPI_NO_SLEW, dmic1_data, i2s1_ws, _, _), >>> +    LPI_PINGROUP(8, LPI_NO_SLEW, dmic2_clk, i2s1_data, _, _), >>> +    LPI_PINGROUP(9, LPI_NO_SLEW, dmic2_data, i2s1_data, ext_mclk1_b, _), >>> +    LPI_PINGROUP(10, 16, i2s2_clk, wsa_swr_clk, _, _), >>> +    LPI_PINGROUP(11, 18, i2s2_ws, wsa_swr_data, _, _), >>> +    LPI_PINGROUP(12, LPI_NO_SLEW, dmic3_clk, i2s4_clk, _, _), >>> +    LPI_PINGROUP(13, LPI_NO_SLEW, dmic3_data, i2s4_ws, ext_mclk1_a, _), >>> +    LPI_PINGROUP(14, 6, swr_tx_data, ext_mclk1_d, _, _), >>> +    LPI_PINGROUP(15, 20, i2s2_data, wsa2_swr_clk, _, _), >>> +    LPI_PINGROUP(16, 21, i2s2_data, wsa2_swr_data, _, _), >> >> The max slew rate value (shift) here defined in the register map is 18 for >> this platform >> > > ACK, will update proper rates. It (although generally very unlikely) may be that the register map is missing something. You probably know the hardware better, or know who to ask. Please check that. Konrad