From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 756CEFA372B for ; Thu, 17 Oct 2019 05:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57C6D2067B for ; Thu, 17 Oct 2019 05:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404253AbfJQFqn (ORCPT ); Thu, 17 Oct 2019 01:46:43 -0400 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:35594 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727236AbfJQFqn (ORCPT ); Thu, 17 Oct 2019 01:46:43 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R441e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=wenyang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0TfHpT3B_1571291198; Received: from IT-C02W23QPG8WN.local(mailfrom:wenyang@linux.alibaba.com fp:SMTPD_---0TfHpT3B_1571291198) by smtp.aliyun-inc.com(127.0.0.1); Thu, 17 Oct 2019 13:46:38 +0800 Subject: Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by_name To: David Miller Cc: linus.walleij@linaro.org, xlpang@linux.alibaba.com, zhiche.yy@alibaba-inc.com, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190929070047.2515-1-wenyang@linux.alibaba.com> <20191001.100341.1797056721948216269.davem@davemloft.net> From: Wen Yang Message-ID: <7835e7c0-01e5-770e-788e-5f06f9ddf35e@linux.alibaba.com> Date: Thu, 17 Oct 2019 13:46:38 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191001.100341.1797056721948216269.davem@davemloft.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/2 1:03 上午, David Miller wrote: > From: Wen Yang > Date: Sun, 29 Sep 2019 15:00:47 +0800 > >> of_node_put needs to be called when the device node which is got >> from of_get_child_by_name finished using. >> irq_domain_add_linear() also calls of_node_get() to increase refcount, >> so irq_domain will not be affected when it is released. >> >> fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") >> Signed-off-by: Wen Yang > > Please capitalize Fixes:, seriously I am very curious where did you > learned to specify the fixes tag non-capitalized? > > Patch applied, t hanks. > Thank you for your comments. We checked the code repository and found that both ‘Fixes’ and ‘fixes’ are being used, such as: commit a53651ec93a8d7ab5b26c5390e0c389048b4b4b6 … net: ena: don't wake up tx queue when down … fixes: 1738cd3ed342 (net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)) … And, commit 1df379924304b687263942452836db1d725155df … clk: consoldiate the __clk_get_hw() declarations … Fixes: 59fcdce425b7 ("clk: Remove ifdef for COMMON_CLK in clk-provider.h") fixes: 73e0e496afda ("clkdev: Always allocate a struct clk and call __clk_get() w/ CCF") … It is also found that the sha1 following ‘Fixes:’ requires at least 12 digits. So we plan to modify the checkpatch.pl script to check for these issues. diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a85d719..ddcd2d0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2925,7 +2925,7 @@ sub process { } # check for invalid commit id - if ($in_commit_log && $line =~ /(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) { + if ($in_commit_log && $line =~ /(\bcommit)\s+([0-9a-f]{6,40})\b/i) { my $id; my $description; ($id, $description) = git_commit_info($2, undef, undef); @@ -2935,6 +2935,25 @@ sub process { } } +# check for fixes tag + if ($in_commit_log && $line =~ /(^fixes:)\s+([0-9a-f]{6,40})\b/i) { + my $id; + my $description; + ($id, $description) = git_commit_info($2, undef, undef); + if (!defined($id)) { + WARN("UNKNOWN_COMMIT_ID", + "Unknown commit id '$2', maybe rebased or not pulled?\n" . $herecurr); + } + if ($1 ne "Fixes") { + WARN("FIXES_TAG_STYLE", + "The fixes tag should be capitalized (Fixes:).\n" . $hereprev); + } + if (length($2) < 12) { + WARN("FIXES_TAG_STYLE", + "SHA1 should be at least 12 digits long.\n" . $hereprev); + } + } + # ignore non-hunk lines and lines being removed next if (!$hunk_line || $line =~ /^-/); -- Best wishes, Wen Yang