From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B58142E018 for ; Wed, 1 Jul 2026 11:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782903777; cv=none; b=aBQkW8XlGofRb3Qa1vvx17D01RxZjYoRvuboXgJs/AeZI0/IAth8mTbOQfW4H5DG9fBaj8jnSsLAQ5Yqqk/NxaswN1gHDblY8qdiZl6zGpfLrPFsDA1qsHOD8Rcn6CYu842TQzsY9UvFG0p4Yp72DJ/5g7FC3UxKMPJwz619o0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782903777; c=relaxed/simple; bh=u0T30LeQQOSUGxQo0pfn/k3f7dJ5+eUKOz5i6sCaeeQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dLigc8kmnXyqoWLoc2WNilo2Ox6kFaxmg1vHKFWQaqz8bPhlB0NEPTg+CndJEp3p5x7LNEUQTnTMyMfbCt13MLzj8nHy4Sr3Xek+Og5s7Hmt+CMyDGYORiPMWpePbwBiFD6xSILqTl4GaxatugTI5U9yZh/r8rb0iIad5tIy5h8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j+HzF7h+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ToV2CpcL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j+HzF7h+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ToV2CpcL" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 661A8R5m761262 for ; Wed, 1 Jul 2026 11:02:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kvGYuMepORYbrJ/S14Iw5fW/K4H18R5Nk/vIBtqYV50=; b=j+HzF7h+yWvHFJaj xP6V7MnB5UqGZJ5SKxdy/vefIya+F/K3wbABeyLLp6iW3vizyFNsUHhHAD3nD+r/ OyXRPuChpj4NhhyEVBEaJhTRn23BrkSBuTbrXB+frWPGvqpg4zn8bsaG1GuuGUYS jIeyribqpUAAdzgBV9Q0j8h8rgDnLOTXRg3Y+XFYRMLVSgy3DiW3DM6NxD9gz5ov zo3hFyHTk+BLne3oti/HdwiTPyVcXhUgwD5meYkElEey3cX9kDHsp4GL2WLV+z/e BGhsYj0RvHoBOdKdqJJVxgM/0AG77l95u5LzLouix7V75x0Qz1lZ1pbDw9CnuSa6 LrWx4w== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4kgw3pge-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Jul 2026 11:02:55 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-738be9df36fso15834137.1 for ; Wed, 01 Jul 2026 04:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782903774; x=1783508574; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kvGYuMepORYbrJ/S14Iw5fW/K4H18R5Nk/vIBtqYV50=; b=ToV2CpcLZxHAhWqG4Ftx1TvD5dGJ5hX8VFJnWc5B2Pjq4ilj6glvHC5r4VtQkbhG3/ DVufC4vrNzeVk6ON7OevOrdYJXPN8nPTBjmQp+ym5tGCOQIKJRw4H6Ss7F1ItnP35xEL 2RQo6FQ1TtWdoc/TjA+Viu5vGRvg3Gg1P50CQAxo32WBQYCAYikfDa4eLNHSKnmQo9D1 o08iCzH2Sro0iiPPVWzKzWeKtdXG5JfJImSvqjKsOfviGowYkA05jV+ClOL1O/qswPns 4ahtXlLaq1g7BaXYGzIIgw9SG+GY/mgQx+6idVx9kTRVepm8WWr/EUrySelHX3i5wyZg 4kHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782903774; x=1783508574; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kvGYuMepORYbrJ/S14Iw5fW/K4H18R5Nk/vIBtqYV50=; b=hOPJlh6WORLWcEiBRijrgndpltH4r+4ilc7PkV+X972y9hOyMLRfY6NIrNBeMXD5aa AGTZK4VmSL8uyNyEBMe2mtaWUprdMSY+XyYQHP0KNih923/I40BBFKYjHsbyvvDkarBW /tKsVFBxDHhNMSKnF5jOOuOss1UGj27AY3JSBFPweRv0RmQntSG3hnFY/HQD4LcASLn6 sjUILev2/Pll6A22Qv7EIGoBdkkaef6USMYSD58wxdjn3xCSxO8KDJhPNdMEf4wb9/Ej x6sLwLuXiIJeFGt/tcJALMVF/GnvvYqIiQ5amxg6rThP6vi7xaJzwoVBL9j6gRNg8XP7 bYwg== X-Forwarded-Encrypted: i=1; AHgh+Rq7eq26/naqUHuzWCNAf8qg05i0L/VoVCN5yk8qSJ3aLSHifSxrCeWPnecRZqrZdjQY89jT7B1CHUqKopg=@vger.kernel.org X-Gm-Message-State: AOJu0YyQe3hy+ZRAbvhDdcrI8liIjurp5ppY5CkWlwpvmQbNMw0BsdgH xR4ECjxnAxXZFwCz2QZT08uElzja54ykAZxb5TuWthiQHYMkTMkRa54yryTUv/OtfUjdZABq8mS K6fDWJyvKWdOis/WDAb0i/8o6Zm9kRhVPtqwUkYhnioE7i7eEPxFc5FS3rLJJ2i/UQY4= X-Gm-Gg: AfdE7clMulqr9U3xDFmhOen2OPnFz9sU0sL386cF8Kb1INxIiZ5fCtbBC/Un/vy7brZ xvFJgqP2vhq8gd0+vW3ua6U0MRhOiN6ZkidRtVWaODM7J78ejIoSOIJ8aFbHhqyvekg89l1yVd4 6eAIhb7gV0xE/5iIq/w9aiTEGQ+jVFnOWxJ42FTn2zMrmomM7V7ANLvtYpa78qrBq24kJw2Mb0o B2xgGAorF4Gkx4M64eSJ0Hq0DWZ4SdllaQxLdM5N2XuHSB+FbrwigVL0KvyGZqp6hnvVwZbjLGH gwGNj9+PYv5SMQIm1EioaKOEwOAA7AbJO1v6ezn1158L7RMA5wxPHhCXdUGBmaxc7chxe5CxBJO 46WlojkTBkleHXQxbkgqwM4v5eAp8vtwfuJc= X-Received: by 2002:a05:6102:f98:b0:739:97bf:9180 with SMTP id ada2fe7eead31-73daa8b28f0mr87665137.8.1782903774612; Wed, 01 Jul 2026 04:02:54 -0700 (PDT) X-Received: by 2002:a05:6102:f98:b0:739:97bf:9180 with SMTP id ada2fe7eead31-73daa8b28f0mr87636137.8.1782903774186; Wed, 01 Jul 2026 04:02:54 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288dba380sm256467966b.26.2026.07.01.04.02.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:02:51 -0700 (PDT) Message-ID: <7838f7c3-0f38-4e93-a9c1-88f387e78ca9@oss.qualcomm.com> Date: Wed, 1 Jul 2026 13:02:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/5] dt-bindings: arm: coresight-tnoc: Add standalone qcom,coresight-agtnoc compatible To: Jie Gan , Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Abel Vesa , Alexander Shishkin , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260701-fix-tracenoc-probe-issue-v4-0-aefab449a470@oss.qualcomm.com> <20260701-fix-tracenoc-probe-issue-v4-1-aefab449a470@oss.qualcomm.com> <20260701-stirring-piculet-of-vastness-a361e5@quoll> <4117c406-0d75-4eb1-842e-1d346b7fbf99@oss.qualcomm.com> <9aa63427-ba41-436d-ab19-a533082d336a@kernel.org> <62ac6887-1551-490b-b42b-2661d7152734@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <62ac6887-1551-490b-b42b-2661d7152734@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Co2PtH4D c=1 sm=1 tr=0 ts=6a44f3df cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=TUQMdDBI74RIm7-lXFYA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-ORIG-GUID: 5C1dYHdikLFAfGIsqBtHOC5DKgkDyq9F X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAxMDExNiBTYWx0ZWRfXzda1QzQwXPFF 8OlLsh2wwkii2j5EdHZxcySSROEgFgiiIFmm9P50TJ3RszAQMTN2V8IOWGmJoJ3KL2hqQmnozVv 4SEHramXJOeeToRAQzB9VD/Utj469OE= X-Proofpoint-GUID: 5C1dYHdikLFAfGIsqBtHOC5DKgkDyq9F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAxMDExNiBTYWx0ZWRfXwfRBFCd9DHfP ztkCnMUXGr0H8IBpI5TEMxn1djKL78yabB0wO8e25WBEBxRztnZEkBKeg17BPCh6RVs8aT5Al7Q oNYs1jVrxAwAW4rz4+209GzkuBsl0x+fnTvx8okl2jFJnsr7UfGLlFtkyTQyTXMR/hfycsH+4mV GkMCi/JRm9ZLWKAu25Lc0TG73aeSfPJQ5ZXALYK9YHd7NClcOuA3FXUygYxOJEwWyQBEqJAVbNK nUJ2msIOcdCA/V/wsNWcg1OYF8STz7DD3b+dt8i7C3IX/a7sCndx0qqsUphuEDezrGTGqrtY5n6 GovTXQTzP31/40pufWzDr5X+nLbZl1/xbICqpgzbFziQ27662W62cnjwgMZy/QqrrQhzDaibExS h4lRsaGcsCfcwZkKeuFGg/iWFfGPNkKUepZipuc/6L/g/wNEVTI3IOOaqUeOKkOSxmcGAeRPM/I srnXZGJl2wHyfm1cXdg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-01_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607010116 On 7/1/26 9:31 AM, Jie Gan wrote: > > > On 7/1/2026 3:26 PM, Krzysztof Kozlowski wrote: >> On 01/07/2026 09:16, Jie Gan wrote: >>> >>> >>> On 7/1/2026 2:57 PM, Krzysztof Kozlowski wrote: >>>> On Wed, Jul 01, 2026 at 09:53:41AM +0800, Jie Gan wrote: >>>>> The TNOC compatible previously only allowed the two-string AMBA form >>>>> "qcom,coresight-tnoc", "arm,primecell", which forces the device onto the >>>>> AMBA bus. >>>>> >>>>> Convert the compatible to a oneOf and add a standalone >>>>> "qcom,coresight-agtnoc" compatible alongside the existing AMBA form. The >>>>> standalone string carries no "arm,primecell" entry, so the device is >>>>> created on the platform bus instead of the AMBA bus. [...] >>> AMBA primecell identification. The purpose of the new compatible is to >>> clearly distinguish this platform-specific case from the standard >>> AMBA-based implementation. Or shall I re-use the existing compatible >>> "qcom,coresight-tnoc" as platform standalone compatible? >>> >>> We already have a similar pattern for the interconnect TraceNoC device, >>> which uses the platform-specific compatible string qcom,coresight-itnoc. >> I do not see there a fake, duplicated compatible for the same device. >> Can you elaborate how is that relevant? > > Will fix it by removing AMBA related description. > > Shall I update the clock name from apb_pclk to apb as a platform device? Why? Konrad