From: Colin Ian King <colin.king@canonical.com>
To: Joe Perches <joe@perches.com>, Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: storage: isd200: fix spelling mistake "removeable" -> "removable"
Date: Mon, 10 Aug 2020 18:26:16 +0100 [thread overview]
Message-ID: <783b3e8a-40b1-379d-ae22-9b1fd9c50684@canonical.com> (raw)
In-Reply-To: <ca88752c86bf8a42f9aa56b69df585542ea26622.camel@perches.com>
On 10/08/2020 18:14, Joe Perches wrote:
> On Mon, 2020-08-10 at 10:25 -0400, Alan Stern wrote:
>> On Mon, Aug 10, 2020 at 09:32:11AM +0100, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> There is a spelling mistake in a usb_stor_dbg debug message. Fix it.
>
> This is an alternate spelling in a few dictionaries.
> Is this an acceptable Briticism?
> If so, I suggest no change.
I was keeping it consistent with all the other occurrences of this word
in kernel messages.
>
>>> diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
> []
>>> @@ -1383,7 +1383,7 @@ static int isd200_scsi_to_ata(struct scsi_cmnd *srb, struct us_data *us,
>>> ATA_CMD_MEDIA_LOCK : ATA_CMD_MEDIA_UNLOCK;
>>> isd200_srb_set_bufflen(srb, 0);
>>> } else {
>>> - usb_stor_dbg(us, " Not removeable media, just report okay\n");
>>> + usb_stor_dbg(us, " Not removable media, just report okay\n");
>>> srb->result = SAM_STAT_GOOD;
>>> sendToTransport = 0;
>>> }
>>> --
>>
>> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
prev parent reply other threads:[~2020-08-10 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 8:32 Colin King
2020-08-10 14:25 ` Alan Stern
2020-08-10 17:14 ` Joe Perches
2020-08-10 17:26 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=783b3e8a-40b1-379d-ae22-9b1fd9c50684@canonical.com \
--to=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®