From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=8lgJ=7H=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA05C433DF
	for <linux-kernel@archiver.kernel.org>; Mon, 25 May 2020 15:15:46 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 63E7520878
	for <linux-kernel@archiver.kernel.org>; Mon, 25 May 2020 15:15:46 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="HOrHzc54"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2391147AbgEYPPp (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 25 May 2020 11:15:45 -0400
Received: from mout.web.de ([212.227.15.3]:40297 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2391078AbgEYPPp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 25 May 2020 11:15:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de;
        s=dbaedf251592; t=1590419719;
        bh=G5ZC3hkiNNLw8VXok8dxp9CrF/rmQS0pYa2GIW0XHA4=;
        h=X-UI-Sender-Class:To:Cc:Subject:From:Date;
        b=HOrHzc547fsb2vvr8FqdPFbSW/3M/2qQXSazoDA+lLhLkEv7cG2D5jVoaFfDUI0Uk
         jz/wFYa0Ut1ViWxrvs2Xj0AfAtlkvfV5eloAR0hU0fO7b2JkWQ6pH8Q9QbfagXYeZ7
         KjgXdtHGWhq70RA68H1KfOA0Vh96hfvgz/hfyCLU=
X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9
Received: from [192.168.1.2] ([93.135.186.124]) by smtp.web.de (mrweb003
 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MPpD8-1jh6hw3hMg-0052ic; Mon, 25
 May 2020 17:15:19 +0200
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>, linux-media@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, Kangjie Lu <kjlu@umn.edu>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2] media: coda: Fix runtime PM imbalance in coda_probe()
From:   Markus Elfring <Markus.Elfring@web.de>
Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata=
 mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8
 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt
 mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2
 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp
 YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY
 GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs
 rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU
 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv
 jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX
 BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm
 cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9
 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx
 g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar
 OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+
 CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR
 LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2
 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob
 kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w
 i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv
 g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI
 q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX
 NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw
 nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25
 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu
 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC
 wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r
 riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3
 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG
 fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/
 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota
 xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie
 qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF
 Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA
 Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m
 +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY
 hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL
 /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m
 tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA
 qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc
 Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf
 x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY
 pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE=
Message-ID: <783be816-9e46-057c-47e6-ccc26abfe1a8@web.de>
Date:   Mon, 25 May 2020 17:15:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: quoted-printable
X-Provags-ID: V03:K1:zsQZJ5ssGoBfiMMZSCDKzioMzQ8k9YCM+wz0RmYbQ5U5bw0BbUk
 vhtOYyheQKKUxJKfMB5siZmCpifiwQ0fLGHOXGDVuIkUfT2QxlwlyKJduu2sxb0t0ztBdbR
 C9TM201czh9lXNMB8M1b75VoYT0fdpyeFR56PrNmwtEGp4CL3tcbUis8YFXY24EbAWfjHq9
 RZTEZJcEiu2f4NEQGZpUw==
X-UI-Out-Filterresults: notjunk:1;V03:K0:wOa/2wGkpk4=:hnxn41nOUEdGWV1nsM22L3
 zv0ColYGWRfsjK6AYI6lnxnmPe6AajgI6PE2H0Jdt1AbKGCEGd3BeuNC708AlmeYJhhMWoK3m
 iGn+gdSJGraw/psFdsBtX4heNiVpWAyUeLbuvoSO68yub4XXHLkGPI4IcSkA+5tW3C041W4Yc
 1kLENjTUCzNayqnmMyngsNccA/ofK7S+2F+V402yk7hgX/nwFFd14u1Wy7wLpuVlXfBODyxag
 vUxQxDMayhWFpsHFgvTfcZ4eif5dthkwgF62dXTLHcn49mNm78l+CbDgERusraLClWF6UBIfr
 U3NWAVHERQyxC+eG3l7lj2MvRQVz8OXcC+ZUwu3MadvU0CLeSIzSYXpprWmfUgJGEvtWn+LD7
 0mD8PnywndQGJzaL63HcmjiPKFvYsJLfgAhTQXnlSR6h4EWwu/rdoJLeXlxuvTEE9d/PMUS3B
 +BDgurwQE/MQ2tPxPT9r5WcUs/A1SQM+rgftegHqMHpoWEGOkOHeQ1mVrxkl/kJE2BfdLW3T6
 duLmRIEu/Oj+kb5a3QArnwS6iCLB8hIeqGylgLi811JJdpLWAZIhI5/neDYRNaOhPjac0NynR
 FVFL5Cl3qyBbx4BbN86xtgtX+nI/9QDMLs2UtJrfMinX0tFOoMdxz+e5Mk2IfcxQuKxk/kjeq
 oJ0H5zy9Yos8oeSrYGxooixmJuvFez+i6DCUx2smV4lXobFWYFFEAzJu95Kz7W/DaOjTmAOa6
 udq66fZulk9Pc7str2WXGbctL3FUkSFQZ3wbP3rjHWvG/Ir2Jd3UY1k24bdGjH8VreQ9/GI36
 EpNpYoSXclOXYV7fhQB1RAQPvSerXs025FYhcwyIY6qYn/qR4OP8bQLIR8FH8YSimMymnrPUc
 xrayjCGrbB7j+p7trop3bR54rKb93vC/dQwa38IaVJqHipWUPkttWZx1Q4LBeIteibnPMcUeD
 fpMe36E1bhrCjlC5wl7gJeG1mmdmUrHE7OK5w5HeBZ/X31Z5/R/38uUIDYtIddOJVaiYqf8hn
 v1q5+YuN5LDtLOKc/CIZ/3fHTeuN0i3aWz3oOrSO8EtoWMNOcj+M4+7lG6OptP6pXJLu7QeS5
 KbXMduESZgzQKWSz13ZuZ51veJrf/9Z1EpanBhAVMD0gsCLfaYyc1Cd2L2qaTLPo6I9/5kwhK
 iWTnIK7wN4oq/9wZuoe7xfTOcp61qA6cdfB8E0GRV76Qp6R/Jw2CZUQ71GhzDap2Iv9sP5H5i
 PQ+DEbMqRBwxJ4l/k
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> When coda_firmware_request() returns an error code,
> a pairing runtime PM usage counter decrement is needed
> to keep the counter balanced.

* I suggest to add an imperative wording.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/=
Documentation/process/submitting-patches.rst?id=3D9cb1fd0efd195590b828b9b8=
65421ad345a4a145#n151

* Would you like to add the tag =E2=80=9CFixes=E2=80=9D to the commit mess=
age?


> Changelog:

I propose to omit this line.


> ---
>  drivers/media/platform/coda/coda-common.c | 2 ++

I find it nicer to replace the triple dashes before this diffstat
by a blank line.

Regards,
Markus