From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754600AbdBVJ3s (ORCPT ); Wed, 22 Feb 2017 04:29:48 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:41272 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754509AbdBVJ3g (ORCPT ); Wed, 22 Feb 2017 04:29:36 -0500 X-AuditID: cbfec7ef-f79d26d00000420c-c5-58ad59fd08c6 Subject: Re: [PATCH v5 3/3] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt To: Thibault Saunier , linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab , Marek Szyprowski , Kukjin Kim , Mauro Carvalho Chehab , Nicolas Dufresne , Andi Shyti , linux-media@vger.kernel.org, Shuah Khan , Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Inki Dae , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, Ulf Hansson , Jeongtae Park , Kyungmin Park , Kamil Debski From: Andrzej Hajda Message-id: <78444dcd-169f-0c16-0e09-6b71d1a502b2@samsung.com> Date: Wed, 22 Feb 2017 10:29:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <20170221192059.29745-4-thibault.saunier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRzGe89l52w1OS2rF82MQURRphD1RhpJWeeDH4wCZ1/skKclOatN I4PKC5p5R81rpZYo2oayrTnFonSlImW1aQk6w3VvMvPezZo7Gn57Hv6/h//7/HlpXPaB9KFj 4xN4dTwXJxdJCNOzHy92zEfpFIF5pRhqsXwkUeFIAYGcY1oMWXT9GCrvvk6ifMc3HPX1NVPo eaqTQnrHAImsbbdEKKf5AYnK+h5hSGcZplCd/jeGRmovoLYpuwh1Ot3Rm1PjBJp8XIijLl3k AW/WPFwLWH3jDRE7NNAuYg2111hj/jDF6ieGSTbP2AjYSf1G1mZJoSLEJyTBMXxc7EVevXP/ ScmZ56Yd57+svDQw30MmgwFxFhDTkNkFh95ZSUGvgy/tTaIsIKFlTB2ArqcpuGAm3cbwllhK jH+uJP9TTd/nKMF8BLCt/baHWsPw8OVoj2hBezORcOZNOrEA4YyDhPezkvGFgYjZCv8YBj2Q lNkPKx9OgwVNMJvhRKvWw6xlFND8NmeRWQ3niuyeBWLmMCy33fPwOBMIy4o7MUH7Q4N2zPNu yNTQ8I6r3w3RbuMH9Y9xocIheL/GsVhnDfzaZaQEvQFai7IJIZsN4ER+NyWYYgDnx8sW0/tg Z9crUtjmBQtNpbiwQAozM2QCwsKiT6OLVw2Fv0d/YsKJ+gEsafpLFQD/imWFKpaVqFhWohrg jcCbT9SolLwmKEDDqTSJ8cqAU+dUeuD+fL3zXS4z+JB2vAMwNJCvkmaGaRUykruoSVJ1AEjj cm9pdLhOIZPGcEmXefW5aHViHK/pAL40IV8vfVhti5QxSi6BP8vz53n10hSjxT7JINE8N00o He/CBv22pG1qrm6tqGzfo6qq0tp1weKGeNfu9LArSUe6Q1scmDPBdtdVOde6OTCnXn7U8eJ9 kI7rP131JGvWGFuS3qtzPYr4NZv7ZSibG8086B9S5XsDM6zI3VvToPALyfB5HaW8mjbtFbQ9 0+vAjDX8mLI+2pSq/CYnNGe4oG24WsP9A6906FV4AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42I5/e/4FV2GqLURBv2PdSy2H3nGajHp/gQW izdv1zBZHFl7lcli5ol2Vov+x6+ZLc6f38BucbbpDbvFpsfXWC0u75rDZtGzYSurxYzz+5gs 1h65y26xbNMfJov7Swotdn25x2Zx+A1Q69QvH1gsPh+YxGxxfG24g4jHjrtLGD02repk87hz bQ+bx+Yl9R5b+u+ye2z6dJfVo2/LKkaPz5vkPK4caWQP4Ixys8lITUxJLVJIzUvOT8nMS7dV Cg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8bZbboFL7krrv07ydrA eI2zi5GTQ0LAROLDi9msELaYxIV769m6GLk4hASWMEpMW7CNEcJ5xijxcd9HZpAqYYFUiQuP TrKB2CIC4RLH7jVCdVxllJh7/QsriMMs8JRVYs+D3YwgVWwCmhJ/N98E6+AVsJOYvfcrWJxF QFXi0841YFNFBSIk5j9dxQRRIyjxY/I9FhCbU8BNYuaVxUD1HEBD9STuX9QCCTMLyEtsXvOW eQKjwCwkHbMQqmYhqVrAyLyKUSS1tDg3PbfYSK84Mbe4NC9dLzk/dxMjMP63Hfu5ZQdj17vg Q4wCHIxKPLwdrmsihFgTy4orcw8xSnAwK4nwxvusjRDiTUmsrEotyo8vKs1JLT7EaAr0wkRm KdHkfGBqyiuJNzQxNLc0NDK2sDA3MlIS55364Uq4kEB6YklqdmpqQWoRTB8TB6dUAyPHsn2i Ja5Xn25Xl7tbWhdsLzV5szq/3J3es37rk5+tO8Y+L8u3Mena0fkxm//lz50XYCPme5xz0eoy cfcTb/hVppWUtJVtWOnXMT/Oea90nPP0l1UnrOLeVM06tOfqxImhm45LL413ndDF1X77Tb11 JeNm2z8tjlwF0pMulAYGXTTsqJKfukSJpTgj0VCLuag4EQDoJze2FQMAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170222092930eucas1p28a7700fe37cbeca5192903d19bd4f600 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170221192135epcas4p1811fa9ce35481d42144bdab368c9243a X-RootMTR: 20170221192135epcas4p1811fa9ce35481d42144bdab368c9243a References: <20170221192059.29745-1-thibault.saunier@osg.samsung.com> <20170221192059.29745-4-thibault.saunier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.02.2017 20:20, Thibault Saunier wrote: > It is required by the standard that the field order is set by the > driver. > > Signed-off-by: Thibault Saunier > > --- > > Changes in v5: > - Just adapt the field and never error out. > > Changes in v4: None > Changes in v3: > - Do not check values in the g_fmt functions as Andrzej explained in previous review > > Changes in v2: > - Fix a silly build error that slipped in while rebasing the patches > > drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > index 0976c3e0a5ce..44ed2afe0780 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > @@ -386,6 +386,9 @@ static int vidioc_try_fmt(struct file *file, void *priv, struct v4l2_format *f) > struct v4l2_pix_format_mplane *pix_mp = &f->fmt.pix_mp; > struct s5p_mfc_fmt *fmt; > > + if (f->fmt.pix.field == V4L2_FIELD_ANY) > + f->fmt.pix.field = V4L2_FIELD_NONE; > + In previous version the only supported field type was NONE, here you support everything. If the only supported format is none you should set 'field' unconditionally to NONE, nothing more. Regards Andrzej > mfc_debug(2, "Type is %d\n", f->type); > if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) { > fmt = find_format(f, MFC_FMT_DEC);