From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A31C77B7E for ; Thu, 1 Jun 2023 09:43:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232916AbjFAJn4 (ORCPT ); Thu, 1 Jun 2023 05:43:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232910AbjFAJnu (ORCPT ); Thu, 1 Jun 2023 05:43:50 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D03D0E48 for ; Thu, 1 Jun 2023 02:43:30 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3515TBNB016524; Thu, 1 Jun 2023 04:42:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=8slAiQhtNeEDPH5cE2i6jmsGl9SnzMbGOVBPNnG5StQ=; b=QsDRgCTBFtDzm+U2RhfKxqISLvpAdcBvJLxn1OBMIjtbZz+TJrBNQyQCwVpcx37oWgly Grr7uqq/g9B5WkWboIK5GJ5ayKOrz0btQbggtnHN0hVvTBzxBZR3yLSlpoISBJi6A4aW VKionq2LYUI3Kcn7OtZl4+VGsyKr3qtNOZfIchWRwR2zNFc3NF0sqMWBvbx8DZicXQDR ykauWIX2J3OOy/00HExLWTl6F13ZNinWvY9PYfNAeSEPiXHUthOoZp71MSmrSzc9cOcI 1hI+83D9F3hlfRZjo+G/NjPcwUtP5PLsCbm1bcOzfy4SRolc8kFTDt1A6HtbTyPOMTyS 1Q== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3que9mx33j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jun 2023 04:42:58 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 1 Jun 2023 10:42:56 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 1 Jun 2023 10:42:56 +0100 Received: from [198.90.251.45] (EDIN6T9W333.ad.cirrus.com [198.90.251.45]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 92A8745; Thu, 1 Jun 2023 09:42:56 +0000 (UTC) Message-ID: <78488c71-eef5-1a44-0b85-73c7ad0848c9@opensource.cirrus.com> Date: Thu, 1 Jun 2023 10:42:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: CSC3551 and devices missing related _DSD bits To: Armas Spann , Luke Jones , Takashi Iwai CC: , , , , , , , , , , , , , , , References: <1991650.PYKUYFuaPT@fedora> <87jzx3zaf8.wl-tiwai@suse.de> <19d69a5da8f1d4017ac14ed87f927ab82278073d.camel@ljones.dev> <12102f7419c5e44cd2133aa769e25dbd16f4e0c9.camel@codux.tech> From: Stuart Henderson In-Reply-To: <12102f7419c5e44cd2133aa769e25dbd16f4e0c9.camel@codux.tech> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: PgAw9JbGgD11sbnj0iAibcqjVuEEYWGw X-Proofpoint-ORIG-GUID: PgAw9JbGgD11sbnj0iAibcqjVuEEYWGw X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Takashi, Hi Stuart (and of course, all others in here), > > would you mind to evaluate this small (pseudo-)patch to be harmless? > (concerning the blow-up theory the first answer in this converstion) > > I won't push it upstream right now but I want to know if this patch > might be harmfull. I'm owning a GA402XY myself and we digged out that > the initial setting of the cr3551 can be done via: > > diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c > index 75020edd39e7..eaa06751bd48 100644 > --- a/sound/pci/hda/cs35l41_hda.c > +++ b/sound/pci/hda/cs35l41_hda.c > @@ -1243,6 +1243,12 @@ static int cs35l41_no_acpi_dsd(struct > cs35l41_hda *cs35l41, struct device *physd > hw_cfg->bst_type = CS35L41_EXT_BOOST; > hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH; > hw_cfg->gpio1.valid = true; > + } else if (strncmp(hid, "CSC3551", 7) == 0 && strcmp(cs35l41- >> acpi_subsystem_id, "10431463") == 0) { > + // TESTING - (Hook for GA402X) > + dev_warn(cs35l41->dev, "Warning: ASUS didn't provide > the needed ACPI _DSD properties for GA402X series, using defaults.."); > + hw_cfg->bst_type = CS35L41_EXT_BOOST; > + hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH; > + hw_cfg->gpio1.valid = true; > } else { > /* > * Note: CLSA010(0/1) are special cases which use a > slightly different design. I wouldn't recommend making speculative changes like the above. There are no "default" values as these attributes describe the hardware for the particular device and these can be different on each SKU.  In this case, it looks like the boost is being set incorrectly.  We're looking into how we can support these older devices, so please bear with us while we investigate.