From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbdK1KNF (ORCPT ); Tue, 28 Nov 2017 05:13:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23523 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752476AbdK1KND (ORCPT ); Tue, 28 Nov 2017 05:13:03 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20171120225830.96642-1-ebiggers3@gmail.com> References: <20171120225830.96642-1-ebiggers3@gmail.com> To: Eric Biggers Cc: dhowells@redhat.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , stable@vger.kernel.org Subject: Re: [PATCH] KEYS: add missing permission check for request_key() destination MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7848.1511863981.1@warthog.procyon.org.uk> Date: Tue, 28 Nov 2017 10:13:01 +0000 Message-ID: <7849.1511863981@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 28 Nov 2017 10:13:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Biggers wrote: > + if (do_perm_check) { > + ret = key_permission(make_key_ref(dest_keyring, 1), > + KEY_NEED_WRITE); dest_keyring may be NULL at this point as alloc_uid() doesn't automatically create keyrings. David