From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDE2C7EE29 for ; Tue, 30 May 2023 02:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbjE3Cxw (ORCPT ); Mon, 29 May 2023 22:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjE3Cxt (ORCPT ); Mon, 29 May 2023 22:53:49 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1732E8 for ; Mon, 29 May 2023 19:53:47 -0700 (PDT) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QVcKw1ZtXzqTYF; Tue, 30 May 2023 10:49:08 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 30 May 2023 10:53:45 +0800 Message-ID: <7852a2b4-b601-f4e8-bc5f-7b1bc9d9dc69@huawei.com> Date: Tue, 30 May 2023 10:53:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 1/2] soc: hisilicon: Support HCCS driver on Kunpeng SoC From: "lihuisong (C)" To: Sudeep Holla CC: , , , , , , , , , , References: <20230424073020.4039-1-lihuisong@huawei.com> <20230522072211.8894-1-lihuisong@huawei.com> <20230522072211.8894-2-lihuisong@huawei.com> <20230523093922.f2y4wrz3vkzi7kmw@bogus> <20230525073539.waaa7wpudohullcg@bogus> <5e0d81c8-5f52-82e5-5509-785e87a9a17e@huawei.com> In-Reply-To: <5e0d81c8-5f52-82e5-5509-785e87a9a17e@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudeep, 在 2023/5/25 16:12, lihuisong (C) 写道: > > 在 2023/5/25 15:35, Sudeep Holla 写道: >> On Thu, May 25, 2023 at 10:41:51AM +0800, lihuisong (C) wrote: >>> Hi Sudeep, >>> >>> Here, the interface is used to determine whether a port is in use or >>> enabled. >>> If we just use 'status', it cannot inidicates its own meaning by name. >>> What do you think? >>> >> How about "port_status" or "port-status" ? > The meaning of this status is a little board. > How about 'enable'? just a read-only entry. > > "using_status" --> "enable" ? What do you think? Its original purpose was to determine whether a port is in use or enabled. > In addition, I happen to have another problem when replace ioremap() > with acpi_os_ioremap(). > > The driver selects 'M' in .config to compile. > The driver cannot be compiled if we use acpi_os_ioremap(). > The compiling log is as follows: > --> > make -j80 >   CALL    scripts/checksyscalls.sh >   CC [M]  drivers/soc/hisilicon/kunpeng_hccs.o >   MODPOST Module.symvers > ERROR: modpost: "acpi_os_ioremap" > [drivers/soc/hisilicon/kunpeng_hccs.ko] undefined! > scripts/Makefile.modpost:136: recipe for target 'Module.symvers' failed > make[1]: *** [Module.symvers] Error 1 > Makefile:1978: recipe for target 'modpost' failed > make: *** [modpost] Error 2 > > The driver can be compiled if we selects 'Y' or export symbol for > acpi_os_ioremap. > So we have to export symbol for acpi_os_ioremap. > I plan to do it in another patch, and not in this series in case of > blocking the upload of this driver. > What do you think? Someone disagree we do it here. please see the patch[1]. So we have to keep what it was. [1] https://lore.kernel.org/linux-arm-kernel/d180192a-afad-00dc-426f-3d8d249cdd89@huawei.com/T/