From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD7D227456 for ; Tue, 7 Jan 2025 15:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736263020; cv=none; b=HvbTXPb3oBr2tMsKetIPSVUAfcPLrQjgx+czqW+6gT7IX+3jt+MX58pOa2mzWEIFcvjr3Rf4dPPjastvUk9KqTweZ3Mvu4HYwdMpMDSWTlS5wv3u8oAKw0TjkVgN0h3Qj/4LBYNQhwdeqAry4HXrYyfCUofhjkf53hTeuwjC9PY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736263020; c=relaxed/simple; bh=iIMKWVYEenXS4wVT1eUu2GxA6FMq7h3OfVPcY+6NPsU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=irxP3hxWSkeydGBBmnSvntRqNOSInhIMTsixaiXxmzVwfbcyjzpqoc73v71nP4hqUMQk+G/E70KgQA5ip/7EpPxeYaktDnLwYXFhsjfBnlJt5y4hiOQq8hqGval1cEVYNxhLsAKA0bhv143CVNsThEDgU/eN1X9FfYWKRGWKfEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZGlL+Aiu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZGlL+Aiu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736263009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ma3/zh91C/LiLjTFUq58PsMa7gSqvD7Ef9W+toJutkk=; b=ZGlL+AiuKWUe9XVFgcdU4uquPN/Xv87WR+JPJHcmwS6Sf8gOO41tMfTrxbUWq10VOZdDjP xqh+hojzbZyVQR4Fw9fXaYjnrr2eUKiAx34Hx6BZny8zI6SqARHHdif4wGAsCOOuqN0ZpH NMXQdWEeeaSvh51qlf+tOGr8N4ooAao= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-4lHpydmjMpSxc-k4NvOSTg-1; Tue, 07 Jan 2025 10:16:48 -0500 X-MC-Unique: 4lHpydmjMpSxc-k4NvOSTg-1 X-Mimecast-MFC-AGG-ID: 4lHpydmjMpSxc-k4NvOSTg Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38639b4f19cso9854467f8f.0 for ; Tue, 07 Jan 2025 07:16:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736263007; x=1736867807; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ma3/zh91C/LiLjTFUq58PsMa7gSqvD7Ef9W+toJutkk=; b=N2g2q6mRNvYsEgBJaOuLVoGBzYHCeqicu2KO2e1uM7yY2zMlCLNIZiYnuUCH//RYKP dkx0KA3e/2xshJGJMniJX0MVGUUrllXlKfJv1Wa8tg/dYgQWxy2tGKdpiNieZT1ZyznT +YH0zM262v0CasejI/Ea1skV099OJoTEgpCszMpNEn7SRiwxvJeBuqfFpityO9sHD+ZA 2GKagoBmL/UNQbYJPd5vusVCqqwEXlLeaQMAAr+TGCbTMoFbx+GMtOMgqGXLFhXC5wyr +UmvGPdVqj7jZm4YCPTPkB8bUnktbRlrKZ1XiwWMM3cSwGKUH1GkagPo/1eT6tzPiv5n Xx0w== X-Forwarded-Encrypted: i=1; AJvYcCW3bTNNHMnJieL6jNzXZMfYHDhgtHADnt1US/sXHzs/lA2lzzZOSL47sZGYAFrIH3mRTJPjCVcV+ORt3dk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq1qnbvwuJHnd+hG+8sxUxxy19BHoL/RJ8SXcE4So9esf1N3Rz DzuLZPAdISTUEEPbq5PBWulbg/tq7/8ifKx29nbG1U4l9g2jvAY9CTGuu4AKGG6yz5DXzsYefIc mikaoZyg4VT8qCz8NWRStlnnWCl6GEpnQgueY3W0fyy8tDJkG5yrg3fRzHiV5DQ== X-Gm-Gg: ASbGncvCAT5lzKJ/9tf2Ii89Ctb+30/sZ7QkWz2ol3OV9m3N1FxGrxUAFfHZfIRtWX5 lSCD0i+RsssrKaQkkkQpRV1lg8YfX7/qYJCP+49bWdaf77XUjYb1rwRuERlI1galU419iZIz4hL EBc9ZQkGtmETNb7EeVS2YHeqYlcfTcKUDkz/04aN3OZfgmLtVRHOLqcOGjdU9JOsECIcTjg5mq3 Li2RZTydGSg2h+XCVAZTX4H5CLbtn5JQDCCo1ZNFGRfV25EBDkvT1kblm2CWvJEMP0STY6lJyNw xToaM03vfDVX4ErwER7SACvtWczTVSHHdVAsg1QCyC4u9u0dswOB5Tz2Tg2qvn7nlqT6V+BaldJ /VtAculyGwEt+aJPkHwz6y0EhjjLtgss= X-Received: by 2002:adf:ae01:0:b0:38a:615c:825b with SMTP id ffacd0b85a97d-38a615c8353mr15606229f8f.21.1736263005767; Tue, 07 Jan 2025 07:16:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9Eqpa+YyRD8YF7F9Tb5CZKRDg6aF0h++RnF6RkL7nTIJkdzBiIwiqHG0JFE3gBl2fKiBe7w== X-Received: by 2002:adf:ae01:0:b0:38a:615c:825b with SMTP id ffacd0b85a97d-38a615c8353mr15606194f8f.21.1736263005378; Tue, 07 Jan 2025 07:16:45 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0f013946sm2414147366b.136.2025.01.07.07.16.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 07:16:44 -0800 (PST) Message-ID: <7854ef21-0a4f-4afa-a1f7-90e5cec19032@redhat.com> Date: Tue, 7 Jan 2025 16:16:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] vbox: Enable VBOXGUEST and VBOXSF_FS on ARM64 To: Christian Kujau Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org References: <1c6f68d1-a51a-1c38-2eca-89fa63dc30c6@nerdbynature.de> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <1c6f68d1-a51a-1c38-2eca-89fa63dc30c6@nerdbynature.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Christian, On 7-Jan-25 4:01 PM, Christian Kujau wrote: > Now that VirtualBox is able to run as a host on arm64 (e.g. the Apple M3 > processors) we can enable VBOXSF_FS (and in turn VBOXGUEST) for this > architecture. Tested with various runs of bonnie++ and dbench on an Apple > MacBook Pro with the latest Virtualbox 7.1.4 r165100 installed. > > Signed-off-by: Christian Kujau > Reviewed-by: Hans de Goede Thank you for the new version, note that v2 has already been applied to the vfs tree though. This is fine, the missing changelog is really not a big deal and the changelog gets dropped on applying the patch anyways. So this is all merged up now. Regards, Hans > > --- > v3: version history added, along with Hans' Reviewed-by > > v2: vboxvideo change removed, see: > https://lore.kernel.org/lkml/7384d96c-2a77-39b0-2306-90129bae9342@nerdbynature.de/ > > v1: initial version, see: > https://lore.kernel.org/lkml/a969298e-0986-470c-9711-703af784d672@redhat.com/ > > drivers/virt/vboxguest/Kconfig | 2 +- > fs/vboxsf/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/virt/vboxguest/Kconfig b/drivers/virt/vboxguest/Kconfig > index cc329887bfae..11b153e7454e 100644 > --- a/drivers/virt/vboxguest/Kconfig > +++ b/drivers/virt/vboxguest/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > config VBOXGUEST > tristate "Virtual Box Guest integration support" > - depends on X86 && PCI && INPUT > + depends on (ARM64 || X86) && PCI && INPUT > help > This is a driver for the Virtual Box Guest PCI device used in > Virtual Box virtual machines. Enabling this driver will add > diff --git a/fs/vboxsf/Kconfig b/fs/vboxsf/Kconfig > index b84586ae08b3..d4694026db8b 100644 > --- a/fs/vboxsf/Kconfig > +++ b/fs/vboxsf/Kconfig > @@ -1,6 +1,6 @@ > config VBOXSF_FS > tristate "VirtualBox guest shared folder (vboxsf) support" > - depends on X86 && VBOXGUEST > + depends on (ARM64 || X86) && VBOXGUEST > select NLS > help > VirtualBox hosts can share folders with guests, this driver >