From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07AA5382299 for ; Mon, 23 Mar 2026 22:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774304042; cv=none; b=NjzGqH3n0KUSLF/INXz5sc7WfTd8NJiyfD8mHrTZ8SU8RwyPFQCJuv+xSjwaANewPClqbPp2YVecH8xlAU3UQpiPdBySUtSvvZYxaRS2EK3fe+pX8LF0VNgpqIkBzdzV3zX6d/rliF9W0TtRqA0wi1tcuzRq6qjb5KUKi9FK0MQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774304042; c=relaxed/simple; bh=lh6B8bAK/G0Rf35K12CO6wGGToV6Ja1D9X6uvV20i0s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XNKdYMcdCgpUsIfcFfZAKcDA8MFiG0UaDn3hwKL1cFW8vlH+3B+WJOhlz8/ZLIa0DbEJuemI2OFzd5fEHM7jiwxC8HIHz9ONSumBKxWVt2blLhhKiLDihb3F05198cwCm0K3tmSLmBGm38dFJbzKuFPErlP00i9MtcThgDKHtuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HGRv4RPi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FHldqD9R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HGRv4RPi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FHldqD9R" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NHquZ6618658 for ; Mon, 23 Mar 2026 22:14:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Dq4WugyVxIXqcqDiAoenq+fof3XUEe5Rj0U0/uKDZ8s=; b=HGRv4RPiQNmsd1lE ukkXrXhU1yLPOlBfOJL8xB9jpFZbpyqABX60JHE6Nalz3lOkpK07Rb26J7K/pT46 2mKix00o1u80aK0PVzZRM/BAcSxKqH/uEXl5qILbYN/n9586ybjqMnZMMUuRLq+2 /qhuqwXcLVp54IhtEC0E+uV5Hlfvs+XU1stleWbyG876hMI3w7SpTDb/UeyekAk2 fx8XJz51bcKai+reyFwhdQ5B44DPjQu1dRmRDxZMnTr6AmRZDdZONeOItjeFJmFs lnlN7GUGgZsIWfd5h1x7lY86inc2mib0IzSvm/CpEfmEn3urjW8FhBHj1OcUhAW0 XDvj2A== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jgjwtb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 22:14:00 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-509044f54aaso36464991cf.1 for ; Mon, 23 Mar 2026 15:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774304039; x=1774908839; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dq4WugyVxIXqcqDiAoenq+fof3XUEe5Rj0U0/uKDZ8s=; b=FHldqD9RsyicpFJvvIrJgkT/6ph9wQyrzevnbvLlSkSF07NpWRGFFcB39w70ekt+jl tAbVpYPjKmsrit6nWVFTqUDOThroP4PlYqIfAFdmyoXngmdgGF2sitFeb61gKN/q7nxE rOeZ1opzAjeLiAzFPfjvgNi+usdA6Xer4PIK8WHf6iflMviZ/qUX/6Bb7GJLe9HqLjzP AxA0d4EaMuI6NXf0p3cGUI10vx4Bh3dV7gi0R0JHYYRQPZJ2S1ToKCpVDLF3isvdtBtw V3uhuWyzh1IMx7+PIt/WbwSS28QXqOEGypYu9PGcROeYMHqfPkP2ZBt8oustCkPZoGvi MqiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774304039; x=1774908839; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dq4WugyVxIXqcqDiAoenq+fof3XUEe5Rj0U0/uKDZ8s=; b=isXTPrCCyUG02D4uM4up6M1uzOkE69Y0E2DjVr+n8d2ial8GbSKea1kc0FQLp+cfs3 Qwpui+z8AD7jrekC9L/A9DRjV4fI/gVqp1rC/R79WE6lrGH1clfF0AM5EJrs8VPcmHfV n9slPII+lyJvEKrbb4ITi4nizE7DIbeuWURUwDJbscTFebE5fdb4B3RCfmJc9aZr/g+U tLZELGAsesArZe3Pjr681n5PfvyP9UYG4jGVRbx9zKGt962ee2Y3QUMgQULuBUcH08gz /qQcNavXxHwnmSmHUHngIFTQXMfFZtnp80/JBn04XCHWO7bov28tpgIwbOks8hhf76MZ TfHw== X-Forwarded-Encrypted: i=1; AJvYcCVjQLAJGG3tlTe3xXuG/Tcn/7eIrvjh4ZcEAziMu+sKiR+uIrZDLkUpZfJyriyMN8uLsL5+86ipeVyw10g=@vger.kernel.org X-Gm-Message-State: AOJu0YyqSRHKiCODZ6jx+9UKAWXaTe514UavaO2R8KZEheFypyh6gblj MKRNz0mRiJuls6YhoGgDnplFzLv+xVGPT93+OJtNe6eKYhf4Ywf0If/bCoMoR8v+luyHe8gy4iA JE4wPPoIkgfLQtqofdlaukviw84NRY6D3cuZmgazRu9LKzYZDaoEr96YUSjfFslVPIl4= X-Gm-Gg: ATEYQzzSaDVpPKtleAD1QbCTIjC2xBj+U7836hdMmJx2aM+s7WwsKM5q5eiYxXjoHnY qNwazz/1Lx+gSfmcUjfL+8PJHrs8z3oBjMXe/yJsXwhfYRwMtMvahVvj+UzH4gDn0+eeRAS5u/L KfJKHDdK0+NMKyht8fd0fliQp6bdwgjI473sJrdt4D/aNUNccHSWfS7PigfzPAeFM+JDJHtsVHW yfEJmyFD1RjFaKabEx6va6pZ9dF/90ocb6KYtJBNv1eivWcNVRFf+dBAwNsrhkf99moz+bualny tYCnKlUHELh/fDKsCnPT5uanxnZI4nph7+R+5SvyXjwqHyzaFwCVirS31wvj5iaio/bVIryjG3N 9FmGtkeLKqdz+QeK4IippBE4kkHKXbAcFVRhv2U8Sd8L6A1gM X-Received: by 2002:a05:622a:47:b0:50b:3be7:b16 with SMTP id d75a77b69052e-50b3be70c14mr198193891cf.37.1774304039467; Mon, 23 Mar 2026 15:13:59 -0700 (PDT) X-Received: by 2002:a05:622a:47:b0:50b:3be7:b16 with SMTP id d75a77b69052e-50b3be70c14mr198193511cf.37.1774304039008; Mon, 23 Mar 2026 15:13:59 -0700 (PDT) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4871105d35fsm2838765e9.19.2026.03.23.15.13.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 15:13:58 -0700 (PDT) Message-ID: <7856055a-7c97-45ad-8571-75e51cc92567@oss.qualcomm.com> Date: Mon, 23 Mar 2026 22:13:57 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: glymur: Add LPASS macro codecs and pinctrl To: Konrad Dybcio , andersson@kernel.org, linusw@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org Cc: srini@kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sibi.sankar@oss.qualcomm.com, mohammad.rafi.shaik@oss.qualcomm.com References: <20260311124230.2241781-1-srinivas.kandagatla@oss.qualcomm.com> <20260311124230.2241781-3-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: nKzitSVDjQ3EeZqRylQtVNM3FOpeKPUa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE2MyBTYWx0ZWRfX6iKUB7q8O0zM PpNjWNkvZaxm8C5ejvP2/VIrx4CC8I6k93eGCFpbbkF5YKA2sJ9GU641joNT+nTs4lAsgRzmyV6 g3YAintXkVnWOWgorw0trQXLNfAlEQkIUuiV9d9eiyvendVJy/u0XuFQilNXxxPEGhtVsYEdUpW xviD83cBD2blJvBU5Mc3EyLFyHCHKJQkpeNSr4B8pPibDlFo0eHcxTvDGVchjfTJB+lf2B0Yosw afL6Niz7qDSSZI5yjGQ5pVOBdfE1dDgo/MS0EpoTDyYP+nlmMISgp+At2MLmJJlytBd1Ff4JIt2 rOOXfBLky3YmzEoNFO0Nx4+PEDDMVPMXKMJFE7HPFgf71oaiKKn2miz7N/GkCtzIIeluxrVOXpW nuHpufug2VkPqCkmOq/mm9KfozBJUx9x0tCPN4EyiEmSJTZVVfKJbfYcVL+u6S50vdBU6YM28Xj elFQ1OYfQGe4cNuKPXg== X-Authority-Analysis: v=2.4 cv=CMInnBrD c=1 sm=1 tr=0 ts=69c1bb28 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=lgBHRGTc4hejgcBBOYkA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: nKzitSVDjQ3EeZqRylQtVNM3FOpeKPUa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_06,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230163 On 3/18/26 10:36 AM, Konrad Dybcio wrote: > On 3/11/26 1:42 PM, Srinivas Kandagatla wrote: >> Add LPASS macro codecs and LPASS TLMM pin controller on Qualcomm glymur. >> for proper sound support. >> >> Also add GPR(Generic Pack router) node along with >> APM(Audio Process Manager) and PRM(Proxy resource >> Manager) audio services. >> >> Co-developed-by: Mohammad Rafi Shaik >> Signed-off-by: Mohammad Rafi Shaik >> Signed-off-by: Srinivas Kandagatla >> --- > > [...] > >> + lpass_wsamacro: codec@6c90000 { >> + compatible = "qcom,glymur-lpass-wsa-macro", "qcom,sm8550-lpass-wsa-macro"; >> + reg = <0 0x06c90000 0 0x1000>; > > sz = 0x10_000 (no difference but for completeness) > > [...] > >> + lpass_wsa2macro: codec@6cb0000 { >> + compatible = "qcom,glymur-lpass-wsa-macro", "qcom,sm8550-lpass-wsa-macro"; >> + reg = <0 0x06cb0000 0 0x1000>; > > same here > > [...] > >> + lpass_tlmm: pinctrl@6e80000 { > > unit address doesn't match (reg is correct) > >> + compatible = "qcom,glymur-lpass-lpi-pinctrl", "qcom,sm8650-lpass-lpi-pinctrl"; >> + reg = <0 0x07760000 0 0x20000>; > > 0 -> 0x0 > >> + lpass_vamacro: codec@7660000 { >> + compatible = "qcom,glymur-lpass-va-macro", "qcom,sm8550-lpass-va-macro"; >> + reg = <0 0x07660000 0 0x1000>; > > _at least_ 0x2000, I don't know if the following registers are also > related Sure, will take a look at it and update it in next spin. --srini > > Konrad