Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err()

[Shawn Lin <shawn.lin@rock-chips.com>]

在 2026/10/21 星期三 18:14, Diederik de Haas 写道:
> The devm_request_threaded_irq() function already automatically logs
> detailed error messages on failure since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
> So remove the now-redundant driver-specific dev_err() calls.
> 

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks.

> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
> ---
>   drivers/pci/controller/dwc/pcie-dw-rockchip.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> index 14976861f8ef..a4dbfc52c2f1 100644
> --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> @@ -718,10 +718,8 @@ static int rockchip_pcie_configure_rc(struct platform_device *pdev,
>   	ret = devm_request_threaded_irq(dev, irq, NULL,
>   					rockchip_pcie_rc_sys_irq_thread,
>   					IRQF_ONESHOT, "pcie-sys-rc", rockchip);
> -	if (ret) {
> -		dev_err(dev, "failed to request PCIe sys IRQ\n");
> +	if (ret)
>   		return ret;
> -	}
>   
>   	/* LTSSM enable control mode */
>   	val = FIELD_PREP_WM16(PCIE_LTSSM_ENABLE_ENHANCE, 1);
> @@ -764,10 +762,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev,
>   	ret = devm_request_threaded_irq(dev, irq, NULL,
>   					rockchip_pcie_ep_sys_irq_thread,
>   					IRQF_ONESHOT, "pcie-sys-ep", rockchip);
> -	if (ret) {
> -		dev_err(dev, "failed to request PCIe sys IRQ\n");
> +	if (ret)
>   		return ret;
> -	}
>   
>   	/*
>   	 * LTSSM enable control mode, and automatically delay link training on