From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B809DC433FE for ; Thu, 10 Dec 2020 08:43:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D5F922CA1 for ; Thu, 10 Dec 2020 08:43:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388104AbgLJIng (ORCPT ); Thu, 10 Dec 2020 03:43:36 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9576 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730042AbgLJIng (ORCPT ); Thu, 10 Dec 2020 03:43:36 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cs6q849KSzM356; Thu, 10 Dec 2020 16:42:12 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 10 Dec 2020 16:42:51 +0800 Subject: Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support To: Robin Hsu , , , CC: References: <20201208081555.652932-1-robinh3123@gmail.com> <20201208081555.652932-3-robinh3123@gmail.com> From: Chao Yu Message-ID: <785e9f0a-c3d6-9cc5-f17a-a3cc58a43a0f@huawei.com> Date: Thu, 10 Dec 2020 16:42:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201208081555.652932-3-robinh3123@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/8 16:15, Robin Hsu wrote: > From: Robin Hsu > > Add F2FS compression support for sload > * Support file extension filter, either default-accept or default-deny > policy > * Support choice of compression algorithm, LZO (version 2) or LZ4 > (default) > * Support custom log of cluster size > * Support minimum number of compressed blocks per cluster (default 1). > A cluster will not be compressed if the number can not be met. > * suuport -r (read-only) option Could you please update manual as well? > + > + /* sldc: sload compression support */ Personally, I don't like the naming method of adding "sldc_" prefix... :( > + bool sldc_en; > + bool sldc_use_allow_list; /* default false to use the deny list */ > + struct compress_ctx sldc_cc; > + u8 sldc_ca; /* compress algorithm: 0 = LZO, 1 = LZ4 */ > + compress_ops *sldc_compr; > + enum filter_policy sldc_policy; > + /* max_cppc can used to specify minimum compression rate */ > + unsigned int sldc_min_cbpc; /* min compressed pages per cluster */ > + bool sldc_got_opt; > + bool sldc_immutable; > + struct ext_tbl_op *sldc_ef; /* extension filter */ The variables name like sldc_en, sldc_ca, min_cbpc, sldc_ef makes developers hard to understand w/o comments, and also there is no comments for several variable like sldc_en, sldc_cc... Could you please improve the naming like f2fs-tools style? Thanks,