Re: [PATCH] ARM: dts: exynos: Add front camera support to I9100

[Krzysztof Kozlowski <krzk@kernel.org>]

On 26/03/2021 17:25, Timon Baetz wrote:
> Add node for Samsung S5K5BAF CMOS image sensor and
> enable the associated MIPI CSI-2 receiver node.
> 
> Signed-off-by: Timon Baetz <timon.baetz@protonmail.com>
> ---
>  arch/arm/boot/dts/exynos4210-i9100.dts | 52 ++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts
> index 228de6d8c9d1..d31146c08b84 100644
> --- a/arch/arm/boot/dts/exynos4210-i9100.dts
> +++ b/arch/arm/boot/dts/exynos4210-i9100.dts
> @@ -147,6 +147,36 @@ battery@36 {
>  		};
>  	};
> 
> +	i2c_s5k5baf: i2c-gpio-1 {
> +		compatible = "i2c-gpio";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		sda-gpios = <&gpc1 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +		scl-gpios = <&gpc1 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +		i2c-gpio,delay-us = <2>;
> +
> +		s5k5bafx@2d {

The node name should be generic, so "image-sensor".

> +			compatible = "samsung,s5k5baf";
> +			reg = <0x2d>;
> +			vdda-supply = <&cam_io_en_reg>;
> +			vddreg-supply = <&vt_core_15v_reg>;
> +			vddio-supply = <&vtcam_reg>;
> +			clocks = <&camera 0>;
> +			clock-names = "mclk";
> +			stbyn-gpios = <&gpl2 0 1>;

GPIO_ACTIVE_LOW

> +			rstn-gpios = <&gpl2 1 1>;
> +			clock-frequency = <24000000>;
> +


Best regards,
Krzysztof