Re: [PATCH 1/7] ASoC: mediatek: mt79xx: add common header

["Maso Huang (黃加竹)" <Maso.Huang@mediatek.com>]

On Wed, 2023-06-14 at 09:44 +0200, AngeloGioacchino Del Regno wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Il 12/06/23 12:52, Maso Hunag ha scritto:
> > From: Maso Huang <maso.huang@mediatek.com>
> > 
> > Add header files for register definition and structure.
> > 
> > Signed-off-by: Maso Huang <maso.huang@mediatek.com>
> > ---
> >   sound/soc/mediatek/mt79xx/mt79xx-afe-common.h |  49 +++++
> >   sound/soc/mediatek/mt79xx/mt79xx-reg.h        | 206
> ++++++++++++++++++
> 
> Please, s/mt79xx/mt7981/g. Wildcards are not permitted.
> 

Hi Angelo,
Thanks for your review.
The oldest is mt7986, so I'll use mt7986 instead of mt79xx in v2 patch.

> >   2 files changed, 255 insertions(+)
> >   create mode 100644 sound/soc/mediatek/mt79xx/mt79xx-afe-common.h
> >   create mode 100644 sound/soc/mediatek/mt79xx/mt79xx-reg.h
> > 
> > diff --git a/sound/soc/mediatek/mt79xx/mt79xx-afe-common.h
> b/sound/soc/mediatek/mt79xx/mt79xx-afe-common.h
> > new file mode 100644
> > index 000000000000..13c9e51d7b38
> > --- /dev/null
> > +++ b/sound/soc/mediatek/mt79xx/mt79xx-afe-common.h
> > @@ -0,0 +1,49 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * mt79xx-afe-common.h  --  MediaTek 79xx audio driver definitions
> > + *
> > + * Copyright (c) 2021 MediaTek Inc.
> > + * Author: Vic Wu <vic.wu@mediatek.com>
> > + *         Maso Huang <maso.huang@mediatek.com>
> > + */
> > +
> > +#ifndef _MT_79XX_AFE_COMMON_H_
> > +#define _MT_79XX_AFE_COMMON_H_
> > +
> > +#include <sound/soc.h>
> > +#include <linux/list.h>
> > +#include <linux/regmap.h>
> > +#include "../common/mtk-base-afe.h"
> > +
> > +enum {
> > +MT79XX_MEMIF_DL1,
> > +MT79XX_MEMIF_VUL12,
> > +MT79XX_MEMIF_NUM,
> > +MT79XX_DAI_ETDM = MT79XX_MEMIF_NUM,
> > +MT79XX_DAI_NUM,
> > +};
> 
> Same for the enumeration entries, and the definitions and the
> function names.
> Please change everything to `mt7981` (strategy is to use the name of
> the oldest
> SoC: if the oldest is not 7981, change accordingly).
> 

The oldest is mt7986, so I'll use mt7986 instead of mt79xx in v2 patch.

> > +
> > +enum {
> > +MT79XX_IRQ_0,
> > +MT79XX_IRQ_1,
> > +MT79XX_IRQ_2,
> > +MT79XX_IRQ_NUM,
> > +};
> > +
> > +struct clk;
> > +
> > +struct mt79xx_afe_private {
> > +struct clk **clk;
> > +
> > +int pm_runtime_bypass_reg_ctl;
> > +
> > +/* dai */
> > +void *dai_priv[MT79XX_DAI_NUM];
> > +};
> > +
> > +unsigned int mt79xx_afe_rate_transform(struct device *dev,
> > +       unsigned int rate);
> > +
> > +/* dai register */
> > +int mt79xx_dai_etdm_register(struct mtk_base_afe *afe);
> > +#endif
> > diff --git a/sound/soc/mediatek/mt79xx/mt79xx-reg.h
> b/sound/soc/mediatek/mt79xx/mt79xx-reg.h
> > new file mode 100644
> > index 000000000000..28c0aeba9bdf
> > --- /dev/null
> > +++ b/sound/soc/mediatek/mt79xx/mt79xx-reg.h
> > @@ -0,0 +1,206 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * mt79xx-reg.h  --  MediaTek 79xx audio driver reg definition
> > + *
> > + * Copyright (c) 2021 MediaTek Inc.
> > + * Author: Vic Wu <vic.wu@mediatek.com>
> > + *         Maso Huang <maso.huang@mediatek.com>
> > + */
> > +
> > +#ifndef _MT79XX_REG_H_
> > +#define _MT79XX_REG_H_
> 
> _MT7981_REG_H_
> 
> Everything else looks ok.
> 

The oldest is mt7986, so I'll use mt7986 instead of mt79xx in v2 patch.

> Thanks,
> Angelo
> 

Best regards,
Maso