From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D061990A2 for ; Mon, 20 Jan 2025 09:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737364004; cv=none; b=nAzH7V0hKQwytUkx80VRuzOloDrf3MHbYOgDUSvkyru7kQk8umsxdxWBykSQpycBFP4Hsq9DAUlmdV9BgYx02+xJhqfZ55MR9fsoizGJsds4KiDkA+X6cen/nGNX12ZYcxVEGg2f2UoGfpzM7EbS1hyw5E3K0t2ULW/spbTP4GQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737364004; c=relaxed/simple; bh=bfk+amnPsJMmRc9NHYHA8SRXaeg37rsiHAakDtcyceo=; h=Message-ID:Date:MIME-Version:CC:Subject:To:References:From: In-Reply-To:Content-Type; b=uWEIuPDAMH27OOWeUyoCAML0Uhg+Z9JN2U0SGnAQgwOPzHOZL7EExvVAcXtpYZkxMkjSUmrbHNyXiPDVC4kh4VPekYBGfp6wZbm6vKckN+80TeQvyWPmPMObzcn+cLrXySBbPiyUX7L4vhAbuVZEmjmH44NbEdP30vypwi7Iy7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Yc4CG73g8zRlfV; Mon, 20 Jan 2025 17:04:10 +0800 (CST) Received: from kwepemg100017.china.huawei.com (unknown [7.202.181.58]) by mail.maildlp.com (Postfix) with ESMTPS id 21CA6140258; Mon, 20 Jan 2025 17:06:39 +0800 (CST) Received: from [10.174.178.120] (10.174.178.120) by kwepemg100017.china.huawei.com (7.202.181.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 20 Jan 2025 17:06:38 +0800 Message-ID: <7867c162-6a2e-4291-ac57-a7bb6df5c4ce@huawei.com> Date: Mon, 20 Jan 2025 17:06:37 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , Subject: Re: [PATCH v2 1/3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio To: References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-2-mawupeng1@huawei.com> <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> From: mawupeng In-Reply-To: <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemg100017.china.huawei.com (7.202.181.58) On 2025/1/20 14:24, Miaohe Lin wrote: > On 2025/1/16 14:16, Wupeng Ma wrote: >> From: Ma Wupeng > > Thanks for your patch. Some nits below. > >> >> Commit 6da6b1d4a7df ("mm/hwpoison: convert TTU_IGNORE_HWPOISON to >> TTU_HWPOISON") introduce TTU_HWPOISON to replace TTU_IGNORE_HWPOISON >> in order to stop send SIGBUS signal when accessing an error page after >> a memory error on a clean folio. However during page migration, anon >> folio must be set with TTU_HWPOISON during unmap_*(). For pagecache >> we need some policy just like the one in hwpoison_user_mappings to >> set this flag. So move this policy from hwpoison_user_mappings to >> unmap_poisoned_folio to handle this waring properly. > > s/waring/warning/g Thanks for your reply. will be fixed later. > >> >> Waring will be produced during unamp poison folio with the following log: > > s/Waring/Warning/g Thanks for your reply. will be fixed later.