From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, Sunil-kumar.Dommati@amd.com,
venkataprasad.potturu@amd.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] ASoC: amd: acp7x: add system and runtime PM ops
Date: Thu, 21 May 2026 17:07:40 +0530 [thread overview]
Message-ID: <786c749a-02f9-4e50-bf9c-62f2674eff4d@amd.com> (raw)
In-Reply-To: <346949dc-d4f9-420b-b208-65a02c4657a1@sirena.org.uk>
On 21/05/26 17:04, Mark Brown wrote:
> On Thu, May 07, 2026 at 02:33:47PM -0500, Mario Limonciello wrote:
>> On 5/7/26 13:11, Vijendar Mukunda wrote:
>>> +static int __maybe_unused snd_acp7x_resume(struct device *dev)
>>> +{
>>> + struct acp7x_dev_data *adata;
>>> + int ret;
>>> +
>>> + adata = dev_get_drvdata(dev);
>>> + ret = acp_hw_init(adata, dev);
>>> + if (ret)
>>> + dev_err(dev, "ACP init failed\n");
>>> +
>>> + return ret;
>>> +}
>> Both of snd_acp7x_runtime_resume and snd_acp7x_resume look identical. Will
>> there be later code (when machine driver and IO enablement come) that makes
>> them different?
>> If not; then I think you can drop snd_acp7x_runtime_resume().
>> If so; this makes sense to keep separately.
> Not seeing any response to this question from Mario?
Sorry I missed it. Will check and provide reply.
next prev parent reply other threads:[~2026-05-21 11:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 18:11 [PATCH 0/5] ASoC: AMD: ACP7.x initial PCI driver bring-up Vijendar Mukunda
2026-05-07 18:11 ` [PATCH 1/5] include: sound: add register header file for acp7.x series Vijendar Mukunda
2026-05-07 19:34 ` Mario Limonciello
2026-05-07 18:11 ` [PATCH 2/5] ASoC: amd: acp7x: add ACP PCI driver probe/remove sequence Vijendar Mukunda
2026-05-07 19:36 ` Mario Limonciello
2026-05-07 18:11 ` [PATCH 3/5] ASoC: amd: acp7x: add helper functions and hw ops Vijendar Mukunda
2026-05-07 19:34 ` Mario Limonciello
2026-05-07 18:11 ` [PATCH 4/5] ASoC: amd: enable acp7.x drivers build Vijendar Mukunda
2026-05-07 19:36 ` Mario Limonciello
2026-05-07 18:11 ` [PATCH 5/5] ASoC: amd: acp7x: add system and runtime PM ops Vijendar Mukunda
2026-05-07 19:33 ` Mario Limonciello
2026-05-21 11:34 ` Mark Brown
2026-05-21 11:37 ` Mukunda,Vijendar [this message]
2026-05-21 11:41 ` Mukunda,Vijendar
2026-05-21 11:43 ` Mario Limonciello
2026-05-21 23:15 ` [PATCH 0/5] ASoC: AMD: ACP7.x initial PCI driver bring-up Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786c749a-02f9-4e50-bf9c-62f2674eff4d@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome