mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
To: rafael@kernel.org, daniel.lezcano@linaro.org,
	rui.zhang@intel.com, amitk@kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com
Cc: linux-imx@nxp.com, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name
Date: Fri, 22 Sep 2023 15:01:37 +0530	[thread overview]
Message-ID: <786d197a-a2b5-2507-f5d7-24e8224a3922@gmail.com> (raw)
In-Reply-To: <20230917083443.3220-1-bragathemanick0908@gmail.com>


On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
> Added identifier names to respective definitions for fix
> warnings reported by checkpatch.pl
>
> WARNING: function definition argument 'void *' should also have an identifier name
> WARNING: function definition argument 'int *' should also have an identifier name
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
>   drivers/thermal/imx8mm_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index 14111ccf6e4c..5dc6c18f12df 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -78,7 +78,7 @@
>   struct thermal_soc_data {
>   	u32 num_sensors;
>   	u32 version;
> -	int (*get_temp)(void *, int *);
> +	int (*get_temp)(void *data, int *temp);
>   };
>   
>   struct tmu_sensor {

Hi Team, Could someone help in reviewing it.

Thanks,
Bragathe


  parent reply	other threads:[~2023-09-22  9:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-17  8:34 Bragatheswaran Manickavel
2023-09-19 17:04 ` Bragatheswaran Manickavel
2023-09-22  9:31 ` Bragatheswaran Manickavel [this message]
2023-09-25  7:47   ` Daniel Lezcano
2023-09-27 14:38     ` Bragatheswaran Manickavel
2023-09-28  7:40 ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=786d197a-a2b5-2507-f5d7-24e8224a3922@gmail.com \
    --to=bragathemanick0908@gmail.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®