mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: 王明-软件底层技术部 <machel@vivo.com>, LKML <linux-kernel@vger.kernel.org>
Cc: "opensource.kernel" <opensource.kernel@vivo.com>
Subject: Re: 回复: [PATCH v2] lib:Fix more error checking for debugfs_create_dir()
Date: Tue, 11 Jul 2023 19:58:06 -0700	[thread overview]
Message-ID: <7871b526-3cd4-9c78-298c-b03c95277b2d@infradead.org> (raw)
In-Reply-To: <SG2PR06MB3743963CD8DA3A48FC6C2122BD36A@SG2PR06MB3743.apcprd06.prod.outlook.com>



On 7/11/23 18:20, 王明-软件底层技术部 wrote:
> Hi Randy.
> The only maintainers I obtained using get_maintainer.pl were LKML, and there seems to be no other maintainers
> Do you have any good suggestions?: )
> 

Use 'git log lib/test_fpu.c' to see who merges patches to it.

> ~Ming
> -----邮件原件-----
> 发件人: Randy Dunlap <rdunlap@infradead.org> 
> 发送时间: 2023年7月12日 3:33
> 收件人: 王明-软件底层技术部 <machel@vivo.com>; linux-kernel@vger.kernel.org
> 抄送: opensource.kernel <opensource.kernel@vivo.com>
> 主题: Re: [PATCH v2] lib:Fix more error checking for debugfs_create_dir()
> 
> [Some people who received this message don't often get email from rdunlap@infradead.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi--
> 
> On 7/11/23 04:16, Wang Ming wrote:
>> In case of failure, debugfs_create_dir() does not return NULL, but an 
>> error pointer.  Most incorrect error checks were fixed, but the one in 
>> test_fpu_init() was forgotten.
>>
>> Fix the remaining error check.
>>
>> Signed-off-by: Wang Ming <machel@vivo.com>
> 
> You need to send this to some maintainer who can merge it, so please an appropriate maintainer to send it to.
> 
> Thanks.
> 
>> ---
>>  lib/test_fpu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/test_fpu.c b/lib/test_fpu.c index 
>> e82db19fed84..5d6aa4691b4a 100644
>> --- a/lib/test_fpu.c
>> +++ b/lib/test_fpu.c
>> @@ -69,7 +69,7 @@ static struct dentry *selftest_dir;  static int 
>> __init test_fpu_init(void)  {
>>       selftest_dir = debugfs_create_dir("selftest_helpers", NULL);
>> -     if (!selftest_dir)
>> +     if (IS_ERR(selftest_dir))
>>               return -ENOMEM;
>>
>>       debugfs_create_file_unsafe("test_fpu", 0444, selftest_dir, NULL,
> 
> --
> ~Randy

-- 
~Randy

      parent reply	other threads:[~2023-07-12  2:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11 11:16 Wang Ming
2023-07-11 19:33 ` Randy Dunlap
     [not found]   ` <SG2PR06MB3743963CD8DA3A48FC6C2122BD36A@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-12  2:58     ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7871b526-3cd4-9c78-298c-b03c95277b2d@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=machel@vivo.com \
    --cc=opensource.kernel@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®