From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E40D14A8E for ; Wed, 25 Feb 2026 18:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772043369; cv=none; b=B3P9sbkdA4BVzID5glnNxe7yWJ94gmSQalYsLWzmh6ZTodFLrtdeFKEAMU8dViM643fHHAyYDqS/HQ3W0/DvDidL76NEEzxSXgzPmrYKqVmX28/z4+GwvtIMIQjEH8nhsh2E1U+l8WvnN291gfe0vSawxTPp35CpPBCVJ2Uy96s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772043369; c=relaxed/simple; bh=pAAIi3Amde+7kXTOwlev9Ocut0JUJSu25Td9zH4yF/c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YmHNWu50jlWtSQNVFlaCnb122BDeh+fq2kt8ryLx7y3T/VogzKd9YsYtX3fNSOZzLZPTDULkIDGziQZeehG6wlNIsMCwFVlmgUt84Z6bssbBdxrHbi/HZrUPzXrCt6IpiT0+gnQEQLKwgdmixP9DaGbgThr9ZTVQsIOrl5lfoCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RY+/nUv7; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RY+/nUv7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772043368; x=1803579368; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pAAIi3Amde+7kXTOwlev9Ocut0JUJSu25Td9zH4yF/c=; b=RY+/nUv7DOgXDZFONihPaOyk3ZY45aTyVnFrcOT/n2zcBSnsKtRVO5E/ lC7kfGHH6OKblNmXM684KixTbDoUmkadmC5DWxYkC1cY01zK0DdmahuBR axedC82YgGHc2wStGP+J5TbaTlN2GQ0k3Wn351SlziEjnuYcpZzresoNT 1C8er4pIhnqK/l4v6LxjfyFsuxPcYQINkX2JTBYi+7tEXjytYMUEGIZn+ q0HUx2oIr5J01dS0BJ7bw/WY+3rxDi6kiSc9FrT2vivhEdQAhq/d+jkOT QlHv8I7rmHoquh1T9l/TH2Z30lVRxs/RogBSFzURmshswnAd3LeKw2Uy/ Q==; X-CSE-ConnectionGUID: 4sz5G8miTeOpGZLhxDSFXw== X-CSE-MsgGUID: IG9MpDAdS3CnBejZYh/LWw== X-IronPort-AV: E=McAfee;i="6800,10657,11712"; a="73268978" X-IronPort-AV: E=Sophos;i="6.21,311,1763452800"; d="scan'208";a="73268978" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2026 10:16:06 -0800 X-CSE-ConnectionGUID: 8kjpZJKaRua5CjsmBNeGfg== X-CSE-MsgGUID: 1RSuHNaBTWCt9p7oCIyQ8A== X-ExtLoop1: 1 Received: from mfalkows-mobl.ger.corp.intel.com (HELO [10.245.84.158]) ([10.245.84.158]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2026 10:16:05 -0800 Message-ID: <78744b04-cb28-42ce-a0c0-d9718ad1efa3@linux.intel.com> Date: Wed, 25 Feb 2026 19:16:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] accel/amdxdna: Fix suspend failure after enabling turbo mode To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com, mario.limonciello@amd.com References: <20260211204716.722788-1-lizhi.hou@amd.com> Content-Language: en-US From: "Falkowski, Maciej" In-Reply-To: <20260211204716.722788-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Maciej Falkowski On 2/11/2026 9:47 PM, Lizhi Hou wrote: > Enabling turbo mode disables hardware clock gating. Suspend requires > hardware clock gating to be re-enabled, otherwise suspend will fail. > Fix this by calling aie2_runtime_cfg() from aie2_hw_stop() to > re-enable clock gating during suspend. Also ensure that firmware is > initialized in aie2_hw_start() before modifying clock-gating > settings during resume. > > Fixes: f4d7b8a6bc8c ("accel/amdxdna: Enhance power management settings") > Signed-off-by: Lizhi Hou > --- > drivers/accel/amdxdna/aie2_pci.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c > index 5b326e4610e6..0d41a6764892 100644 > --- a/drivers/accel/amdxdna/aie2_pci.c > +++ b/drivers/accel/amdxdna/aie2_pci.c > @@ -323,6 +323,7 @@ static void aie2_hw_stop(struct amdxdna_dev *xdna) > return; > } > > + aie2_runtime_cfg(ndev, AIE2_RT_CFG_CLK_GATING, NULL); > aie2_mgmt_fw_fini(ndev); > xdna_mailbox_stop_channel(ndev->mgmt_chann); > xdna_mailbox_destroy_channel(ndev->mgmt_chann); > @@ -406,15 +407,15 @@ static int aie2_hw_start(struct amdxdna_dev *xdna) > goto stop_psp; > } > > - ret = aie2_pm_init(ndev); > + ret = aie2_mgmt_fw_init(ndev); > if (ret) { > - XDNA_ERR(xdna, "failed to init pm, ret %d", ret); > + XDNA_ERR(xdna, "initial mgmt firmware failed, ret %d", ret); > goto destroy_mgmt_chann; > } > > - ret = aie2_mgmt_fw_init(ndev); > + ret = aie2_pm_init(ndev); > if (ret) { > - XDNA_ERR(xdna, "initial mgmt firmware failed, ret %d", ret); > + XDNA_ERR(xdna, "failed to init pm, ret %d", ret); > goto destroy_mgmt_chann; > } >