From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756506AbdKDPD4 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 4 Nov 2017 11:03:56 -0400
Received: from mout.web.de ([212.227.17.12]:63784 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751361AbdKDPDx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 4 Nov 2017 11:03:53 -0400
Subject: Re: sr9800: Use common error handling code in sr9800_phy_powerup()
To: Geert Uytterhoeven <geert@linux-m68k.org>, netdev@vger.kernel.org,
        linux-usb@vger.kernel.org
Cc: =?UTF-8?Q?Bj=c3=b8rn_Mork?= <bjorn@mork.no>,
        "David S. Miller" <davem@davemloft.net>,
        Greg Ungerer <gerg@linux-m68k.org>,
        Liu Junliang <liujunliang_ljl@163.com>,
        Philippe Reynes <tremyfr@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <10f2b5a4-1dbd-2c4f-caaa-4225dff35296@users.sourceforge.net>
 <CAMuHMdU6K+KPZvsStfwPev9Z5v1RRYAwLr04FHjmeC=VUEMC+Q@mail.gmail.com>
 <0600e4f9-dd53-158c-556b-8a87dfc928e6@users.sourceforge.net>
 <CAMuHMdWpaohd4rFxLzBaBDE2v79487Ak8WQjJpjR465wnRvhXA@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <78748ef8-5d0d-f0e8-bce4-5e6f29c89089@users.sourceforge.net>
Date: Sat, 4 Nov 2017 16:03:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdWpaohd4rFxLzBaBDE2v79487Ak8WQjJpjR465wnRvhXA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:ptEl3+ZAdOLEHE0asbyGxV9kye7ilFhX/OvFiVOio33qpUz/MNq
 CGiY9EaIZrCAYT55Pr+8CjDEIB6xyyn+i0ZqGP3BUnZw66AH7CjHCpbnzf1NruBDkTuVJ3X
 xrIK2Ehj0XIRzGgbHeM7IFPyeSAGhKqjL9a4DwUOvOPs4JuDo5ztcj2060JcCqA6/Vm6IQS
 m6gW4pBiRJamdwjdAM8Kw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:hrplEeexM8I=:UakDw7OMUbf7SP7nP5oxBT
 pXCmvW95iKStsN3l4NKvV5wroH+v/jvJBIz1CTU4ceA4JqgQ0/DVpp0JN1Zdd4EwXZd85Jpxu
 435iqRkYlXcv8GRqE3z21WBuMgMgBzca2nJUHWPF0GzbgZNejd2l+wTzgVGJSI6pyb61jsP+M
 EAsiiyWkjyRHtOz98qabIFb5hVOmP7YCZItgamBVm6WHRWXTQS8Ah+Y5Sr7EOadfjULDE1v0V
 50V07jUDlQaLy5TAlisBHqqafTWWs/VRQlSag37TRHgef7Z9P1iOqOth/pfc41FsaI1bRFzYV
 m6sG0tbDiFLdCZwoQMXt+9mDPxwMm7JgESJDNWXbncP9gQ4xGbZsrrxm3dDbjeMgTIlP1rvXT
 kAPkTl4dl4ElKKBaHM+xLMvuIc2d0613X62eRIPXhd+sGuMGHK4XXiBw8aDANRHnDefwflVWx
 FkhPMEdChIItbftPnE7gurEtPBxzbvg0RFlEHewUtxyB+EtA2k48gwvPBz2JHGMOndGVpEW70
 6H0MWjlOvClutTC40grDWyV46FP0PEj2BFJYbILET3gST29YPRlwMC5QVDeaRd4IW8vmqstZb
 h4ehn1MDDm20Pn11VPweMyyKnM78Hanz2sxTz1IqljfnpoLaDMMrPp5CEbOGaLyJHOFi88262
 IXMh1gaNA1eQvpQ13ti7p/uUyg8bh8QcwfPMp1R3VdNpXuf37CnhL11aiZtJVWHUkkpzKgt8v
 t16r1vXcTmTCitIDsGT2m7/8eDIkQnDF0XoCj0x31ZB5GmjAgl8palEZ8+4/nDbHZssdrzZTP
 YNXHvk8BUsYiO27m1nYyAdXu4jHYoNUPalLNUhmOm/H1wdMPXQ=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> If you play the "smaller executable object code" card, people expect that
> you provide the actual numbers, too.

I can offer another bit of information for this software development discussion.

The affected source file can be compiled for the processor architecture “x86_64”
by a tool like “GCC 6.4.1+r251631-1.3” from the software distribution
“openSUSE Tumbleweed” with the following command example.

my_cc=/usr/bin/gcc-6 \
&& my_module=drivers/net/usb/sr9800.ko \
&& git checkout next-20171009 \
&& make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module}" \
&& size "${my_module}" \
&& git checkout ':/^sr9800: Use common error handling code in sr9800_phy_powerup' \
&& make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module}" \
&& size "${my_module}"


Do you find the following details useful for further clarification?

text: -47
data: 0
bss:  0

Regards,
Markus