From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 154D622DF99 for ; Mon, 6 Oct 2025 12:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759752542; cv=none; b=AKc9QQbKnrE3umDsSDK11ZQJaf+CkwP3KTOhzEsA9H097JwvXTEQZYO3EiDQa0AEdLmw6LQuf0g5eQ/K7UIpZJOPWqowmAU9h40tUPoN3zrRGrdLXuWSG/KhloZIJO+Rdi2yKuFLAYD/XufIfeePnKM7FX5DhIallhWfnCFuXv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759752542; c=relaxed/simple; bh=hrqK/XFzvEiAZUlds01NLi1j42ROedVIuEKHM25cYJ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e60R1izOhbrgpUgzhQNbvE+nqptrdxAqvmIdUu+7/zm+REW/tk0ZehdvI/6B9LdWdnt+EPRM+xUAcUWKwzJp6FGdzsu4z0FXj7B2EMXBu/TH9EUKjnaUWq1FkcZmB6IWjYGaaJukRFBoH6y9E3dUYFwmVEWAFXBFcuW4Pr/CHX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EmRt41tv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EmRt41tv" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59618Exc019977 for ; Mon, 6 Oct 2025 12:08:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HNgg2RXM9k9KELLP5e9ztNxYJsbYYa1dg1GbAma4nx4=; b=EmRt41tvImqz4VUv 355WGeyN0Gb4/ActV7Oxhv+/xm+uUOypwaqvoVmPKy3IiXT2Htol6RbIU7i7u9q2 iOWLsMh+gJNLYoPFAURdBMUOPnVaZToYFyzD3dbn7I0zr6z65yst6uerMhIayNpk m3j/3jQ2KriXVc2R8keIynL9H1JKuO2qqQaH3lr3pHKOkEnJ+3ttYjYhf+NB8vKU sCbLV7TzT6zsjK6DTSi3WEQyhK0usLwJfDY+sPf7BkhglMkTZt29t5qGrzRuU+8x QspsoMgH2UTBS0bf6k1t/TXoW4PFAYTJVuCq6JwZxEHh52V5r2KOL2nK03hbznoe lN3wMQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49jut1kqpd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 06 Oct 2025 12:08:59 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4e0f9bedf1aso15457041cf.0 for ; Mon, 06 Oct 2025 05:08:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759752538; x=1760357338; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HNgg2RXM9k9KELLP5e9ztNxYJsbYYa1dg1GbAma4nx4=; b=H1UirNQHL/5uo4yXw42y3Euyu9QjkFKuIB+HKVWl6XkzLRWwoJ4XCor7CmiFjajT5e LzyWF1bPue/phFvaHMElr7eJ37W9oWICO9jFrJ1YQcmokAjjbeSmkBYxPix2M5TOx8UJ mp+Dpk4RrN2fXJfu2owVbwF4aL2BrW/WFu+lsri0+QZZM18FspBGmq6JrBCL7t6NlcEN RWsrmjB17mEUlW/RuMJSNb7s97LKXCJlfvIXrEYMmwUw4a2QAFKHVH4dvuzaysiK6BUb VEYAEtnmN45ZYUHlfrfX6YSRxqrHjoCWlgUuAYrA1mPPvWlYJODN40Rj748R9M+m2dFC Qa4g== X-Forwarded-Encrypted: i=1; AJvYcCXdof1VIa2bTFCLGIfW5JpimI30O9nrD3vC6sG+C2ZtAq+nvs0CW7hL+tR2vlArjUXQEF0PC7fEU0d7slM=@vger.kernel.org X-Gm-Message-State: AOJu0YzRwIgCpjk91Io9LPAFpfcU7rJP8X5JgqehDURZZeT6iPbhUFwS WJp2Jn3MVoztcgtB/zjfGaPLTQVM9VoyUrciyNx6DFWCiOFb2wipAaHJEiGzOFpXCd6l1WfhqK9 UzCWzyGy/+t6D7pkCQFSNP5/K1kb8YqyDe9daRYghjP6LtFSTxrj3WqbUkxTsbr60DR8= X-Gm-Gg: ASbGncvU6DdoY+jbvnYBbEKlo1sfTgpBgzn/SCpsk4uG4k9FPARIB/71UzvxFZcRXFE QyekL4hYUryRxqiNYBcj+Sa3gKuyE9eeBsu/T8EdNkQFYehQ65IVPkCPS2amZTXw8J2vbMvd4eV wEmABmB/D+pz+pZnv++GIw1A2eIlhgCuAfMfRkV+JEYRIHiMW9efFqRGu96PO1V1r1P9rvG6UzS 7FsG9ChjZA14ULB730XfxANdcYik1l5s5U6E8rehAeDAS6FqJ4Evp1aUQDVn34ntzolrWSPEIOl At+2+7E8JaDKOdOO9qIk3nk+p3Oy9CB0g4EO310LTCAI89Bx/v4vXDpPrO2/nW5rv7v5Sd+DHdZ zbyTqNIcYwX7cX3XH4wTUAUd3jcA= X-Received: by 2002:ac8:5a96:0:b0:4d2:c24f:8495 with SMTP id d75a77b69052e-4e576ab6f37mr107262061cf.10.1759752537652; Mon, 06 Oct 2025 05:08:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8bowU3R1TIDKe1GmveF4bSNUeYIkMMrOzWhLy75q+bqmvRg7vOQ3n7jj9olpyE3GwUkaAtg== X-Received: by 2002:ac8:5a96:0:b0:4d2:c24f:8495 with SMTP id d75a77b69052e-4e576ab6f37mr107261611cf.10.1759752536958; Mon, 06 Oct 2025 05:08:56 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b4865a83c85sm1134746866b.27.2025.10.06.05.08.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 05:08:56 -0700 (PDT) Message-ID: <7875ad35-366d-4480-979f-426f5760aa2a@oss.qualcomm.com> Date: Mon, 6 Oct 2025 14:08:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] arm64: dts: qcom: r0q: enable ufs storage To: =?UTF-8?Q?Eric_Gon=C3=A7alves?= , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250920014637.38175-1-ghatto404@gmail.com> <20250920014637.38175-6-ghatto404@gmail.com> <97CA26D8-2CB5-4F90-A4C8-BCD81C688F35@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <97CA26D8-2CB5-4F90-A4C8-BCD81C688F35@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: MJ9WY4DfZT4ZLcj-_-TKwfQZR32kT55z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA0MDAyNyBTYWx0ZWRfX5Lua9IgXNhAO +1JoHQLvkhZ3cAoJ7T23zYjPsBIg67kOWjT/vxD944jaF7FizT+dcQAF23jqrqpHH/RD0cJC9ch 5FFsS1gXL/SpL83Wy6J0HU3iDGKXBZ3ssCR54RE3/JT46b9UdSji5VyuYoeZVy0ruTHXTsrqfO2 xYcrLTJ27skC3C2oJ63j157GFTmQlw5kZ5o5c+hvBPAf16MY/n2z8dEJwCbIgrKFak6/jI2L+7B Rps1zA4C++lmhEkjFDXU7HjvolKP/8LdmBt2SQO1L0CIgM82vYUpuZVY/HInPWeKEmfTRyXrr9s 2/8y5xjaGXWEhglN/5PrBw1q9OsHJN2SXrNwHLPskEvp/oDHE/3t4NNZ2Slhgy/6VP/U6pok3Es RF2azvr79iT6k+NvnEvs79eS9Pq0Pg== X-Authority-Analysis: v=2.4 cv=Vqcuwu2n c=1 sm=1 tr=0 ts=68e3b15b cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=55atk-L8scUrgOgygXAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: MJ9WY4DfZT4ZLcj-_-TKwfQZR32kT55z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-06_04,2025-10-02_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510040027 On 9/25/25 11:37 PM, Eric Gonçalves wrote: > > > On September 25, 2025 10:07:31 AM GMT-03:00, Konrad Dybcio wrote: >> On 9/20/25 3:46 AM, Eric Gonçalves wrote: >>> Enable UFS internal storage of the Samsung Galaxy S22. >>> >>> Signed-off-by: Eric Gonçalves >>> --- >>> .../boot/dts/qcom/sm8450-samsung-r0q.dts | 39 +++++++++++++++++++ >>> 1 file changed, 39 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts >>> index c088f1acf6ea..0a55ce952f93 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts >>> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts >>> @@ -146,6 +146,24 @@ vreg_l5b_0p88: ldo5 { >>> regulator-max-microvolt = <888000>; >>> regulator-initial-mode = ; >>> }; >>> + >>> + vreg_l6b_1p2: ldo6 { >>> + regulator-min-microvolt = <1200000>; >>> + regulator-max-microvolt = <1200000>; >>> + regulator-initial-mode = ; >>> + }; >>> + >>> + vreg_l7b_2p5: ldo7 { >>> + regulator-min-microvolt = <2504000>; >>> + regulator-max-microvolt = <2504000>; >>> + regulator-initial-mode = ; >>> + }; >>> + >>> + vreg_l9b_1p2: ldo9 { >>> + regulator-min-microvolt = <1200000>; >>> + regulator-max-microvolt = <1200000>; >>> + regulator-initial-mode = ; >>> + }; >>> }; >>> >>> regulators-1 { >>> @@ -370,6 +388,27 @@ tsp_int_sleep: tsp_int_sleep_state { >>> }; >>> }; >>> >>> +&ufs_mem_hc { >>> + reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>; >>> + >>> + vcc-supply = <&vreg_l7b_2p5>; >>> + vcc-max-microamp = <1100000>; >> >> because you set this, you should also set regulator-allow-set-mode and >> regulator-allowed-modes >> >> Konrad > Why is that necessary? Because that is then translated into the mode selection, based on the aggregated usage That said, you may also choose to omit this if you want to run all regulators at high-power mode (less efficient at idle), which forcefully ensures you're not hitting any current limits Konrad